From 04e9d82918b0eb19d48d31d58fef1fedeba35e69 Mon Sep 17 00:00:00 2001
From: Chad Horohoe <chadh@wikimedia.org>
Date: Fri, 11 Jul 2014 19:20:28 -0700
Subject: [PATCH] Remove broken by design maintenance test

Any test that depends on the output of maintenance scripts is
asking for failure. This test fails quite often on HHVM and
is very very easy to break on single-database setups like most
users have. A harmless misconfiguration of SQLite will also
cause it to fail.

Change-Id: Ie90284eae847accea0569745005827f1af796940
---
 tests/phpunit/maintenance/getSlaveServerTest.php | 68 ------------------------
 1 file changed, 68 deletions(-)
 delete mode 100644 tests/phpunit/maintenance/getSlaveServerTest.php

diff --git a/tests/phpunit/maintenance/getSlaveServerTest.php b/tests/phpunit/maintenance/getSlaveServerTest.php
deleted file mode 100644
index 165dc55158c..00000000000
--- a/tests/phpunit/maintenance/getSlaveServerTest.php
+++ /dev/null
@@ -1,68 +0,0 @@
-<?php
-
-require_once __DIR__ . "/../../../maintenance/getSlaveServer.php";
-
-/**
- * Tests for getSlaveServer
- *
- * @group Database
- * @covers GetSlaveServer
- */
-class GetSlaveServerTest extends MediaWikiTestCase {
-
-	/**
-	 * Yields a regular expression that matches a good DB server name
-	 *
-	 * It matches IPs or hostnames, both optionally followed by a
-	 * port specification
-	 *
-	 * @return string The regular expression
-	 */
-	private function getServerRE() {
-		if ( $this->db->getType() === 'sqlite' ) {
-			// for SQLite, only the empty string is a good server name
-			return '';
-		}
-
-		$octet = '([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])';
-		$ip = "(($octet\.){3}$octet)";
-
-		$label = '([a-zA-Z]([a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)';
-		$hostname = "($label(\.$label)*)";
-
-		return "($ip|$hostname)(:[0-9]{1,5})?";
-	}
-
-	function testPlain() {
-		$gss = new GetSlaveServer();
-		$gss->execute();
-
-		$this->expectOutputRegex( "/^" . self::getServerRE() . "\n$/D" );
-	}
-
-	function testXmlDumpsBackupUseCase() {
-		global $wgDBprefix;
-
-		global $argv;
-		$argv = array( null, "--globals" );
-
-		$gss = new GetSlaveServer();
-		$gss->loadParamsAndArgs();
-		$gss->execute();
-		$gss->globals();
-
-		// The main answer
-		$output = $this->getActualOutput();
-		$firstLineEndPos = strpos( $output, "\n" );
-		if ( $firstLineEndPos === false ) {
-			$this->fail( "Could not find end of first line of output" );
-		}
-		$firstLine = substr( $output, 0, $firstLineEndPos );
-		$this->assertRegExp( "/^" . self::getServerRE() . "$/D",
-			$firstLine, "DB Server" );
-
-		// xmldumps-backup relies on the wgDBprefix in the output.
-		$this->expectOutputRegex( "/^[[:space:]]*\[wgDBprefix\][[:space:]]*=> "
-			. $wgDBprefix . "$/m" );
-	}
-}
-- 
2.11.4.GIT