From 4f8783fe91ba4b999473fddf6c072b47abe51d23 Mon Sep 17 00:00:00 2001
From: nicolasconnault <nicolasconnault>
Date: Thu, 16 Aug 2007 17:53:08 +0000
Subject: [PATCH] MDL-10873 Now deleting the preference from user_preferences
 if the value submitted is empty. The grader report will then revert to the
 site default

---
 grade/report/grader/preferences.php | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/grade/report/grader/preferences.php b/grade/report/grader/preferences.php
index 0ee4e4133..b190c7dd2 100644
--- a/grade/report/grader/preferences.php
+++ b/grade/report/grader/preferences.php
@@ -41,14 +41,15 @@ $context = get_context_instance(CONTEXT_COURSE, $course->id);
 require_capability('gradereport/grader:manage', $context);
 
 // If data submitted, then process and store.
-if ($form = data_submitted()) {
-    foreach ($form as $preference => $value) {
+if ($data = data_submitted()) {
+
+    foreach ($data as $preference => $value) {
         switch ($preference) {
             case 'persistflt':
                 set_user_preference('calendar_persistflt', intval($value));
                 break;
             default:
-                if ($value == GRADE_REPORT_PREFERENCE_DEFAULT) {
+                if ($value == GRADE_REPORT_PREFERENCE_DEFAULT || empty($value)) {
                     unset_user_preference($preference);
                 } else {
                     set_user_preference($preference, $value);
@@ -77,7 +78,7 @@ print_grade_plugin_selector($course->id, 'report', 'grader');
 if (has_capability('moodle/site:config')) {
     echo '<div id="siteconfiglink"><a href="' . $CFG->wwwroot . '/admin/settings.php?section=gradereportgrader">';
     echo get_string('changesitedefaults', 'grades');
-    echo "</div>\n";
+    echo "</a></div>\n";
 }
 
 // Add tabs
-- 
2.11.4.GIT