histogram: Make histograms crash less55/655/1
commit461a4b25060835346f13986fe44ae8b9abcdded9
authorRobin Sonefors <robin.sonefors@op5.com>
Tue, 6 May 2014 15:51:13 +0000 (6 17:51 +0200)
committerRobin Sonefors <robin.sonefors@op5.com>
Tue, 6 May 2014 15:58:38 +0000 (6 17:58 +0200)
tree0b584cc00278763564eeeada77a3a82a3f24b6de
parent244311b75b7c92e9cbac757894871c6fddf19d2d
histogram: Make histograms crash less

They used to crash whenever you tried to view a host histogram for a
host that had an unreachable service.

This fixes bug #7751. It could be that it's still crash:able, but my
brand new, relatively encompassing suite of tests should be easy to
extend if new ways of achieving that are discovered.

As described in comments for #7751, there is a fundamental problem with
how our histograms are presented - therefore, this moves histograms to
the main menu, and because I literally got saving for free, I'm throwing
that in as well, at no extra charge.

Finally, this moves the histogram views to the report module where they
belong, and some unused code - such as a custom CSS with no relevant
content - are deleted.

Change-Id: I4955df5b16fbccf1ace7a93587eaab8191026bdb
Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
18 files changed:
application/views/histogram/css/bg.png [deleted file]
application/views/histogram/css/histogram.css [deleted file]
application/views/histogram/histogram.php [deleted file]
application/views/histogram/index.php [deleted file]
application/views/histogram/options.php [deleted file]
application/views/histogram/setup.php [deleted file]
application/views/menu/menu.php
application/views/template_head.php
features/histogram.feature [new file with mode: 0644]
features/reports.feature
modules/reports/controllers/histogram.php
modules/reports/libraries/Histogram_options.php
modules/reports/libraries/Summary_options.php
modules/reports/models/summary_reports.php
modules/reports/views/histogram/histogram.php [new file with mode: 0644]
modules/reports/views/histogram/js/histogram.js [moved from application/views/histogram/js/histogram.js with 62% similarity]
modules/reports/views/histogram/options.php [new file with mode: 0644]
modules/reports/views/reports/header.php