| commit | d5d430a281ee0db45777cef5ebd9110a6bc5b383 | |
| author | dtucker <dtucker> | |
| Fri, 8 Jan 2010 07:53:43 +0000 (8 07:53 +0000) | ||
| committer | dtucker <dtucker> | |
| Fri, 8 Jan 2010 07:53:43 +0000 (8 07:53 +0000) | ||
| tree | ad5be9e6a59d8d6ecc529a4ebb6add67e3efd0bc | treesnapshot (tar.gz zip) |
| parent | 3389bb4093af78ed70fa557fe7e19caa6053e6b8 | commitdiff |
- guenther@cvs.openbsd.org 2009/12/20 07:28:36
[ssh.c sftp.c scp.c]
When passing user-controlled options with arguments to other programs,
pass the option and option argument as separate argv entries and
not smashed into one (e.g., as -l foo and not -lfoo). Also, always
pass a "--" argument to stop option parsing, so that a positional
argument that starts with a '-' isn't treated as an option. This
fixes some error cases as well as the handling of hostnames and
filenames that start with a '-'.
Based on a diff by halex@
ok halex@ djm@ deraadt@
[ssh.c sftp.c scp.c]
When passing user-controlled options with arguments to other programs,
pass the option and option argument as separate argv entries and
not smashed into one (e.g., as -l foo and not -lfoo). Also, always
pass a "--" argument to stop option parsing, so that a positional
argument that starts with a '-' isn't treated as an option. This
fixes some error cases as well as the handling of hostnames and
filenames that start with a '-'.
Based on a diff by halex@
ok halex@ djm@ deraadt@
| ChangeLog | diffblobblamehistory | |
| scp.c | diffblobblamehistory | |
| sftp.c | diffblobblamehistory | |
| ssh.c | diffblobblamehistory | |
| sshd_config.5 | diffblobblamehistory |