| commit | 100aca1848023d4564d933c73347ccfaa48b0e36 | |
| author | Patric Stout <truebrain@openttd.org> | |
| Sat, 9 Jul 2022 10:27:58 +0000 (9 12:27 +0200) | ||
| committer | GitHub <noreply@github.com> | |
| Sat, 9 Jul 2022 10:27:58 +0000 (9 12:27 +0200) | ||
| tree | 44329c7332950a678a8f5396772389fbe4beecfe | treesnapshot (tar.gz zip) |
| parent | 9957675a660000d7e975d0e7faffc49c03279a7c | commitdiff |
Fix: CmdRemoveRoadStop didn't validate the height property properly (#9945)
Height was a unsigned 32bit integer, where TileAddWrap uses a
signed 32bit integer for the height. In result, there was an
implicit cast from unsigned to signed, messing things up.
But looking at it from a functional perspective, allowing such
large values is not sensible. In fact, width is restricted to
just a 8bit integer. By changing height to a 8bit integer too,
the implicit cast will never make a positive value negative anymore.
Height was a unsigned 32bit integer, where TileAddWrap uses a
signed 32bit integer for the height. In result, there was an
implicit cast from unsigned to signed, messing things up.
But looking at it from a functional perspective, allowing such
large values is not sensible. In fact, width is restricted to
just a 8bit integer. By changing height to a 8bit integer too,
the implicit cast will never make a positive value negative anymore.
| src/station_cmd.cpp | diffblobblamehistory | |
| src/station_cmd.h | diffblobblamehistory |