| commit | 710e83999bbf8ae614b9310744c5306a7cbc858b | |
| author | Allan McRae <allan@archlinux.org> | |
| Tue, 23 Aug 2011 05:00:19 +0000 (23 15:00 +1000) | ||
| committer | Allan McRae <allan@archlinux.org> | |
| Mon, 29 Aug 2011 01:55:22 +0000 (29 11:55 +1000) | ||
| tree | a1831fbc56e22792ae3d7973dfac43a1f0147cdb | treesnapshot (tar.gz zip) |
| parent | d1240f67eab6dfa7e3344cd84dd8849b38ce337c | commitdiff |
pacman-key: import everything then revoke on --populate
The optimization of only importing keys that were not to be later
revoked was a not smart enough. For example, if a key was
in both a repos keyring and its revoke list, alternate runs of
pacman-key --populate would add then remove the key from the pacman
keyring. This problem is made worse when considering the possibility
of multiple keyrings being imported.
Instead, import all keys followed by the revoking of all keys. This
may result in a key being added then revoked, but that is not much of
an issue given that is a very fast operation.
Signed-off-by: Allan McRae <allan@archlinux.org>
The optimization of only importing keys that were not to be later
revoked was a not smart enough. For example, if a key was
in both a repos keyring and its revoke list, alternate runs of
pacman-key --populate would add then remove the key from the pacman
keyring. This problem is made worse when considering the possibility
of multiple keyrings being imported.
Instead, import all keys followed by the revoking of all keys. This
may result in a key being added then revoked, but that is not much of
an issue given that is a very fast operation.
Signed-off-by: Allan McRae <allan@archlinux.org>
| scripts/pacman-key.sh.in | diffblobblamehistory |