| commit | 986e99a613605985f64f0e3e4c2635717931f77d | |
| author | Dan McGee <dan@archlinux.org> | |
| Wed, 29 Feb 2012 22:47:39 +0000 (29 16:47 -0600) | ||
| committer | Dan McGee <dan@archlinux.org> | |
| Mon, 5 Mar 2012 17:44:34 +0000 (5 11:44 -0600) | ||
| tree | 074a7197e1bfb2c301687873a6a6dde16ea1e683 | treesnapshot (tar.gz zip) |
| parent | 4b384b7f0b0e840e09e3bffd2dbb59b88bdd4864 | commitdiff |
Fix a potential memory leak in filelist creation
If we begin to create a file list when loading a package, but abort
because of an error to one of our goto labels, the memory used to create
the file list will leak. This is because we use a set of local variables
to hold the data, and thus _alpm_pkg_free() cannot clean up for us.
Use the file list struct on the package object as much as possible to
keep state when building the file list, thus allowing _alpm_pkg_free()
to clean up any partially built data.
Signed-off-by: Dan McGee <dan@archlinux.org>
If we begin to create a file list when loading a package, but abort
because of an error to one of our goto labels, the memory used to create
the file list will leak. This is because we use a set of local variables
to hold the data, and thus _alpm_pkg_free() cannot clean up for us.
Use the file list struct on the package object as much as possible to
keep state when building the file list, thus allowing _alpm_pkg_free()
to clean up any partially built data.
Signed-off-by: Dan McGee <dan@archlinux.org>
| lib/libalpm/be_package.c | diffblobblamehistory |