Add macros for looping through a List without a ListCell.
commit14dd0f27d7cd56ffae9ecdbe324965073d01a9ff
authorNathan Bossart <nathan@postgresql.org>
Thu, 4 Jan 2024 22:09:34 +0000 (4 16:09 -0600)
committerNathan Bossart <nathan@postgresql.org>
Thu, 4 Jan 2024 22:09:34 +0000 (4 16:09 -0600)
tree3ae126d6f1e2dab9ce5b1ac788912a374c18c0c7
parent5e8674dc83926f52516f847f1a77e8d38e94e143
Add macros for looping through a List without a ListCell.

Many foreach loops only use the ListCell pointer to retrieve the
content of the cell, like so:

    ListCell   *lc;

    foreach(lc, mylist)
    {
        int         myint = lfirst_int(lc);

        ...
    }

This commit adds a few convenience macros that automatically
declare the loop variable and retrieve the current cell's contents.
This allows us to rewrite the previous loop like this:

    foreach_int(myint, mylist)
    {
        ...
    }

This commit also adjusts a few existing loops in order to add
coverage for the new/adjusted macros.  There is presently no plan
to bulk update all foreach loops, as that could introduce a
significant amount of back-patching pain.  Instead, these macros
are primarily intended for use in new code.

Author: Jelte Fennema-Nio
Reviewed-by: David Rowley, Alvaro Herrera, Vignesh C, Tom Lane
Discussion: https://postgr.es/m/CAGECzQSwXKnxGwW1_Q5JE%2B8Ja20kyAbhBHO04vVrQsLcDciwXA%40mail.gmail.com
src/backend/executor/execExpr.c
src/backend/replication/logical/relation.c
src/backend/replication/logical/tablesync.c
src/backend/replication/pgoutput/pgoutput.c
src/include/nodes/pg_list.h