| commit | 248c2d19238c7616531caa8b3101cca4f656185c | |
| author | Michael Paquier <michael@paquier.xyz> | |
| Fri, 25 Oct 2024 03:02:04 +0000 (25 12:02 +0900) | ||
| committer | Michael Paquier <michael@paquier.xyz> | |
| Fri, 25 Oct 2024 03:02:04 +0000 (25 12:02 +0900) | ||
| tree | 2d4a32495c904f7d16f2fb97e904c82abe6fbabe | treesnapshot (tar.gz zip) |
| parent | 1564339bfe23b2d1aa6403d6a08a7eaae0373cf9 | commitdiff |
Refactor code converting a publication name List to a StringInfo
The existing get_publications_str() is renamed to GetPublicationsStr()
and is moved to pg_subscription.c, so as it is possible to reuse it at
two locations of the tablesync code where the same logic was duplicated.
fetch_remote_table_info() was doing two List->StringInfo conversions
when dealing with a server of version 15 or newer. The conversion
happens only once now.
This refactoring leads to less code overall.
Author: Peter Smith
Reviewed-by: Michael Paquier, Masahiko Sawada
Discussion: https://postgr.es/m/CAHut+PtJMk4bKXqtpvqVy9ckknCgK9P6=FeG8zHF=6+Em_Snpw@mail.gmail.com
The existing get_publications_str() is renamed to GetPublicationsStr()
and is moved to pg_subscription.c, so as it is possible to reuse it at
two locations of the tablesync code where the same logic was duplicated.
fetch_remote_table_info() was doing two List->StringInfo conversions
when dealing with a server of version 15 or newer. The conversion
happens only once now.
This refactoring leads to less code overall.
Author: Peter Smith
Reviewed-by: Michael Paquier, Masahiko Sawada
Discussion: https://postgr.es/m/CAHut+PtJMk4bKXqtpvqVy9ckknCgK9P6=FeG8zHF=6+Em_Snpw@mail.gmail.com