| commit | 44ccdce514c4b3b92c8aca744e9cf7be4580be0b | |
| author | Fujii Masao <fujii@postgresql.org> | |
| Thu, 21 Jul 2022 13:52:50 +0000 (21 22:52 +0900) | ||
| committer | Fujii Masao <fujii@postgresql.org> | |
| Fri, 22 Jul 2022 02:59:38 +0000 (22 11:59 +0900) | ||
| tree | b1ed7b38677d1b1d602529d89a027407dd808082 | treesnapshot (tar.gz zip) |
| parent | a1b56090eb54544b8ae01b95b424c254c6b71678 | commitdiff |
postgres_fdw: Fix bug in checking of return value of PQsendQuery().
When postgres_fdw begins an asynchronous data fetch, it submits FETCH query
by using PQsendQuery(). If PQsendQuery() fails and returns 0, postgres_fdw
should report an error. But, previously, postgres_fdw reported an error
only when the return value is less than 0, though PQsendQuery() never return
the values other than 0 and 1. Therefore postgres_fdw could not handle
the failure to send FETCH query in an asynchronous data fetch.
This commit fixes postgres_fdw so that it reports an error
when PQsendQuery() returns 0.
Back-patch to v14 where asynchronous execution was supported in postgres_fdw.
Author: Fujii Masao
Reviewed-by: Japin Li, Tom Lane
Discussion: https://postgr.es/m/b187a7cf-d4e3-5a32-4d01-8383677797f3@oss.nttdata.com
When postgres_fdw begins an asynchronous data fetch, it submits FETCH query
by using PQsendQuery(). If PQsendQuery() fails and returns 0, postgres_fdw
should report an error. But, previously, postgres_fdw reported an error
only when the return value is less than 0, though PQsendQuery() never return
the values other than 0 and 1. Therefore postgres_fdw could not handle
the failure to send FETCH query in an asynchronous data fetch.
This commit fixes postgres_fdw so that it reports an error
when PQsendQuery() returns 0.
Back-patch to v14 where asynchronous execution was supported in postgres_fdw.
Author: Fujii Masao
Reviewed-by: Japin Li, Tom Lane
Discussion: https://postgr.es/m/b187a7cf-d4e3-5a32-4d01-8383677797f3@oss.nttdata.com
| contrib/postgres_fdw/postgres_fdw.c | diffblobblamehistory |