Fix CLUSTER tuplesorts on abbreviated expressions.
commit8ab0ebb9a842dc6063d1374a38b47a3b7ee64afe
authorPeter Geoghegan <pg@bowt.ie>
Thu, 21 Apr 2022 00:17:43 +0000 (20 17:17 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Thu, 21 Apr 2022 00:17:43 +0000 (20 17:17 -0700)
tree276a71a850b02ee9a9187664b4bb9cacb4950659
parenteafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
Fix CLUSTER tuplesorts on abbreviated expressions.

CLUSTER sort won't use the datum1 SortTuple field when clustering
against an index whose leading key is an expression.  This makes it
unsafe to use the abbreviated keys optimization, which was missed by the
logic that sets up SortSupport state.  Affected tuplesorts output tuples
in a completely bogus order as a result (the wrong SortSupport based
comparator was used for the leading attribute).

This issue is similar to the bug fixed on the master branch by recent
commit cc58eecc5d.  But it's a far older issue, that dates back to the
introduction of the abbreviated keys optimization by commit 4ea51cdfe8.

Backpatch to all supported versions.

Author: Peter Geoghegan <pg@bowt.ie>
Author: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKG+bA+bmwD36_oDxAoLrCwZjVtST2fqe=b4=qZcmU7u89A@mail.gmail.com
Backpatch: 10-
src/backend/utils/sort/tuplesort.c
src/test/regress/expected/cluster.out
src/test/regress/sql/cluster.sql