Improve the naming in wal_sync_method code.
commit8d140c58229d6224882f881d9b62ba06236e71d3
authorNathan Bossart <nathan@postgresql.org>
Fri, 13 Oct 2023 20:16:45 +0000 (13 15:16 -0500)
committerNathan Bossart <nathan@postgresql.org>
Fri, 13 Oct 2023 20:16:45 +0000 (13 15:16 -0500)
tree97c6f71d2fd795dfa42446b505b7c43ff145243f
parentc5a032e518acc259d31d5e7bd85acdea3b4e9c93
Improve the naming in wal_sync_method code.

* sync_method is renamed to wal_sync_method.

* sync_method_options[] is renamed to wal_sync_method_options[].

* assign_xlog_sync_method() is renamed to assign_wal_sync_method().

* The names of the available synchronization methods are now
  prefixed with "WAL_SYNC_METHOD_" and have been moved into a
  WalSyncMethod enum.

* PLATFORM_DEFAULT_SYNC_METHOD is renamed to
  PLATFORM_DEFAULT_WAL_SYNC_METHOD, and DEFAULT_SYNC_METHOD is
  renamed to DEFAULT_WAL_SYNC_METHOD.

These more descriptive names help distinguish the code for
wal_sync_method from the code for DataDirSyncMethod (e.g., the
recovery_init_sync_method configuration parameter and the
--sync-method option provided by several frontend utilities).  This
change also prevents name collisions between the aforementioned
sets of code.  Since this only improves the naming of internal
identifiers, there should be no behavior change.

Author: Maxim Orlov
Discussion: https://postgr.es/m/CACG%3DezbL1gwE7_K7sr9uqaCGkWhmvRTcTEnm3%2BX1xsRNwbXULQ%40mail.gmail.com
src/backend/access/transam/xlog.c
src/backend/storage/file/fd.c
src/backend/utils/misc/guc_tables.c
src/include/access/xlog.h
src/include/access/xlogdefs.h
src/include/port/freebsd.h
src/include/port/linux.h
src/include/utils/guc_hooks.h
src/tools/pgindent/typedefs.list