| commit | d37e0d0c50ee560fa2e7dc2a4dc904a885957985 | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Sun, 24 Mar 2024 16:31:05 +0000 (24 12:31 -0400) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Sun, 24 Mar 2024 16:31:05 +0000 (24 12:31 -0400) | ||
| tree | 6eb52d0fd793b3e4d74e4bad0325e29c810431bb | treesnapshot (tar.gz zip) |
| parent | 225e1dde463ae312714d71a929f45cfd153df2be | commitdiff |
Release PQconninfoOptions array in GetDbnameFromConnectionOptions().
It wasn't getting freed in one code path, which Coverity identified as
a resource leak. It's probably of little consequence, but re-ordering
the code into the correct sequence is no more work than dismissing the
complaint. Minor oversight in commit a145f424d.
While here, improve the unreasonably clunky coding of
FindDbnameInConnParams: use of an output parameter is unnecessary
and prone to uninitialized-variable problems.
It wasn't getting freed in one code path, which Coverity identified as
a resource leak. It's probably of little consequence, but re-ordering
the code into the correct sequence is no more work than dismissing the
complaint. Minor oversight in commit a145f424d.
While here, improve the unreasonably clunky coding of
FindDbnameInConnParams: use of an output parameter is unnecessary
and prone to uninitialized-variable problems.
| src/bin/pg_basebackup/streamutil.c | diffblobblamehistory |