Don't try to fix eliminated nbtree array scan keys.
commitf22e17f76cf569a797c45268081feadc8ebd68c7
authorPeter Geoghegan <pg@bowt.ie>
Thu, 18 Apr 2024 15:48:41 +0000 (18 11:48 -0400)
committerPeter Geoghegan <pg@bowt.ie>
Thu, 18 Apr 2024 15:48:41 +0000 (18 11:48 -0400)
treefe8dffbeda7311ba5cd91e1fb920ba3f18fa33d6
parent9e72f6bfae1707fca1a297db433f6145d582a1c2
Don't try to fix eliminated nbtree array scan keys.

Preprocessing for nbtree index scans allowed array "input" scan keys
already marked eliminated during array-specific preprocessing to be
"fixed up" during preprocessing proper.  This allowed eliminated scan
keys on DESC index columns to spurious have their strategy commuted,
causing assertion failures.

To fix, teach _bt_fix_scankey_strategy to ignore these scan keys.  This
brings it in line with its only caller, _bt_preprocess_keys.

Oversight in commit 5bf748b8, which enhanced nbtree ScalarArrayOp
execution.

Reported-By: Donghang Lin <donghanglin@gmail.com>
Discussion: https://postgr.es/m/CAA=D8a2sHK6CAzZ=0CeafC-Y-MFXbYxnRSHvZTi=+JHu6kAa8Q@mail.gmail.com
src/backend/access/nbtree/nbtutils.c