Addressing PHP8 incompatibilities - Miscellaneous
commit40b272fa51eadf9cfb5420b1ddc69c96818c3f90
authorChristopher Speck <die.drachen@gmail.com>
Mon, 29 May 2023 14:40:22 +0000 (29 10:40 -0400)
committerChristopher Speck <die.drachen@gmail.com>
Tue, 30 May 2023 16:06:16 +0000 (30 12:06 -0400)
treeabbb3ae92620344aa385c706083f70164a5b6378
parentdd94e2efcfb7253a96378da58543e9fb5ba6f1c5
Addressing PHP8 incompatibilities - Miscellaneous

Summary:
More perusing through Phabricator to find and address incompatibilities.

Refs T13588

Test Plan:
- Creating macros, changing their text.
- Upload to use existing SSH key instead of generate one.
- Modify alt text of an uploaded file.
- Create phame post
- Delete phriction document
- Move tasks around on workboard, assign story points
- Generate Diviner docs
- Bulk modify tasks

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21869
29 files changed:
scripts/repository/commit_hook.php
scripts/ssh/ssh-exec.php
src/aphront/response/AphrontAjaxResponse.php
src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php
src/applications/conduit/controller/PhabricatorConduitAPIController.php
src/applications/diviner/atom/DivinerAtom.php
src/applications/diviner/storage/DivinerLiveSymbol.php
src/applications/diviner/workflow/DivinerGenerateWorkflow.php
src/applications/files/xaction/PhabricatorFileAltTextTransaction.php
src/applications/herald/typeahead/HeraldRuleDatasource.php
src/applications/macro/engine/PhabricatorMemeEngine.php
src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php
src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php
src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php
src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php
src/applications/phame/controller/PhameLiveController.php
src/applications/phame/storage/PhamePost.php
src/applications/phriction/editor/PhrictionTransactionEditor.php
src/applications/project/controller/PhabricatorProjectMoveController.php
src/applications/project/state/PhabricatorWorkboardViewState.php
src/applications/project/typeahead/PhabricatorProjectDatasource.php
src/applications/repository/storage/PhabricatorRepository.php
src/applications/search/controller/PhabricatorSearchController.php
src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
src/applications/transactions/bulk/PhabricatorBulkEngine.php
src/infrastructure/log/PhabricatorSSHLog.php
support/startup/preamble-utils.php