| commit | 42876de60d28c5a96a6f337926e79630f2dc1e46 | |
| author | epriestley <git@epriestley.com> | |
| Thu, 19 May 2022 19:19:48 +0000 (19 12:19 -0700) | ||
| committer | epriestley <git@epriestley.com> | |
| Thu, 19 May 2022 20:21:04 +0000 (19 13:21 -0700) | ||
| tree | 8c0e1d96cc005e57fde3032778a17fddaa1f4e7c | treesnapshot (tar.gz zip) |
| parent | fee8297121f03b2c5018e3149285b53ba6b75910 | commitdiff |
Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
Summary:
Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:
- Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
- Objects that use EditEngine to generate a comment area.
This is the vast majority of pathways, but not entirely exhaustive.
Test Plan: Created and commented on a task, explicitly attaching images. Saw images attach properly.
Maniphest Tasks: T13603
Differential Revision: https://secure.phabricator.com/D21830
Summary:
Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:
- Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
- Objects that use EditEngine to generate a comment area.
This is the vast majority of pathways, but not entirely exhaustive.
Test Plan: Created and commented on a task, explicitly attaching images. Saw images attach properly.
Maniphest Tasks: T13603
Differential Revision: https://secure.phabricator.com/D21830