Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
commit6136964093cbd17ea0b95a4513474f23b1f6484d
authorepriestley <git@epriestley.com>
Thu, 16 Dec 2021 22:07:59 +0000 (16 14:07 -0800)
committerepriestley <git@epriestley.com>
Thu, 16 Dec 2021 23:24:21 +0000 (16 15:24 -0800)
treec355b4da887014ed9a4f3a01c75781ece4998f14
parentdc705cea7fec719861d8d0d19f7400cb344e74fe
Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration

Summary:
Ref T13588. This configuration value may not be set.

Also fix an issue in `bin/storage` and whatever else I hit between now and this diff actually uploading.

Also fix a MySQLi report mode difference, beginning in PHP 8.1.

Also update a bunch of "static" property usage in Lisk.

Test Plan: Ran `bin/files ...` locally under PHP 8.1.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21744
13 files changed:
.arclint
scripts/sql/manage_storage.php
src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
src/applications/meta/query/PhabricatorApplicationQuery.php
src/applications/people/query/PhabricatorPeopleQuery.php
src/applications/people/storage/PhabricatorUser.php
src/applications/phid/handle/pool/PhabricatorHandleList.php
src/infrastructure/cluster/PhabricatorDatabaseRef.php
src/infrastructure/query/PhabricatorQuery.php
src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php
src/infrastructure/storage/lisk/LiskDAO.php
src/infrastructure/util/PhabricatorHash.php
src/infrastructure/util/PhabricatorMetronome.php