Double-write file attachment to old "edge" storage and new "attachment" storage
commitd017f3f21021388ef60b56afdd9c0d7480c21e4f
authorepriestley <git@epriestley.com>
Tue, 10 May 2022 19:04:46 +0000 (10 12:04 -0700)
committerepriestley <git@epriestley.com>
Thu, 19 May 2022 20:21:03 +0000 (19 13:21 -0700)
treef99d782b938225f5f53263d3262f7e7114f7b92d
parent7fcc0f9ebd91a61b8c19801a0d578e08c96f9197
Double-write file attachment to old "edge" storage and new "attachment" storage

Summary: Ref T13603. This adds a second write to new "attachment" storage to all writers except one in Paste, which creates the file inline.

Test Plan:
  - Updated a macro image, confirmed a write to "attachment" storage (transaction pathway).
  - Updated a blog profile image, confirmed a write to "attachment" storage (legacy pathway).

Maniphest Tasks: T13603

Differential Revision: https://secure.phabricator.com/D21816
src/applications/files/storage/PhabricatorFile.php
src/applications/files/storage/PhabricatorFileAttachment.php
src/applications/transactions/constants/PhabricatorTransactions.php
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
src/applications/transactions/storage/PhabricatorApplicationTransaction.php