| commit | 0f0e94ca71fe6c3320e6f13e1f856fe95e15ecac | |
| author | epriestley <git@epriestley.com> | |
| Fri, 2 Oct 2020 16:09:10 +0000 (2 09:09 -0700) | ||
| committer | epriestley <git@epriestley.com> | |
| Fri, 2 Oct 2020 16:19:04 +0000 (2 09:19 -0700) | ||
| tree | 8250a73557ae7ac1c975de4b520cea30c440a40b | treesnapshot (tar.gz zip) |
| parent | a5f20f7106697a405f26b558098426f8d4452f4a | commitdiff |
Use "getInlines()", not "_inlines", to access inlines on client Changeset objects
Summary:
See PHI1898. An install is reporting an execution/initialization order issue where this code is reachable before `_inlines` is initialized.
I can't immediately reproduce it, but using "getInlines()" is preferable anyway and seems likely to fix the problem.
Test Plan: Viewed revisions with inlines, added/removed/edited/replied to inlines, didn't find anything broken.
Differential Revision: https://secure.phabricator.com/D21475
Summary:
See PHI1898. An install is reporting an execution/initialization order issue where this code is reachable before `_inlines` is initialized.
I can't immediately reproduce it, but using "getInlines()" is preferable anyway and seems likely to fix the problem.
Test Plan: Viewed revisions with inlines, added/removed/edited/replied to inlines, didn't find anything broken.
Differential Revision: https://secure.phabricator.com/D21475
| resources/celerity/map.php | diffblobblamehistory | |
| webroot/rsrc/js/application/diff/DiffChangeset.js | diffblobblamehistory |