| commit | 3dea92081bbe25af69b596ca6c6c04c139bae371 | |
| author | epriestley <git@epriestley.com> | |
| Wed, 13 May 2020 14:59:06 +0000 (13 07:59 -0700) | ||
| committer | epriestley <git@epriestley.com> | |
| Wed, 13 May 2020 15:14:37 +0000 (13 08:14 -0700) | ||
| tree | 9365aed8f22d9c73fb8f2bc439e82c182e2e1c64 | treesnapshot (tar.gz zip) |
| parent | df139f044b9b68e179a45ffaa43f6030b55cd401 | commitdiff |
Fix an issue where passphrase-protected private keys were stored without discarding passphrases
Summary:
Ref T13454. See <https://discourse.phabricator-community.org/t/newly-created-ssh-private-keys-with-passphrase-not-working-anymore/3883>.
After changes to distinguish between invalid and passphrase-protected keys, SSH private key management code incorrectly uses "-y ..." ("print public key") when it means "-p ..." ("modify input file, removing passphrase"). This results in the command having no effect, and Passphrase stores the raw input credential, not the stripped version.
We can't recover the keys because we don't store the passphrase, so no migration here is really possible. (We could add more code to detect this case, but it's presumably rare.)
Also, correct the behavior of the "Show Public Key" action: this is available for users who can see the credential and does not require edit permission.
Test Plan:
- Created a new credential with a passphrase, then showed the public key.
Maniphest Tasks: T13006, T13454
Differential Revision: https://secure.phabricator.com/D21245
Summary:
Ref T13454. See <https://discourse.phabricator-community.org/t/newly-created-ssh-private-keys-with-passphrase-not-working-anymore/3883>.
After changes to distinguish between invalid and passphrase-protected keys, SSH private key management code incorrectly uses "-y ..." ("print public key") when it means "-p ..." ("modify input file, removing passphrase"). This results in the command having no effect, and Passphrase stores the raw input credential, not the stripped version.
We can't recover the keys because we don't store the passphrase, so no migration here is really possible. (We could add more code to detect this case, but it's presumably rare.)
Also, correct the behavior of the "Show Public Key" action: this is available for users who can see the credential and does not require edit permission.
Test Plan:
- Created a new credential with a passphrase, then showed the public key.
Maniphest Tasks: T13006, T13454
Differential Revision: https://secure.phabricator.com/D21245
| src/applications/auth/sshkey/PhabricatorAuthSSHPrivateKey.php | diffblobblamehistory | |
| src/applications/passphrase/controller/PassphraseCredentialViewController.php | diffblobblamehistory |