| commit | 58d3f6145a853fe6439014e8b24383ca749da966 | |
| author | epriestley <git@epriestley.com> | |
| Thu, 17 Sep 2020 20:50:24 +0000 (17 13:50 -0700) | ||
| committer | epriestley <git@epriestley.com> | |
| Thu, 17 Sep 2020 20:55:47 +0000 (17 13:55 -0700) | ||
| tree | 36f2cbae8a68a204228ed74da5cb5eb73196df5a | treesnapshot (tar.gz zip) |
| parent | f21a00a3159e6e0154de8e27f7787864e6bbb4ea | commitdiff |
Fix an issue where known Subversion commits are incorrectly shown as "Discovering..."
Summary:
Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases.
Use "withRepository()", which gives us the correct identifier resolution behavior.
Test Plan: Viewed a subversion repository history in Diffusion, saw commit details after change.
Maniphest Tasks: T13552
Differential Revision: https://secure.phabricator.com/D21469
Summary:
Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases.
Use "withRepository()", which gives us the correct identifier resolution behavior.
Test Plan: Viewed a subversion repository history in Diffusion, saw commit details after change.
Maniphest Tasks: T13552
Differential Revision: https://secure.phabricator.com/D21469
| src/applications/diffusion/view/DiffusionCommitGraphView.php | diffblobblamehistory |