| commit | b21b73b8dd35301e083080a5ed7c7c83ae366ca3 | |
| author | epriestley <git@epriestley.com> | |
| Thu, 9 Jul 2020 19:23:31 +0000 (9 12:23 -0700) | ||
| committer | epriestley <git@epriestley.com> | |
| Thu, 9 Jul 2020 21:20:50 +0000 (9 14:20 -0700) | ||
| tree | 9f25adb502985165c17295cfaa5cea8a78935c95 | treesnapshot (tar.gz zip) |
| parent | 73c4240415e033571144e486ff67411f68dd2b19 | commitdiff |
Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state
Summary:
See PHI1810. Build toward support for "Request Review" by non-authors on drafts, to forcefully pull a revision out of draft.
Currently, some action strings can't vary based on revision state or the current viewer, so this "pull out of draft" action would have to either: say "Request Review"; or be a totally separate action.
Neither seem great, so allow the labels and messages to vary based on the viewer and revision state.
Test Plan: Grepped for affected symbols, see followup changes.
Differential Revision: https://secure.phabricator.com/D21401
Summary:
See PHI1810. Build toward support for "Request Review" by non-authors on drafts, to forcefully pull a revision out of draft.
Currently, some action strings can't vary based on revision state or the current viewer, so this "pull out of draft" action would have to either: say "Request Review"; or be a totally separate action.
Neither seem great, so allow the labels and messages to vary based on the viewer and revision state.
Test Plan: Grepped for affected symbols, see followup changes.
Differential Revision: https://secure.phabricator.com/D21401