Fix an out-of-date API call on the destruction pathway for Pholio mocks
commitc3be82fe6e096a7992e426b3a5a4fcc10a5723b1
authorepriestley <git@epriestley.com>
Fri, 10 Apr 2020 14:56:37 +0000 (10 07:56 -0700)
committerepriestley <git@epriestley.com>
Fri, 10 Apr 2020 15:01:34 +0000 (10 08:01 -0700)
treee149193ee60544cdebd56885bb92c55a6673cf03
parenta2fb91b8af4baa032cf578e8a27af91c6aa72520
Fix an out-of-date API call on the destruction pathway for Pholio mocks

Summary:
See <https://discourse.phabricator-community.org/t/destroying-a-mock-using-bin-remove-destroy-mx-gives-an-error/3728>.

Currently, Pholio calls an older API method on the mock destruction pathway. This call was introduced in D19911 but the callsite was only partially updated in D19914.

Test Plan: Ran "bin/remove destroy Mx" to destroy a mock. Before: fatal with a bad call; after: clean destruction.

Differential Revision: https://secure.phabricator.com/D21081
src/applications/pholio/storage/PholioMock.php