| commit | 322fd48afbed1ef7b834ac343a0c8687bcb33695 | |
| author | Michael S. Tsirkin <mst@redhat.com> | |
| Tue, 15 Feb 2011 16:27:55 +0000 (15 18:27 +0200) | ||
| committer | Aurelien Jarno <aurelien@aurel32.net> | |
| Sun, 20 Feb 2011 14:18:26 +0000 (20 15:18 +0100) | ||
| tree | 82f95b267a611b09914fa0f8b028715e2a2f1aaf | treesnapshot (tar.gz zip) |
| parent | ee912ccfa007351a62ba42bd60499769f6c02c1e | commitdiff |
e1000: verify we have buffers, upfront
The spec says: Any descriptor with a non-zero status byte has been
processed by the hardware, and is ready to be handled by the software.
Thus, once we change a descriptor status to non-zero we should
never move the head backwards and try to reuse this
descriptor from hardware.
This actually happened with a multibuffer packet
that arrives when we don't have enough buffers.
Fix by checking that we have enough buffers upfront
so we never need to discard the packet midway through.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
The spec says: Any descriptor with a non-zero status byte has been
processed by the hardware, and is ready to be handled by the software.
Thus, once we change a descriptor status to non-zero we should
never move the head backwards and try to reuse this
descriptor from hardware.
This actually happened with a multibuffer packet
that arrives when we don't have enough buffers.
Fix by checking that we have enough buffers upfront
so we never need to discard the packet midway through.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
| hw/e1000.c | diffblobblamehistory |