| commit | 733f0b02c80c3a7106d8327a83948ab68db10ea7 | |
| author | Michael S. Tsirkin <mst@redhat.com> | |
| Tue, 6 Apr 2010 11:18:19 +0000 (6 14:18 +0300) | ||
| committer | Aurelien Jarno <aurelien@aurel32.net> | |
| Thu, 6 May 2010 05:28:49 +0000 (6 07:28 +0200) | ||
| tree | d18117416943eefe7946444bb0ac256aa1ac51e5 | treesnapshot (tar.gz zip) |
| parent | 3e0650a9c95f343ca5da2b89dc4ad1cd67c2c2d7 | commitdiff |
qemu: address todo comment in exec.c
exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys,
so let's do it, along the lines of stl_phys.
The reason to address 16 bit accesses specifically is that virtio relies
on these accesses to be done atomically, using memset as we do now
breaks this assumption, which is reported to cause qemu with kvm
to read wrong index values under stress.
https://bugzilla.redhat.com/show_bug.cgi?id=525323
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys,
so let's do it, along the lines of stl_phys.
The reason to address 16 bit accesses specifically is that virtio relies
on these accesses to be done atomically, using memset as we do now
breaks this assumption, which is reported to cause qemu with kvm
to read wrong index values under stress.
https://bugzilla.redhat.com/show_bug.cgi?id=525323
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
| exec.c | diffblobblamehistory |