From 95ee3914bfd551aeec49932a400530141865acad Mon Sep 17 00:00:00 2001 From: Blue Swirl Date: Sat, 18 Sep 2010 05:53:15 +0000 Subject: [PATCH] blkdebug: fix enum comparison The signedness of enum types depend on the compiler implementation. Therefore the check for negative values may or may not be meaningful. Fix by explicitly casting to a signed integer. Since the values are also checked earlier against event_names table, this is an internal error. Change the 'if' to 'assert'. This also avoids a warning with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- block/blkdebug.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2a63df9323..4d6ff0a368 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -439,9 +439,7 @@ static void blkdebug_debug_event(BlockDriverState *bs, BlkDebugEvent event) struct BlkdebugRule *rule; BlkdebugVars old_vars = s->vars; - if (event < 0 || event >= BLKDBG_EVENT_MAX) { - return; - } + assert((int)event >= 0 && event < BLKDBG_EVENT_MAX); QLIST_FOREACH(rule, &s->rules[event], next) { process_rule(bs, rule, &old_vars); -- 2.11.4.GIT