qapi/error: Check format string argument in error_*prepend()pull-error-2020-07-24
commit192cf54ac5408d21c20c17b3794a632970bbb880
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Thu, 23 Jul 2020 17:12:05 +0000 (23 19:12 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 24 Jul 2020 13:03:09 +0000 (24 15:03 +0200)
treeb0fd8e7b8267ef07da6f0c88e007d2523de34519
parent838886378eac879771708100a08a1099173d6935
qapi/error: Check format string argument in error_*prepend()

error_propagate_prepend() "behaves like error_prepend()", and
error_prepend() uses "formatting @fmt, ... like printf()".
error_prepend() checks its format string argument, but
error_propagate_prepend() does not. Fix by addint the format
attribute to error_propagate_prepend() and error_vprepend().

This would have caught the bug fixed in the previous commit.

Missed in commit 4b5766488f "error: Fix use of error_prepend() with
&error_fatal, &error_abort".

Inspired-by: Stefan Weil <sw@weilnetz.de>
Suggested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200723171205.14949-1-philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/qapi/error.h