| commit | 0601740a5db12ea7ae0f2f7826f0cfb05854500a | |
| author | Stefan Weil <weil@mail.berlios.de> | |
| Thu, 30 Dec 2010 12:04:57 +0000 (30 12:04 +0000) | ||
| committer | Blue Swirl <blauwirbel@gmail.com> | |
| Fri, 14 Jan 2011 22:00:07 +0000 (14 22:00 +0000) | ||
| tree | 37217ac9e859fe7698025fd7d69dcb1d40218367 | treesnapshot (tar.gz zip) |
| parent | 42f5a7e9367c1f2cadea3b5af8cccc2781c442df | commitdiff |
make_device_config: Fix non-fatal error message with dash and other shells
ORS=" " adds a blank to the name of the include file.
Some shells (e.g. dash) don't accept input redirection
(tr -d '\r' < $f) when $f ends with a blank, so they
print an error message instead of reading pci.mak.
This is a non-fatal error because pci.mak does not
contain an include line. It was introduced by commit
5d6b423c5cd6f9dfac30959ff1d5c088996719c3.
Using printf avoids adding a blank and is also supported
by older awk versions (this solution was suggested by
Paolo Bonzini, thank you).
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Tested-by: Andreas Färber <andreas.faerber@web.de>
ORS=" " adds a blank to the name of the include file.
Some shells (e.g. dash) don't accept input redirection
(tr -d '\r' < $f) when $f ends with a blank, so they
print an error message instead of reading pci.mak.
This is a non-fatal error because pci.mak does not
contain an include line. It was introduced by commit
5d6b423c5cd6f9dfac30959ff1d5c088996719c3.
Using printf avoids adding a blank and is also supported
by older awk versions (this solution was suggested by
Paolo Bonzini, thank you).
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Tested-by: Andreas Färber <andreas.faerber@web.de>
| make_device_config.sh | diffblobblamehistory |