| commit | 439229c7cb97f6c4cddd3965c3e9d2b8319fe83c | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 4 Nov 2011 09:38:29 +0000 (4 10:38 +0100) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Mon, 7 Nov 2011 16:57:37 +0000 (7 10:57 -0600) | ||
| tree | 01b3a46b522eace87fd52b2b20c24d6e1a2ce627 | treesnapshot (tar.gz zip) |
| parent | f54c556c08c57a317ad54f5d2d9ad549b931cda2 | commitdiff |
console: Fix rendering of VGA underline
vga_putcharxy()'s underline code sets font_data to 0xffff instead of
0xff. vga_putcharxy() then reads dmask16[0xffff >> 4] and
dmask4[0xffff >> 6]. In practice, these out-of-bounds subscripts
"only" put a few crap bits into the display surface.
For 32 bit pixels, there's no array access. font_data's extra bits go
straight into the display surface.
Broken when commit 6d6f7c28 implemented underline.
Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
vga_putcharxy()'s underline code sets font_data to 0xffff instead of
0xff. vga_putcharxy() then reads dmask16[0xffff >> 4] and
dmask4[0xffff >> 6]. In practice, these out-of-bounds subscripts
"only" put a few crap bits into the display surface.
For 32 bit pixels, there's no array access. font_data's extra bits go
straight into the display surface.
Broken when commit 6d6f7c28 implemented underline.
Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| console.c | diffblobblamehistory |