From c5511056708fb1be3c2e1b2ad61af6643f92051c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bj=C3=B6rn=20Baumbach?= Date: Fri, 7 Feb 2025 12:03:18 +0100 Subject: [PATCH] libnet4: check return value of DC lookup MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Avoids possible segmentation fault when the lookup fails. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15798 Pair-programmed-with: Volker Lendecke Signed-off-by: Volker Lendecke Signed-off-by: Björn Baumbach Reviewed-by: Douglas Bagnall Autobuild-User(master): Douglas Bagnall Autobuild-Date(master): Sat Feb 8 03:30:27 UTC 2025 on atb-devel-224 --- source4/libnet/libnet_lookup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source4/libnet/libnet_lookup.c b/source4/libnet/libnet_lookup.c index f8477c7258c..26cf26fe3e1 100644 --- a/source4/libnet/libnet_lookup.c +++ b/source4/libnet/libnet_lookup.c @@ -223,6 +223,9 @@ NTSTATUS libnet_LookupDCs_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx, NTSTATUS status; struct finddcs finddcs_io; status = finddcs_cldap_recv(req, mem_ctx, &finddcs_io); + if (!NT_STATUS_IS_OK(status)) { + return status; + } talloc_free(req); io->out.num_dcs = 1; io->out.dcs = talloc(mem_ctx, struct nbt_dc_name); -- 2.11.4.GIT