From fb1b3e91cfa7f391a5a75be4015ab75b2f58b76f Mon Sep 17 00:00:00 2001 From: Ben Date: Fri, 2 Apr 2010 15:47:21 +0000 Subject: [PATCH] Yahoo username with trailing whitespace -> zombified connection. --- perl/lib/Thrasher/Protocol/Purple/Yahoo.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/perl/lib/Thrasher/Protocol/Purple/Yahoo.pm b/perl/lib/Thrasher/Protocol/Purple/Yahoo.pm index 114012b..30b4084 100644 --- a/perl/lib/Thrasher/Protocol/Purple/Yahoo.pm +++ b/perl/lib/Thrasher/Protocol/Purple/Yahoo.pm @@ -31,6 +31,14 @@ sub registration { $registration_info->{'username'} =~ s/\@yahoo.com$//; } + # If the username has trailing whitespace, the yahoo prpl starts + # an asynchronous connection and never comes back with either + # _connection or _connection_error! (reproducible in pidgin.) + # + # Note: Registering with a usernames with internal whitespace + # already returns an invalid username error. + $registration_info->{'username'} =~ s/^\s+|\s+$//g; + return $self->SUPER::registration($jid, $registration_info); } -- 2.11.4.GIT