| commit | e62b8bce5a88f8fa38a62ab503df7f0eecfb1d22 | |
| author | David Goulet <dgoulet@torproject.org> | |
| Tue, 7 Nov 2023 18:50:28 +0000 (7 13:50 -0500) | ||
| committer | David Goulet <dgoulet@torproject.org> | |
| Tue, 7 Nov 2023 18:50:28 +0000 (7 13:50 -0500) | ||
| tree | 024232a2b14315374f0d57a631e6324b36af0224 | treesnapshot (tar.gz zip) |
| parent | c7d8501da87c6c6254880b27777cf6a15cd5484d | commitdiff |
hs: Fix assert in hs_metrics_update_by_ident()
The hs_metrics_failed_rdv() macro could pass a NULL value for the identity key
when a building circuit would end up in a failure path *before* the "hs_ident"
was able to be set which leading to this assert.
This was introduced in 0.4.8.1-alpha with the addition of rendezvous circuit
failure metrics for the MetricsPort.
This fixes TROVE-2023-006 for which its severity is considered high.
Signed-off-by: David Goulet <dgoulet@torproject.org>
The hs_metrics_failed_rdv() macro could pass a NULL value for the identity key
when a building circuit would end up in a failure path *before* the "hs_ident"
was able to be set which leading to this assert.
This was introduced in 0.4.8.1-alpha with the addition of rendezvous circuit
failure metrics for the MetricsPort.
This fixes TROVE-2023-006 for which its severity is considered high.
Signed-off-by: David Goulet <dgoulet@torproject.org>
| changes/ticket40883 | [new file with mode: 0644] | blob |
| src/feature/hs/hs_metrics.c | diffblobblamehistory |