| commit | 6016a170f0266cf926b7ff305796ba83cc353536 | |
| author | Rusty Bird <rustybird@net-c.com> | |
| Fri, 14 Sep 2018 13:05:08 +0000 (14 13:05 +0000) | ||
| committer | Georg Koppen <gk@torproject.org> | |
| Tue, 18 Sep 2018 10:48:07 +0000 (18 10:48 +0000) | ||
| tree | b1617fdba686aaa56b55da183c23da179ffa5d24 | treesnapshot (tar.gz zip) |
| parent | 0a7d19da90202e5d40851432400444dd6287ffd9 | commitdiff |
Bug 27760: Fix NoScript IPC for about:blank by whitelisting messages
If about:blank is the homepage (or has been passed as a command line
parameter), NoScript will send a message named "fetchChildPolicy"
_before_ "started". Torbutton would then send its "updateSettings" too
soon, resulting in the dreaded error "Could not establish connection.
Receiving end does not exist" (see bug 26520).
Fix this by whitelisting the relevant messages from NoScript: "started"
and also "pageshow" for a slightly more graceful failure mode in case
Torbutton somehow misses NoScript startup.
If about:blank is the homepage (or has been passed as a command line
parameter), NoScript will send a message named "fetchChildPolicy"
_before_ "started". Torbutton would then send its "updateSettings" too
soon, resulting in the dreaded error "Could not establish connection.
Receiving end does not exist" (see bug 26520).
Fix this by whitelisting the relevant messages from NoScript: "started"
and also "pageshow" for a slightly more graceful failure mode in case
Torbutton somehow misses NoScript startup.
| src/modules/noscript-control.js | diffblobblamehistory |