3 # This program is free software; you can redistribute it and/or modify
4 # it under the terms of the GNU General Public License version 2
5 # as published by the Free Software Foundation.
7 # This program is distributed in the hope that it will be useful,
8 # but WITHOUT ANY WARRANTY; without even the implied warranty of
9 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10 # GNU General Public License for more details.
12 # You should have received a copy of the GNU General Public License
13 # along with this program; if not, write to the Free Software
14 # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
18 # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
19 # Copyright 2008, 2012 Richard Lowe
20 # Copyright 2014 Garrett D'Amore <garrett@damore.org>
21 # Copyright (c) 2014, Joyent, Inc.
22 # Copyright (c) 2015, 2016 by Delphix. All rights reserved.
32 from cStringIO
import StringIO
35 # Adjust the load path based on our location and the version of python into
36 # which it is being loaded. This assumes the normal onbld directory
37 # structure, where we are in bin/ and the modules are in
38 # lib/python(version)?/onbld/Scm/. If that changes so too must this.
40 sys
.path
.insert(1, os
.path
.join(os
.path
.dirname(__file__
), "..", "lib",
41 "python%d.%d" % sys
.version_info
[:2]))
44 # Add the relative path to usr/src/tools to the load path, such that when run
45 # from the source tree we use the modules also within the source tree.
47 sys
.path
.insert(2, os
.path
.join(os
.path
.dirname(__file__
), ".."))
49 from onbld
.Scm
import Ignore
50 from onbld
.Checks
import Comments
, Copyright
, CStyle
, HdrChk
51 from onbld
.Checks
import JStyle
, Keywords
, ManLint
, Mapfile
, SpellCheck
54 class GitError(Exception):
58 """Run a command and return a stream containing its stdout (and write its
59 stderr to its stdout)"""
61 if type(command
) != list:
62 command
= command
.split()
64 command
= ["git"] + command
67 tmpfile
= tempfile
.TemporaryFile(prefix
="git-nits")
68 except EnvironmentError, e
:
69 raise GitError("Could not create temporary file: %s\n" % e
)
72 p
= subprocess
.Popen(command
,
74 stderr
=subprocess
.PIPE
)
76 raise GitError("could not execute %s: %s\n" % (command
, e
))
80 raise GitError(p
.stderr
.read())
87 """Return the root of the current git workspace"""
89 p
= git('rev-parse --git-dir')
92 sys
.stderr
.write("Failed finding git workspace\n")
95 return os
.path
.abspath(os
.path
.join(p
.readlines()[0],
100 """Return the current git branch"""
105 sys
.stderr
.write("Failed finding git branch\n")
110 if elt
.endswith('(no branch)'):
112 return elt
.split()[1]
115 def git_parent_branch(branch
):
116 """Return the parent of the current git branch.
118 If this branch tracks a remote branch, return the remote branch which is
119 tracked. If not, default to origin/master."""
124 p
= git("for-each-ref --format=%(refname:short) %(upstream:short) " +
128 sys
.stderr
.write("Failed finding git parent branch\n")
132 # Git 1.7 will leave a ' ' trailing any non-tracking branch
133 if ' ' in line
and not line
.endswith(' \n'):
134 local
, remote
= line
.split()
137 return 'origin/master'
140 def git_comments(parent
):
141 """Return a list of any checkin comments on this git branch"""
143 p
= git('log --pretty=tformat:%%B:SEP: %s..' % parent
)
146 sys
.stderr
.write("Failed getting git comments\n")
149 return [x
.strip() for x
in p
.readlines() if x
!= ':SEP:\n']
152 def git_file_list(parent
, paths
=None):
153 """Return the set of files which have ever changed on this branch.
155 NB: This includes files which no longer exist, or no longer actually
158 p
= git("log --name-only --pretty=format: %s.. %s" %
159 (parent
, ' '.join(paths
)))
162 sys
.stderr
.write("Failed building file-list from git\n")
167 if fname
and not fname
.isspace() and fname
not in ret
:
168 ret
.add(fname
.strip())
173 def not_check(root
, cmd
):
174 """Return a function which returns True if a file given as an argument
175 should be excluded from the check named by 'cmd'"""
177 ignorefiles
= filter(os
.path
.exists
,
178 [os
.path
.join(root
, ".git", "%s.NOT" % cmd
),
179 os
.path
.join(root
, "exception_lists", cmd
)])
180 return Ignore
.ignore(root
, ignorefiles
)
183 def gen_files(root
, parent
, paths
, exclude
):
184 """Return a function producing file names, relative to the current
185 directory, of any file changed on this branch (limited to 'paths' if
186 requested), and excluding files for which exclude returns a true value """
188 # Taken entirely from Python 2.6's os.path.relpath which we would use if we
190 def relpath(path
, here
):
191 c
= os
.path
.abspath(os
.path
.join(root
, path
)).split(os
.path
.sep
)
192 s
= os
.path
.abspath(here
).split(os
.path
.sep
)
193 l
= len(os
.path
.commonprefix((s
, c
)))
194 return os
.path
.join(*[os
.path
.pardir
] * (len(s
)-l
) + c
[l
:])
196 def ret(select
=None):
198 select
= lambda x
: True
200 for f
in git_file_list(parent
, paths
):
203 res
= git("diff %s HEAD %s" % (parent
, f
))
205 # This ignores all the errors that can be thrown. Usually, this means
206 # that git returned non-zero because the file doesn't exist, but it
207 # could also fail if git can't create a new file or it can't be
208 # executed. Such errors are 1) unlikely, and 2) will be caught by other
209 # invocations of git().
211 empty
= not res
.readline()
212 if (os
.path
.isfile(f
) and not empty
and select(f
) and not exclude(f
)):
217 def comchk(root
, parent
, flist
, output
):
218 output
.write("Comments:\n")
220 return Comments
.comchk(git_comments(parent
), check_db
=True,
224 def mapfilechk(root
, parent
, flist
, output
):
227 # We are interested in examining any file that has the following
228 # in its final path segment:
229 # - Contains the word 'mapfile'
230 # - Begins with 'map.'
232 # We don't want to match unless these things occur in final path segment
233 # because directory names with these strings don't indicate a mapfile.
234 # We also ignore files with suffixes that tell us that the files
236 MapfileRE
= re
.compile(r
'.*((mapfile[^/]*)|(/map\.+[^/]*)|(\.map))$',
238 NotMapSuffixRE
= re
.compile(r
'.*\.[ch]$', re
.IGNORECASE
)
240 output
.write("Mapfile comments:\n")
242 for f
in flist(lambda x
: MapfileRE
.match(x
) and not
243 NotMapSuffixRE
.match(x
)):
245 ret |
= Mapfile
.mapfilechk(fh
, output
=output
)
250 def copyright(root
, parent
, flist
, output
):
252 output
.write("Copyrights:\n")
255 ret |
= Copyright
.copyright(fh
, output
=output
)
260 def hdrchk(root
, parent
, flist
, output
):
262 output
.write("Header format:\n")
263 for f
in flist(lambda x
: x
.endswith('.h')):
265 ret |
= HdrChk
.hdrchk(fh
, lenient
=True, output
=output
)
270 def cstyle(root
, parent
, flist
, output
):
272 output
.write("C style:\n")
273 for f
in flist(lambda x
: x
.endswith('.c') or x
.endswith('.h')):
275 ret |
= CStyle
.cstyle(fh
, output
=output
, picky
=True,
276 check_posix_types
=True,
277 check_continuation
=True)
282 def jstyle(root
, parent
, flist
, output
):
284 output
.write("Java style:\n")
285 for f
in flist(lambda x
: x
.endswith('.java')):
287 ret |
= JStyle
.jstyle(fh
, output
=output
, picky
=True)
292 def manlint(root
, parent
, flist
, output
):
294 output
.write("Man page format/spelling:\n")
295 ManfileRE
= re
.compile(r
'.*\.[0-9][a-z]*$', re
.IGNORECASE
)
296 for f
in flist(lambda x
: ManfileRE
.match(x
)):
298 ret |
= ManLint
.manlint(fh
, output
=output
, picky
=True)
299 ret |
= SpellCheck
.spellcheck(fh
, output
=output
)
303 def keywords(root
, parent
, flist
, output
):
305 output
.write("SCCS Keywords:\n")
308 ret |
= Keywords
.keywords(fh
, output
=output
)
313 def run_checks(root
, parent
, cmds
, paths
='', opts
={}):
314 """Run the checks given in 'cmds', expected to have well-known signatures,
315 and report results for any which fail.
317 Return failure if any of them did.
319 NB: the function name of the commands passed in is used to name the NOT
320 file which excepts files from them."""
327 exclude
= not_check(root
, cmd
.func_name
)
328 result
= cmd(root
, parent
, gen_files(root
, parent
, paths
, exclude
),
338 def nits(root
, parent
, paths
):
346 run_checks(root
, parent
, cmds
, paths
)
349 def pbchk(root
, parent
, paths
):
358 run_checks(root
, parent
, cmds
)
365 opts
, args
= getopt
.getopt(args
, 'b:')
366 except getopt
.GetoptError
, e
:
367 sys
.stderr
.write(str(e
) + '\n')
368 sys
.stderr
.write("Usage: %s [-b branch] [path...]\n" % cmd
)
371 for opt
, arg
in opts
:
375 if not parent_branch
:
376 parent_branch
= git_parent_branch(git_branch())
379 if cmd
== 'git-pbchk':
382 sys
.stderr
.write("only complete workspaces may be pbchk'd\n");
385 func(git_root(), parent_branch
, args
)
387 if __name__
== '__main__':
389 main(os
.path
.basename(sys
.argv
[0]), sys
.argv
[1:])
391 sys
.stderr
.write("failed to run git:\n %s\n" % str(e
))