| commit | ddf692c5cc38239856effa4fc4144ff4c216cd94 | |
| author | Mark Wielaard <mark@klomp.org> | |
| Sun, 21 Feb 2021 21:45:51 +0000 (21 22:45 +0100) | ||
| committer | Mark Wielaard <mark@klomp.org> | |
| Sun, 21 Feb 2021 22:20:09 +0000 (21 23:20 +0100) | ||
| tree | c8f43d48fb9c52a0392667abdf25603b7332c2b7 | treesnapshot (tar.gz zip) |
| parent | 323690a7707684fa85c8f460aff93c9d0dc2c4cd | commitdiff |
Fix typo in DWARF 5 line table readers
This typo meant the directory entry was most often zero, which
happened to be sometimes correct anyway (since zero is the compdir).
So for simple testcases it looked correct. But it would be wrong for
compilation units not in the current compdir. Like files compiled with
a relative of absolute path (and then combined into the same compilation
unit with LTO).
The same typo was in both readdwarf.c (read_dwarf2_lineblock) and
readdwarf3.c (read_filename_table). read_dwarf2_lineblock also had
an extra "dwarf" string in the --debug-dump=line output.
https://bugzilla.redhat.com/show_bug.cgi?id=1927153
This typo meant the directory entry was most often zero, which
happened to be sometimes correct anyway (since zero is the compdir).
So for simple testcases it looked correct. But it would be wrong for
compilation units not in the current compdir. Like files compiled with
a relative of absolute path (and then combined into the same compilation
unit with LTO).
The same typo was in both readdwarf.c (read_dwarf2_lineblock) and
readdwarf3.c (read_filename_table). read_dwarf2_lineblock also had
an extra "dwarf" string in the --debug-dump=line output.
https://bugzilla.redhat.com/show_bug.cgi?id=1927153
| coregrind/m_debuginfo/readdwarf.c | diffblobblamehistory | |
| coregrind/m_debuginfo/readdwarf3.c | diffblobblamehistory |