| commit | 10270d4838bdc493781f5a1cf2e90e9c34c9142f | |
| author | Linus Torvalds <torvalds@woody.linux-foundation.org> | |
| Wed, 13 Feb 2008 17:56:14 +0000 (13 09:56 -0800) | ||
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | |
| Wed, 13 Feb 2008 17:56:14 +0000 (13 09:56 -0800) | ||
| tree | d9bce90a79be42ffd619b65b42e9a699bf0d13a6 | treesnapshot (tar.gz zip) |
| parent | d897d2b597167586fcf1fb197ad5a1c23332c3e8 | commitdiff |
acpi: fix acpi_os_read_pci_configuration() misuse of raw_pci_read()
The raw_pci_read() interface (as the raw_pci_ops->read() before it)
unconditionally fills in a 32-bit integer return value regardless of the
size of the operation requested.
So claiming to take a "void *" is wrong, as is passing in a pointer to
just a byte variable.
Noticed by pageexec when enabling -fstack-protector (which needs other
patches too to actually work, but that's a separate issue).
Acked-by: Len Brown <len.brown@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
The raw_pci_read() interface (as the raw_pci_ops->read() before it)
unconditionally fills in a 32-bit integer return value regardless of the
size of the operation requested.
So claiming to take a "void *" is wrong, as is passing in a pointer to
just a byte variable.
Noticed by pageexec when enabling -fstack-protector (which needs other
patches too to actually work, but that's a separate issue).
Acked-by: Len Brown <len.brown@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| drivers/acpi/osl.c | diffblobblamehistory | |
| include/acpi/acpiosxf.h | diffblobblamehistory |