| commit | 35a84fdc89c493a6b0c1eb61296f9bd514f7b947 | |
| author | Grant Likely <grant.likely@secretlab.ca> | |
| Sun, 2 Dec 2007 05:12:45 +0000 (1 22:12 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 28 Jan 2008 23:05:47 +0000 (28 15:05 -0800) | ||
| tree | 389de964d4732ef742a31843a9663193f7824153 | treesnapshot (tar.gz zip) |
| parent | 43fd6c7ebdd50276a7d26d7dddcb109c291dde50 | commitdiff |
gianfar driver: eliminate compiler warnings and unnecessary macros
This patch eliminates the warning of unused return values when the driver
registers it sysfs files. Now the driver will print an error if it is
unable to register the sysfs files.
It also eliminates the macros used to wrap the DEVICE_ATTR macro and the
device_create_file function call. The macros don't reduce the number of
lines of source code in the file and the name munging makes is so that
cscope and friends don't see the references to the functions. It's better
to just call the kernel API directly.
While we're at it, the DEVICE_ATTR instances have been moved down to
be grouped with the functions they depend on.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This patch eliminates the warning of unused return values when the driver
registers it sysfs files. Now the driver will print an error if it is
unable to register the sysfs files.
It also eliminates the macros used to wrap the DEVICE_ATTR macro and the
device_create_file function call. The macros don't reduce the number of
lines of source code in the file and the name munging makes is so that
cscope and friends don't see the references to the functions. It's better
to just call the kernel API directly.
While we're at it, the DEVICE_ATTR instances have been moved down to
be grouped with the functions they depend on.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/net/gianfar_sysfs.c | diffblobblamehistory |