[video] Fix large bookmark thumbnails
commitce6314cc6e7dccd2b29adcb5ba3b9e328c30467a
authorCrystalP <crystalp@kodi.tv>
Mon, 11 Mar 2024 04:32:21 +0000 (11 00:32 -0400)
committerCrystalP <crystalp@kodi.tv>
Thu, 14 Mar 2024 16:24:54 +0000 (14 12:24 -0400)
treedfbd6f2533f28b7678ad8dbc93ab13849ebabc23
parent4ddc576847c1ce6cc24d0957ab0abf50bcba07c8
[video] Fix large bookmark thumbnails

To honour large advancedsettings.xml imageres values (also fix when screen size < 720).

The max thumb size is still limited because the renderer sets the scissors to the size of the
screen used by Kodi (global value from graphic context). A 4k played on 1080p screen can only be
captured in 1080p at the most.
Removing that coupling in the future would be a good idea.

Optimization: a 4k thumbnail for a 480p source is a waste of resources, with upscale processing,
storage at high resolution and later downscale for display.
Instead capture at source resolution when source dimensions < screen dimensions
xbmc/application/ApplicationPlayer.cpp
xbmc/application/ApplicationPlayer.h
xbmc/cores/IPlayer.h
xbmc/cores/VideoPlayer/VideoPlayer.cpp
xbmc/cores/VideoPlayer/VideoPlayer.h
xbmc/video/dialogs/GUIDialogVideoBookmarks.cpp