From ed861c67e10a0a24056dca7a921427391b941a88 Mon Sep 17 00:00:00 2001 From: Marco Peereboom Date: Wed, 4 Jul 2012 10:36:00 -0500 Subject: [PATCH] bring back notification of download start This restores the prior GUI behavior. Hide the asynchronous download complete message behind the download_notifications setting which is disruptive and racy. --- xombrero.1 | 4 ++-- xombrero.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/xombrero.1 b/xombrero.1 index d5dbd0e..64dddc2 100644 --- a/xombrero.1 +++ b/xombrero.1 @@ -1122,8 +1122,8 @@ add - add to downloadmanager, but .Ed The default is "start". .It Cm download_notifications -When enabled a message is shown when downloads are started and -finished. Default is 0. +When enabled a message is shown when downloads are finished. +Default is 0. .It Cm enable_autoscroll When enabled clicking MB3 will spawn the autoscroll ball, scrolling can then proceed by dragging the mouse away from the ball. diff --git a/xombrero.c b/xombrero.c index baaecde..3802e0e 100644 --- a/xombrero.c +++ b/xombrero.c @@ -5169,9 +5169,8 @@ download_start(struct tab *t, struct download *d, int flag) /* get from history */ g_object_ref(d->download); - if (download_notifications) - show_oops(t, "Download of '%s' started...", - basename((char *)webkit_download_get_destination_uri(d->download))); + show_oops(t, "Download of '%s' started...", + basename((char *)webkit_download_get_destination_uri(d->download))); } if (flag != XT_DL_START) -- 2.11.4.GIT