| commit | ff07792676f404ffff6ee61b5638c9dc1a33a37a | |
| author | Simon Sawicki <contact@grub4k.xyz> | |
| Mon, 8 Apr 2024 21:18:04 +0000 (8 23:18 +0200) | ||
| committer | Simon Sawicki <contact@grub4k.xyz> | |
| Tue, 9 Apr 2024 16:36:13 +0000 (9 18:36 +0200) | ||
| tree | 6b973d54eeef6c75f80795a3611cf494cc192e4a | treesnapshot (tar.gz zip) |
| parent | 216f6a3cb57824e6a3c859649ce058c199b1b247 | commitdiff |
[core] Prevent RCE when using `--exec` with `%q` (CVE-2024-22423)
The shell escape function now properly escapes `%`, `\\` and `\n`. `utils.Popen` as well as `%q` output template expansion have been patched accordingly.
Prior to this fix using `--exec` together with `%q` when on Windows could cause remote code to execute. See https://github.com/yt-dlp/yt-dlp/security/advisories/GHSA-hjq6-52gw-2g7p for more details.
Authored by: Grub4K
The shell escape function now properly escapes `%`, `\\` and `\n`. `utils.Popen` as well as `%q` output template expansion have been patched accordingly.
Prior to this fix using `--exec` together with `%q` when on Windows could cause remote code to execute. See https://github.com/yt-dlp/yt-dlp/security/advisories/GHSA-hjq6-52gw-2g7p for more details.
Authored by: Grub4K