2 * Copyright © 2011 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
24 * Jesse Barnes <jbarnes@virtuousgeek.org>
26 * New plane/sprite handling.
28 * The older chips had a separate interface for programming plane related
29 * registers; newer ones are much simpler and we can use the new DRM plane
34 #include "drm_fourcc.h"
35 #include "intel_drv.h"
40 ivb_update_plane(struct drm_plane
*plane
, struct drm_framebuffer
*fb
,
41 struct drm_i915_gem_object
*obj
, int crtc_x
, int crtc_y
,
42 unsigned int crtc_w
, unsigned int crtc_h
,
43 uint32_t x
, uint32_t y
,
44 uint32_t src_w
, uint32_t src_h
)
46 struct drm_device
*dev
= plane
->dev
;
47 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
48 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
49 int pipe
= intel_plane
->pipe
;
50 u32 sprctl
, sprscale
= 0;
53 sprctl
= I915_READ(SPRCTL(pipe
));
55 /* Mask out pixel format bits in case we change it */
56 sprctl
&= ~SPRITE_PIXFORMAT_MASK
;
57 sprctl
&= ~SPRITE_RGB_ORDER_RGBX
;
58 sprctl
&= ~SPRITE_YUV_BYTE_ORDER_MASK
;
60 switch (fb
->pixel_format
) {
61 case DRM_FORMAT_XBGR8888
:
62 sprctl
|= SPRITE_FORMAT_RGBX888
;
65 case DRM_FORMAT_XRGB8888
:
66 sprctl
|= SPRITE_FORMAT_RGBX888
| SPRITE_RGB_ORDER_RGBX
;
70 sprctl
|= SPRITE_FORMAT_YUV422
| SPRITE_YUV_ORDER_YUYV
;
74 sprctl
|= SPRITE_FORMAT_YUV422
| SPRITE_YUV_ORDER_YVYU
;
78 sprctl
|= SPRITE_FORMAT_YUV422
| SPRITE_YUV_ORDER_UYVY
;
82 sprctl
|= SPRITE_FORMAT_YUV422
| SPRITE_YUV_ORDER_VYUY
;
86 DRM_DEBUG_DRIVER("bad pixel format, assuming RGBX888\n");
87 sprctl
|= DVS_FORMAT_RGBX888
;
92 if (obj
->tiling_mode
!= I915_TILING_NONE
)
93 sprctl
|= SPRITE_TILED
;
96 sprctl
|= SPRITE_TRICKLE_FEED_DISABLE
;
97 sprctl
|= SPRITE_ENABLE
;
99 /* Sizes are 0 based */
105 intel_update_sprite_watermarks(dev
, pipe
, crtc_w
, pixel_size
);
108 * IVB workaround: must disable low power watermarks for at least
109 * one frame before enabling scaling. LP watermarks can be re-enabled
110 * when scaling is disabled.
112 if (crtc_w
!= src_w
|| crtc_h
!= src_h
) {
113 dev_priv
->sprite_scaling_enabled
= true;
114 sandybridge_update_wm(dev
);
115 intel_wait_for_vblank(dev
, pipe
);
116 sprscale
= SPRITE_SCALE_ENABLE
| (src_w
<< 16) | src_h
;
118 dev_priv
->sprite_scaling_enabled
= false;
119 /* potentially re-enable LP watermarks */
120 sandybridge_update_wm(dev
);
123 I915_WRITE(SPRSTRIDE(pipe
), fb
->pitches
[0]);
124 I915_WRITE(SPRPOS(pipe
), (crtc_y
<< 16) | crtc_x
);
125 if (obj
->tiling_mode
!= I915_TILING_NONE
) {
126 I915_WRITE(SPRTILEOFF(pipe
), (y
<< 16) | x
);
128 unsigned long offset
;
130 offset
= y
* fb
->pitches
[0] + x
* (fb
->bits_per_pixel
/ 8);
131 I915_WRITE(SPRLINOFF(pipe
), offset
);
133 I915_WRITE(SPRSIZE(pipe
), (crtc_h
<< 16) | crtc_w
);
134 I915_WRITE(SPRSCALE(pipe
), sprscale
);
135 I915_WRITE(SPRCTL(pipe
), sprctl
);
136 I915_WRITE(SPRSURF(pipe
), obj
->gtt_offset
);
137 POSTING_READ(SPRSURF(pipe
));
141 ivb_disable_plane(struct drm_plane
*plane
)
143 struct drm_device
*dev
= plane
->dev
;
144 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
145 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
146 int pipe
= intel_plane
->pipe
;
148 I915_WRITE(SPRCTL(pipe
), I915_READ(SPRCTL(pipe
)) & ~SPRITE_ENABLE
);
149 /* Can't leave the scaler enabled... */
150 I915_WRITE(SPRSCALE(pipe
), 0);
151 /* Activate double buffered register update */
152 I915_WRITE(SPRSURF(pipe
), 0);
153 POSTING_READ(SPRSURF(pipe
));
157 ivb_update_colorkey(struct drm_plane
*plane
,
158 struct drm_intel_sprite_colorkey
*key
)
160 struct drm_device
*dev
= plane
->dev
;
161 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
162 struct intel_plane
*intel_plane
;
166 intel_plane
= to_intel_plane(plane
);
168 I915_WRITE(SPRKEYVAL(intel_plane
->pipe
), key
->min_value
);
169 I915_WRITE(SPRKEYMAX(intel_plane
->pipe
), key
->max_value
);
170 I915_WRITE(SPRKEYMSK(intel_plane
->pipe
), key
->channel_mask
);
172 sprctl
= I915_READ(SPRCTL(intel_plane
->pipe
));
173 sprctl
&= ~(SPRITE_SOURCE_KEY
| SPRITE_DEST_KEY
);
174 if (key
->flags
& I915_SET_COLORKEY_DESTINATION
)
175 sprctl
|= SPRITE_DEST_KEY
;
176 else if (key
->flags
& I915_SET_COLORKEY_SOURCE
)
177 sprctl
|= SPRITE_SOURCE_KEY
;
178 I915_WRITE(SPRCTL(intel_plane
->pipe
), sprctl
);
180 POSTING_READ(SPRKEYMSK(intel_plane
->pipe
));
186 ivb_get_colorkey(struct drm_plane
*plane
, struct drm_intel_sprite_colorkey
*key
)
188 struct drm_device
*dev
= plane
->dev
;
189 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
190 struct intel_plane
*intel_plane
;
193 intel_plane
= to_intel_plane(plane
);
195 key
->min_value
= I915_READ(SPRKEYVAL(intel_plane
->pipe
));
196 key
->max_value
= I915_READ(SPRKEYMAX(intel_plane
->pipe
));
197 key
->channel_mask
= I915_READ(SPRKEYMSK(intel_plane
->pipe
));
200 sprctl
= I915_READ(SPRCTL(intel_plane
->pipe
));
202 if (sprctl
& SPRITE_DEST_KEY
)
203 key
->flags
= I915_SET_COLORKEY_DESTINATION
;
204 else if (sprctl
& SPRITE_SOURCE_KEY
)
205 key
->flags
= I915_SET_COLORKEY_SOURCE
;
207 key
->flags
= I915_SET_COLORKEY_NONE
;
211 snb_update_plane(struct drm_plane
*plane
, struct drm_framebuffer
*fb
,
212 struct drm_i915_gem_object
*obj
, int crtc_x
, int crtc_y
,
213 unsigned int crtc_w
, unsigned int crtc_h
,
214 uint32_t x
, uint32_t y
,
215 uint32_t src_w
, uint32_t src_h
)
217 struct drm_device
*dev
= plane
->dev
;
218 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
219 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
220 int pipe
= intel_plane
->pipe
, pixel_size
;
221 u32 dvscntr
, dvsscale
= 0;
223 dvscntr
= I915_READ(DVSCNTR(pipe
));
225 /* Mask out pixel format bits in case we change it */
226 dvscntr
&= ~DVS_PIXFORMAT_MASK
;
227 dvscntr
&= ~DVS_RGB_ORDER_XBGR
;
228 dvscntr
&= ~DVS_YUV_BYTE_ORDER_MASK
;
230 switch (fb
->pixel_format
) {
231 case DRM_FORMAT_XBGR8888
:
232 dvscntr
|= DVS_FORMAT_RGBX888
| DVS_RGB_ORDER_XBGR
;
235 case DRM_FORMAT_XRGB8888
:
236 dvscntr
|= DVS_FORMAT_RGBX888
;
239 case DRM_FORMAT_YUYV
:
240 dvscntr
|= DVS_FORMAT_YUV422
| DVS_YUV_ORDER_YUYV
;
243 case DRM_FORMAT_YVYU
:
244 dvscntr
|= DVS_FORMAT_YUV422
| DVS_YUV_ORDER_YVYU
;
247 case DRM_FORMAT_UYVY
:
248 dvscntr
|= DVS_FORMAT_YUV422
| DVS_YUV_ORDER_UYVY
;
251 case DRM_FORMAT_VYUY
:
252 dvscntr
|= DVS_FORMAT_YUV422
| DVS_YUV_ORDER_VYUY
;
256 DRM_DEBUG_DRIVER("bad pixel format, assuming RGBX888\n");
257 dvscntr
|= DVS_FORMAT_RGBX888
;
262 if (obj
->tiling_mode
!= I915_TILING_NONE
)
263 dvscntr
|= DVS_TILED
;
266 dvscntr
|= DVS_TRICKLE_FEED_DISABLE
;
267 dvscntr
|= DVS_ENABLE
;
269 /* Sizes are 0 based */
275 intel_update_sprite_watermarks(dev
, pipe
, crtc_w
, pixel_size
);
277 if (crtc_w
!= src_w
|| crtc_h
!= src_h
)
278 dvsscale
= DVS_SCALE_ENABLE
| (src_w
<< 16) | src_h
;
280 I915_WRITE(DVSSTRIDE(pipe
), fb
->pitches
[0]);
281 I915_WRITE(DVSPOS(pipe
), (crtc_y
<< 16) | crtc_x
);
282 if (obj
->tiling_mode
!= I915_TILING_NONE
) {
283 I915_WRITE(DVSTILEOFF(pipe
), (y
<< 16) | x
);
285 unsigned long offset
;
287 offset
= y
* fb
->pitches
[0] + x
* (fb
->bits_per_pixel
/ 8);
288 I915_WRITE(DVSLINOFF(pipe
), offset
);
290 I915_WRITE(DVSSIZE(pipe
), (crtc_h
<< 16) | crtc_w
);
291 I915_WRITE(DVSSCALE(pipe
), dvsscale
);
292 I915_WRITE(DVSCNTR(pipe
), dvscntr
);
293 I915_WRITE(DVSSURF(pipe
), obj
->gtt_offset
);
294 POSTING_READ(DVSSURF(pipe
));
298 snb_disable_plane(struct drm_plane
*plane
)
300 struct drm_device
*dev
= plane
->dev
;
301 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
302 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
303 int pipe
= intel_plane
->pipe
;
305 I915_WRITE(DVSCNTR(pipe
), I915_READ(DVSCNTR(pipe
)) & ~DVS_ENABLE
);
306 /* Disable the scaler */
307 I915_WRITE(DVSSCALE(pipe
), 0);
308 /* Flush double buffered register updates */
309 I915_WRITE(DVSSURF(pipe
), 0);
310 POSTING_READ(DVSSURF(pipe
));
314 intel_enable_primary(struct drm_crtc
*crtc
)
316 struct drm_device
*dev
= crtc
->dev
;
317 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
318 struct intel_crtc
*intel_crtc
= to_intel_crtc(crtc
);
319 int reg
= DSPCNTR(intel_crtc
->plane
);
321 I915_WRITE(reg
, I915_READ(reg
) | DISPLAY_PLANE_ENABLE
);
325 intel_disable_primary(struct drm_crtc
*crtc
)
327 struct drm_device
*dev
= crtc
->dev
;
328 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
329 struct intel_crtc
*intel_crtc
= to_intel_crtc(crtc
);
330 int reg
= DSPCNTR(intel_crtc
->plane
);
332 I915_WRITE(reg
, I915_READ(reg
) & ~DISPLAY_PLANE_ENABLE
);
336 snb_update_colorkey(struct drm_plane
*plane
,
337 struct drm_intel_sprite_colorkey
*key
)
339 struct drm_device
*dev
= plane
->dev
;
340 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
341 struct intel_plane
*intel_plane
;
345 intel_plane
= to_intel_plane(plane
);
347 I915_WRITE(DVSKEYVAL(intel_plane
->pipe
), key
->min_value
);
348 I915_WRITE(DVSKEYMAX(intel_plane
->pipe
), key
->max_value
);
349 I915_WRITE(DVSKEYMSK(intel_plane
->pipe
), key
->channel_mask
);
351 dvscntr
= I915_READ(DVSCNTR(intel_plane
->pipe
));
352 dvscntr
&= ~(DVS_SOURCE_KEY
| DVS_DEST_KEY
);
353 if (key
->flags
& I915_SET_COLORKEY_DESTINATION
)
354 dvscntr
|= DVS_DEST_KEY
;
355 else if (key
->flags
& I915_SET_COLORKEY_SOURCE
)
356 dvscntr
|= DVS_SOURCE_KEY
;
357 I915_WRITE(DVSCNTR(intel_plane
->pipe
), dvscntr
);
359 POSTING_READ(DVSKEYMSK(intel_plane
->pipe
));
365 snb_get_colorkey(struct drm_plane
*plane
, struct drm_intel_sprite_colorkey
*key
)
367 struct drm_device
*dev
= plane
->dev
;
368 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
369 struct intel_plane
*intel_plane
;
372 intel_plane
= to_intel_plane(plane
);
374 key
->min_value
= I915_READ(DVSKEYVAL(intel_plane
->pipe
));
375 key
->max_value
= I915_READ(DVSKEYMAX(intel_plane
->pipe
));
376 key
->channel_mask
= I915_READ(DVSKEYMSK(intel_plane
->pipe
));
379 dvscntr
= I915_READ(DVSCNTR(intel_plane
->pipe
));
381 if (dvscntr
& DVS_DEST_KEY
)
382 key
->flags
= I915_SET_COLORKEY_DESTINATION
;
383 else if (dvscntr
& DVS_SOURCE_KEY
)
384 key
->flags
= I915_SET_COLORKEY_SOURCE
;
386 key
->flags
= I915_SET_COLORKEY_NONE
;
390 intel_update_plane(struct drm_plane
*plane
, struct drm_crtc
*crtc
,
391 struct drm_framebuffer
*fb
, int crtc_x
, int crtc_y
,
392 unsigned int crtc_w
, unsigned int crtc_h
,
393 uint32_t src_x
, uint32_t src_y
,
394 uint32_t src_w
, uint32_t src_h
)
396 struct drm_device
*dev
= plane
->dev
;
397 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
398 struct intel_crtc
*intel_crtc
= to_intel_crtc(crtc
);
399 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
400 struct intel_framebuffer
*intel_fb
;
401 struct drm_i915_gem_object
*obj
, *old_obj
;
402 int pipe
= intel_plane
->pipe
;
404 int x
= src_x
>> 16, y
= src_y
>> 16;
405 int primary_w
= crtc
->mode
.hdisplay
, primary_h
= crtc
->mode
.vdisplay
;
406 bool disable_primary
= false;
408 intel_fb
= to_intel_framebuffer(fb
);
411 old_obj
= intel_plane
->obj
;
416 /* Pipe must be running... */
417 if (!(I915_READ(PIPECONF(pipe
)) & PIPECONF_ENABLE
))
420 if (crtc_x
>= primary_w
|| crtc_y
>= primary_h
)
423 /* Don't modify another pipe's plane */
424 if (intel_plane
->pipe
!= intel_crtc
->pipe
)
428 * Clamp the width & height into the visible area. Note we don't
429 * try to scale the source if part of the visible region is offscreen.
430 * The caller must handle that by adjusting source offset and size.
432 if ((crtc_x
< 0) && ((crtc_x
+ crtc_w
) > 0)) {
436 if ((crtc_x
+ crtc_w
) <= 0) /* Nothing to display */
438 if ((crtc_x
+ crtc_w
) > primary_w
)
439 crtc_w
= primary_w
- crtc_x
;
441 if ((crtc_y
< 0) && ((crtc_y
+ crtc_h
) > 0)) {
445 if ((crtc_y
+ crtc_h
) <= 0) /* Nothing to display */
447 if (crtc_y
+ crtc_h
> primary_h
)
448 crtc_h
= primary_h
- crtc_y
;
450 if (!crtc_w
|| !crtc_h
) /* Again, nothing to display */
454 * We can take a larger source and scale it down, but
455 * only so much... 16x is the max on SNB.
457 if (((src_w
* src_h
) / (crtc_w
* crtc_h
)) > intel_plane
->max_downscale
)
461 * If the sprite is completely covering the primary plane,
462 * we can disable the primary and save power.
464 if ((crtc_x
== 0) && (crtc_y
== 0) &&
465 (crtc_w
== primary_w
) && (crtc_h
== primary_h
))
466 disable_primary
= true;
468 mutex_lock(&dev
->struct_mutex
);
470 ret
= intel_pin_and_fence_fb_obj(dev
, obj
, NULL
);
474 intel_plane
->obj
= obj
;
477 * Be sure to re-enable the primary before the sprite is no longer
480 if (!disable_primary
&& intel_plane
->primary_disabled
) {
481 intel_enable_primary(crtc
);
482 intel_plane
->primary_disabled
= false;
485 intel_plane
->update_plane(plane
, fb
, obj
, crtc_x
, crtc_y
,
486 crtc_w
, crtc_h
, x
, y
, src_w
, src_h
);
488 if (disable_primary
) {
489 intel_disable_primary(crtc
);
490 intel_plane
->primary_disabled
= true;
493 /* Unpin old obj after new one is active to avoid ugliness */
496 * It's fairly common to simply update the position of
497 * an existing object. In that case, we don't need to
498 * wait for vblank to avoid ugliness, we only need to
499 * do the pin & ref bookkeeping.
501 if (old_obj
!= obj
) {
502 mutex_unlock(&dev
->struct_mutex
);
503 intel_wait_for_vblank(dev
, to_intel_crtc(crtc
)->pipe
);
504 mutex_lock(&dev
->struct_mutex
);
506 i915_gem_object_unpin(old_obj
);
510 mutex_unlock(&dev
->struct_mutex
);
516 intel_disable_plane(struct drm_plane
*plane
)
518 struct drm_device
*dev
= plane
->dev
;
519 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
522 if (intel_plane
->primary_disabled
) {
523 intel_enable_primary(plane
->crtc
);
524 intel_plane
->primary_disabled
= false;
527 intel_plane
->disable_plane(plane
);
529 if (!intel_plane
->obj
)
532 mutex_lock(&dev
->struct_mutex
);
533 i915_gem_object_unpin(intel_plane
->obj
);
534 intel_plane
->obj
= NULL
;
535 mutex_unlock(&dev
->struct_mutex
);
541 static void intel_destroy_plane(struct drm_plane
*plane
)
543 struct intel_plane
*intel_plane
= to_intel_plane(plane
);
544 intel_disable_plane(plane
);
545 drm_plane_cleanup(plane
);
549 int intel_sprite_set_colorkey(struct drm_device
*dev
, void *data
,
550 struct drm_file
*file_priv
)
552 struct drm_intel_sprite_colorkey
*set
= data
;
553 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
554 struct drm_mode_object
*obj
;
555 struct drm_plane
*plane
;
556 struct intel_plane
*intel_plane
;
562 /* Make sure we don't try to enable both src & dest simultaneously */
563 if ((set
->flags
& (I915_SET_COLORKEY_DESTINATION
| I915_SET_COLORKEY_SOURCE
)) == (I915_SET_COLORKEY_DESTINATION
| I915_SET_COLORKEY_SOURCE
))
566 mutex_lock(&dev
->mode_config
.mutex
);
568 obj
= drm_mode_object_find(dev
, set
->plane_id
, DRM_MODE_OBJECT_PLANE
);
574 plane
= obj_to_plane(obj
);
575 intel_plane
= to_intel_plane(plane
);
576 ret
= intel_plane
->update_colorkey(plane
, set
);
579 mutex_unlock(&dev
->mode_config
.mutex
);
583 int intel_sprite_get_colorkey(struct drm_device
*dev
, void *data
,
584 struct drm_file
*file_priv
)
586 struct drm_intel_sprite_colorkey
*get
= data
;
587 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
588 struct drm_mode_object
*obj
;
589 struct drm_plane
*plane
;
590 struct intel_plane
*intel_plane
;
596 mutex_lock(&dev
->mode_config
.mutex
);
598 obj
= drm_mode_object_find(dev
, get
->plane_id
, DRM_MODE_OBJECT_PLANE
);
604 plane
= obj_to_plane(obj
);
605 intel_plane
= to_intel_plane(plane
);
606 intel_plane
->get_colorkey(plane
, get
);
609 mutex_unlock(&dev
->mode_config
.mutex
);
613 static const struct drm_plane_funcs intel_plane_funcs
= {
614 .update_plane
= intel_update_plane
,
615 .disable_plane
= intel_disable_plane
,
616 .destroy
= intel_destroy_plane
,
619 static uint32_t snb_plane_formats
[] = {
629 intel_plane_init(struct drm_device
*dev
, enum pipe pipe
)
631 struct intel_plane
*intel_plane
;
632 unsigned long possible_crtcs
;
635 if (!(IS_GEN6(dev
) || IS_GEN7(dev
)))
638 intel_plane
= kzalloc(sizeof(struct intel_plane
), GFP_KERNEL
);
643 intel_plane
->max_downscale
= 16;
644 intel_plane
->update_plane
= snb_update_plane
;
645 intel_plane
->disable_plane
= snb_disable_plane
;
646 intel_plane
->update_colorkey
= snb_update_colorkey
;
647 intel_plane
->get_colorkey
= snb_get_colorkey
;
648 } else if (IS_GEN7(dev
)) {
649 intel_plane
->max_downscale
= 2;
650 intel_plane
->update_plane
= ivb_update_plane
;
651 intel_plane
->disable_plane
= ivb_disable_plane
;
652 intel_plane
->update_colorkey
= ivb_update_colorkey
;
653 intel_plane
->get_colorkey
= ivb_get_colorkey
;
656 intel_plane
->pipe
= pipe
;
657 possible_crtcs
= (1 << pipe
);
658 ret
= drm_plane_init(dev
, &intel_plane
->base
, possible_crtcs
,
659 &intel_plane_funcs
, snb_plane_formats
,
660 ARRAY_SIZE(snb_plane_formats
), false);