| commit | d89dba7a275f40757d27ba16c8bc6aa424656bbe | |
| author | Dan Carpenter <error27@gmail.com> | |
| Thu, 10 Mar 2011 15:23:26 +0000 (10 18:23 +0300) | ||
| committer | John W. Linville <linville@tuxdriver.com> | |
| Fri, 11 Mar 2011 19:15:36 +0000 (11 14:15 -0500) | ||
| tree | c42b16fc568b9ffdb0458b59c6112f9eb9f24792 | treesnapshot (tar.gz zip) |
| parent | 23952ec92850bcdc91b8167fa95ec05dd59a80ea | commitdiff |
libertas: fix write past end of array in mesh_id_get()
defs.meshie.val.mesh_id is 32 chars long. It's not supposed to be NUL
terminated. This code puts a terminator on the end to make it easier to
print to sysfs. The problem is that if the mesh_id fills the entire
buffer the original code puts the terminator one spot past the end.
The way the original code was written, there was a check to make sure
that maxlen was less than PAGE_SIZE. Since we know that maxlen is at
most 34 chars, I just removed the check.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
defs.meshie.val.mesh_id is 32 chars long. It's not supposed to be NUL
terminated. This code puts a terminator on the end to make it easier to
print to sysfs. The problem is that if the mesh_id fills the entire
buffer the original code puts the terminator one spot past the end.
The way the original code was written, there was a check to make sure
that maxlen was less than PAGE_SIZE. Since we know that maxlen is at
most 34 chars, I just removed the check.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| drivers/net/wireless/libertas/mesh.c | diffblobblamehistory |