Fix race in libzfs_run_process_impl
commit1cd2419ece5c0639c724141e5ff22d86c542f675
authorshodanshok <g.danti@assyoma.it>
Wed, 4 Dec 2024 10:36:10 +0000 (4 11:36 +0100)
committerGitHub <noreply@github.com>
Wed, 4 Dec 2024 10:36:10 +0000 (4 05:36 -0500)
tree66db26b012e44c9a401a72f0c3d0c3eb1f2b15c3
parent654ade8ca28568f94f99c6d440124fcf82972d7b
Fix race in libzfs_run_process_impl

When replacing a disk, a child process is forked to run a script called
zfs_prepare_disk (which can be useful for disk firmware update or health
check). The parent than calls waitpid and checks the child error/status
code.

However, the _reap_children thread (created from zed_exec_process to
manage zedlets) also waits for all children with the same PGID and can
stole the signal, causing the replace operation to be aborted.

As waitpid returns -1, the parent incorrectly assume that the child
process had an error or was killed. This, in turn, leaves the newly
added disk in REMOVED or UNAVAIL status rather than completing the
replace process.

This patch changes the PGID of the child process execuing the
prepare script, shielding it from the _reap_children thread.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Gionatan Danti <g.danti@assyoma.it>
Closes #16801
lib/libzfs/libzfs_util.c