| commit | 5cc49509013db4aa23f8e21eafdbde8403d5dffa | |
| author | Richard Yao <richard.yao@alumni.stonybrook.edu> | |
| Tue, 7 Feb 2023 09:51:56 +0000 (7 04:51 -0500) | ||
| committer | Brian Behlendorf <behlendorf1@llnl.gov> | |
| Wed, 1 Mar 2023 01:31:50 +0000 (28 17:31 -0800) | ||
| tree | 28634a7f99adb87bbc96058d2182f26e0b2e369b | treesnapshot (tar.gz zip) |
| parent | 9a14ce43c3d6a9939804215bbbe66de5115ace42 | commitdiff |
Suppress static analyzer warning in dbuf_hold_copy()
Clang's static analyzer claims that dbuf_hold_copy() will have a NULL
pointer dereference in data->b_data when called by dbuf_hold_impl().
This is impossible because data is dr->dt.dl.dr_data, which is non-NULL
whenever db->db_level == 0, which is always the case whenever
dbuf_hold_impl() calls dbuf_hold_copy(). We add an assertion to suppress
the complaint.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14470
Clang's static analyzer claims that dbuf_hold_copy() will have a NULL
pointer dereference in data->b_data when called by dbuf_hold_impl().
This is impossible because data is dr->dt.dl.dr_data, which is non-NULL
whenever db->db_level == 0, which is always the case whenever
dbuf_hold_impl() calls dbuf_hold_copy(). We add an assertion to suppress
the complaint.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14470
| module/zfs/dbuf.c | diffblobblamehistory |