linux/copy_file_range: properly request a fallback copy on Linux <5.3
commitc47f0f441759483bec05545572a8e6841393f879
authorRob N <rob.norris@klarasystems.com>
Tue, 1 Aug 2023 18:31:11 +0000 (2 04:31 +1000)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 2 Aug 2023 15:52:40 +0000 (2 08:52 -0700)
treeac09c9a0a030511c596238086cd9660f4ad7d743
parent12f2b1f65e91428465319dd3ebaa8c4466476f8e
linux/copy_file_range: properly request a fallback copy on Linux <5.3

Before Linux 5.3, the filesystem's copy_file_range handler had to signal
back to the kernel that we can't fulfill the request and it should
fallback to a content copy. This is done by returning -EOPNOTSUPP.

This commit converts the EXDEV return from zfs_clone_range to
EOPNOTSUPP, to force the kernel to fallback for all the valid reasons it
might be unable to clone. Without it the copy_file_range() syscall will
return EXDEV to userspace, breaking its semantics.

Add test for copy_file_range fallbacks.  copy_file_range should always
fallback to a content copy whenever ZFS can't service the request with
cloning.

Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Kay Pedersen <mail@mkwg.de>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #15131
module/os/linux/zfs/zpl_file_range.c
tests/runfiles/linux.run
tests/test-runner/bin/zts-report.py.in
tests/zfs-tests/tests/Makefile.am
tests/zfs-tests/tests/functional/block_cloning/block_cloning_copyfilerange_fallback.ksh [new file with mode: 0755]