BRT: Change brt_pending_tree sorting order
commitf7c1db6366947d879d0103a0970d22d9663ef20e
authorAlexander Motin <mav@FreeBSD.org>
Thu, 21 Mar 2024 22:42:21 +0000 (21 18:42 -0400)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Fri, 19 Apr 2024 17:13:38 +0000 (19 10:13 -0700)
treee086b36bffae25cccf3abceb4d56d91562032a26
parentfa5de0c5cd4061b3b70d5e9eb2d67a4a7c594a63
BRT: Change brt_pending_tree sorting order

It does not look important how exactly brt_pending_tree is sorted.
When cloning large file, it is quite likely that all of its blocks
have identical physical birth times, so comparing them first does
not provide useful entropy, while accesses additional cache line.
In most cases combination of vdev and offset provides unique result
and physical birth time comparison is not even needed.  Meanwhile,
when traversing the tree inside brt_pending_apply(), it can be
beneficial for dbuf cache and CPU cache hits to group processing
by vdev and so by the per-VDEV BRT ZAPs.

Reviewed-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15954
module/zfs/brt.c