compilerplugins/clang/test/unnecessarylocking.cxx

   1 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
   2 /*
   3  * This file is part of the LibreOffice project.
   4  *
   5  * This Source Code Form is subject to the terms of the Mozilla Public
   6  * License, v. 2.0. If a copy of the MPL was not distributed with this
   7  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
   8  */
   9
  10 #include <mutex>
  11 #include <osl/mutex.hxx>
  12
  13 static std::mutex gSolarMutex;
  14
  15 class SolarMutexGuard
  16 {
  17     std::unique_lock<std::mutex> lock;
  18
  19 public:
  20     SolarMutexGuard()
  21         : lock(gSolarMutex)
  22     {
  23     }
  24 };
  25
  26 namespace test1
  27 {
  28 struct Foo
  29 {
  30     int m_foo;
  31     int bar1()
  32     // expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
  33     {
  34         SolarMutexGuard guard;
  35         return 1;
  36     }
  37     // no warning expected
  38     int bar2()
  39     {
  40         SolarMutexGuard guard;
  41         return m_foo;
  42     }
  43 };
  44 }
  45
  46 namespace test2
  47 {
  48 int free_function() { return 1; }
  49
  50 struct Foo
  51 {
  52     std::mutex m_aMutex;
  53     osl::Mutex m_aOslMutex;
  54     int m_foo;
  55
  56     int bar1()
  57     // expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
  58     {
  59         std::unique_lock guard(m_aMutex);
  60         return 1;
  61     }
  62     int bar2()
  63     // expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
  64     {
  65         std::scoped_lock guard(m_aMutex);
  66         return 1;
  67     }
  68     // no warning expected
  69     int bar3()
  70     {
  71         std::scoped_lock guard(m_aMutex);
  72         return m_foo;
  73     }
  74     int bar4()
  75     // expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
  76     {
  77         ::osl::Guard<::osl::Mutex> aGuard(m_aOslMutex);
  78         return 1;
  79     }
  80     int bar5()
  81     {
  82         // expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
  83         {
  84             std::unique_lock guard(m_aMutex);
  85             return free_function();
  86         }
  87     }
  88     osl::Mutex& getOslMutex() { return m_aOslMutex; }
  89     int bar6()
  90     // expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
  91     {
  92         ::osl::Guard<::osl::Mutex> aGuard(getOslMutex());
  93         return 1;
  94     }
  95 };
  96 }
  97
  98 // Calling anything on VCLUnoHelper means we need the SolarMutex
  99 class VCLUnoHelper
 100 {
 101 public:
 102     static int CreateToolkit();
 103 };
 104 namespace test4
 105 {
 106 // no warning expected
 107 void bar1()
 108 {
 109     SolarMutexGuard guard;
 110     VCLUnoHelper::CreateToolkit();
 111 }
 112 }
 113
 114 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */