Fix oversight in previous error-reporting patch; mustn't pfree path string
[PostgreSQL.git] / src / backend / rewrite / rewriteDefine.c
blob10cd5abccfa484cf8fb8b02ad13875e9cbba887d
1 /*-------------------------------------------------------------------------
3 * rewriteDefine.c
4 * routines for defining a rewrite rule
6 * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
7 * Portions Copyright (c) 1994, Regents of the University of California
10 * IDENTIFICATION
11 * $PostgreSQL$
13 *-------------------------------------------------------------------------
15 #include "postgres.h"
17 #include "access/heapam.h"
18 #include "catalog/dependency.h"
19 #include "catalog/indexing.h"
20 #include "catalog/namespace.h"
21 #include "catalog/pg_rewrite.h"
22 #include "miscadmin.h"
23 #include "nodes/nodeFuncs.h"
24 #include "parser/parse_utilcmd.h"
25 #include "rewrite/rewriteDefine.h"
26 #include "rewrite/rewriteManip.h"
27 #include "rewrite/rewriteSupport.h"
28 #include "storage/smgr.h"
29 #include "utils/acl.h"
30 #include "utils/builtins.h"
31 #include "utils/inval.h"
32 #include "utils/lsyscache.h"
33 #include "utils/rel.h"
34 #include "utils/syscache.h"
35 #include "utils/tqual.h"
38 static void checkRuleResultList(List *targetList, TupleDesc resultDesc,
39 bool isSelect);
40 static bool setRuleCheckAsUser_walker(Node *node, Oid *context);
41 static void setRuleCheckAsUser_Query(Query *qry, Oid userid);
45 * InsertRule -
46 * takes the arguments and inserts them as a row into the system
47 * relation "pg_rewrite"
49 static Oid
50 InsertRule(char *rulname,
51 int evtype,
52 Oid eventrel_oid,
53 AttrNumber evslot_index,
54 bool evinstead,
55 Node *event_qual,
56 List *action,
57 bool replace)
59 char *evqual = nodeToString(event_qual);
60 char *actiontree = nodeToString((Node *) action);
61 int i;
62 Datum values[Natts_pg_rewrite];
63 bool nulls[Natts_pg_rewrite];
64 bool replaces[Natts_pg_rewrite];
65 NameData rname;
66 Relation pg_rewrite_desc;
67 HeapTuple tup,
68 oldtup;
69 Oid rewriteObjectId;
70 ObjectAddress myself,
71 referenced;
72 bool is_update = false;
75 * Set up *nulls and *values arrays
77 MemSet(nulls, false, sizeof(nulls));
79 i = 0;
80 namestrcpy(&rname, rulname);
81 values[i++] = NameGetDatum(&rname); /* rulename */
82 values[i++] = ObjectIdGetDatum(eventrel_oid); /* ev_class */
83 values[i++] = Int16GetDatum(evslot_index); /* ev_attr */
84 values[i++] = CharGetDatum(evtype + '0'); /* ev_type */
85 values[i++] = CharGetDatum(RULE_FIRES_ON_ORIGIN); /* ev_enabled */
86 values[i++] = BoolGetDatum(evinstead); /* is_instead */
87 values[i++] = CStringGetTextDatum(evqual); /* ev_qual */
88 values[i++] = CStringGetTextDatum(actiontree); /* ev_action */
91 * Ready to store new pg_rewrite tuple
93 pg_rewrite_desc = heap_open(RewriteRelationId, RowExclusiveLock);
96 * Check to see if we are replacing an existing tuple
98 oldtup = SearchSysCache(RULERELNAME,
99 ObjectIdGetDatum(eventrel_oid),
100 PointerGetDatum(rulname),
101 0, 0);
103 if (HeapTupleIsValid(oldtup))
105 if (!replace)
106 ereport(ERROR,
107 (errcode(ERRCODE_DUPLICATE_OBJECT),
108 errmsg("rule \"%s\" for relation \"%s\" already exists",
109 rulname, get_rel_name(eventrel_oid))));
112 * When replacing, we don't need to replace every attribute
114 MemSet(replaces, false, sizeof(replaces));
115 replaces[Anum_pg_rewrite_ev_attr - 1] = true;
116 replaces[Anum_pg_rewrite_ev_type - 1] = true;
117 replaces[Anum_pg_rewrite_is_instead - 1] = true;
118 replaces[Anum_pg_rewrite_ev_qual - 1] = true;
119 replaces[Anum_pg_rewrite_ev_action - 1] = true;
121 tup = heap_modify_tuple(oldtup, RelationGetDescr(pg_rewrite_desc),
122 values, nulls, replaces);
124 simple_heap_update(pg_rewrite_desc, &tup->t_self, tup);
126 ReleaseSysCache(oldtup);
128 rewriteObjectId = HeapTupleGetOid(tup);
129 is_update = true;
131 else
133 tup = heap_form_tuple(pg_rewrite_desc->rd_att, values, nulls);
135 rewriteObjectId = simple_heap_insert(pg_rewrite_desc, tup);
138 /* Need to update indexes in either case */
139 CatalogUpdateIndexes(pg_rewrite_desc, tup);
141 heap_freetuple(tup);
143 /* If replacing, get rid of old dependencies and make new ones */
144 if (is_update)
145 deleteDependencyRecordsFor(RewriteRelationId, rewriteObjectId);
148 * Install dependency on rule's relation to ensure it will go away on
149 * relation deletion. If the rule is ON SELECT, make the dependency
150 * implicit --- this prevents deleting a view's SELECT rule. Other kinds
151 * of rules can be AUTO.
153 myself.classId = RewriteRelationId;
154 myself.objectId = rewriteObjectId;
155 myself.objectSubId = 0;
157 referenced.classId = RelationRelationId;
158 referenced.objectId = eventrel_oid;
159 referenced.objectSubId = 0;
161 recordDependencyOn(&myself, &referenced,
162 (evtype == CMD_SELECT) ? DEPENDENCY_INTERNAL : DEPENDENCY_AUTO);
165 * Also install dependencies on objects referenced in action and qual.
167 recordDependencyOnExpr(&myself, (Node *) action, NIL,
168 DEPENDENCY_NORMAL);
170 if (event_qual != NULL)
172 /* Find query containing OLD/NEW rtable entries */
173 Query *qry = (Query *) linitial(action);
175 qry = getInsertSelectQuery(qry, NULL);
176 recordDependencyOnExpr(&myself, event_qual, qry->rtable,
177 DEPENDENCY_NORMAL);
180 heap_close(pg_rewrite_desc, RowExclusiveLock);
182 return rewriteObjectId;
186 * DefineRule
187 * Execute a CREATE RULE command.
189 void
190 DefineRule(RuleStmt *stmt, const char *queryString)
192 List *actions;
193 Node *whereClause;
194 Oid relId;
196 /* Parse analysis ... */
197 transformRuleStmt(stmt, queryString, &actions, &whereClause);
199 /* ... find the relation ... */
200 relId = RangeVarGetRelid(stmt->relation, false);
202 /* ... and execute */
203 DefineQueryRewrite(stmt->rulename,
204 relId,
205 whereClause,
206 stmt->event,
207 stmt->instead,
208 stmt->replace,
209 actions);
214 * DefineQueryRewrite
215 * Create a rule
217 * This is essentially the same as DefineRule() except that the rule's
218 * action and qual have already been passed through parse analysis.
220 void
221 DefineQueryRewrite(char *rulename,
222 Oid event_relid,
223 Node *event_qual,
224 CmdType event_type,
225 bool is_instead,
226 bool replace,
227 List *action)
229 Relation event_relation;
230 Oid ruleId;
231 int event_attno;
232 ListCell *l;
233 Query *query;
234 bool RelisBecomingView = false;
237 * If we are installing an ON SELECT rule, we had better grab
238 * AccessExclusiveLock to ensure no SELECTs are currently running on the
239 * event relation. For other types of rules, it might be sufficient to
240 * grab ShareLock to lock out insert/update/delete actions. But for now,
241 * let's just grab AccessExclusiveLock all the time.
243 event_relation = heap_open(event_relid, AccessExclusiveLock);
246 * Check user has permission to apply rules to this relation.
248 if (!pg_class_ownercheck(event_relid, GetUserId()))
249 aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,
250 RelationGetRelationName(event_relation));
253 * No rule actions that modify OLD or NEW
255 foreach(l, action)
257 query = (Query *) lfirst(l);
258 if (query->resultRelation == 0)
259 continue;
260 /* Don't be fooled by INSERT/SELECT */
261 if (query != getInsertSelectQuery(query, NULL))
262 continue;
263 if (query->resultRelation == PRS2_OLD_VARNO)
264 ereport(ERROR,
265 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
266 errmsg("rule actions on OLD are not implemented"),
267 errhint("Use views or triggers instead.")));
268 if (query->resultRelation == PRS2_NEW_VARNO)
269 ereport(ERROR,
270 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
271 errmsg("rule actions on NEW are not implemented"),
272 errhint("Use triggers instead.")));
275 if (event_type == CMD_SELECT)
278 * Rules ON SELECT are restricted to view definitions
280 * So there cannot be INSTEAD NOTHING, ...
282 if (list_length(action) == 0)
283 ereport(ERROR,
284 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
285 errmsg("INSTEAD NOTHING rules on SELECT are not implemented"),
286 errhint("Use views instead.")));
289 * ... there cannot be multiple actions, ...
291 if (list_length(action) > 1)
292 ereport(ERROR,
293 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
294 errmsg("multiple actions for rules on SELECT are not implemented")));
297 * ... the one action must be a SELECT, ...
299 query = (Query *) linitial(action);
300 if (!is_instead ||
301 query->commandType != CMD_SELECT ||
302 query->utilityStmt != NULL ||
303 query->intoClause != NULL)
304 ereport(ERROR,
305 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
306 errmsg("rules on SELECT must have action INSTEAD SELECT")));
309 * ... there can be no rule qual, ...
311 if (event_qual != NULL)
312 ereport(ERROR,
313 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
314 errmsg("event qualifications are not implemented for rules on SELECT")));
317 * ... the targetlist of the SELECT action must exactly match the
318 * event relation, ...
320 checkRuleResultList(query->targetList,
321 RelationGetDescr(event_relation),
322 true);
325 * ... there must not be another ON SELECT rule already ...
327 if (!replace && event_relation->rd_rules != NULL)
329 int i;
331 for (i = 0; i < event_relation->rd_rules->numLocks; i++)
333 RewriteRule *rule;
335 rule = event_relation->rd_rules->rules[i];
336 if (rule->event == CMD_SELECT)
337 ereport(ERROR,
338 (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
339 errmsg("\"%s\" is already a view",
340 RelationGetRelationName(event_relation))));
345 * ... and finally the rule must be named _RETURN.
347 if (strcmp(rulename, ViewSelectRuleName) != 0)
350 * In versions before 7.3, the expected name was _RETviewname. For
351 * backwards compatibility with old pg_dump output, accept that
352 * and silently change it to _RETURN. Since this is just a quick
353 * backwards-compatibility hack, limit the number of characters
354 * checked to a few less than NAMEDATALEN; this saves having to
355 * worry about where a multibyte character might have gotten
356 * truncated.
358 if (strncmp(rulename, "_RET", 4) != 0 ||
359 strncmp(rulename + 4, RelationGetRelationName(event_relation),
360 NAMEDATALEN - 4 - 4) != 0)
361 ereport(ERROR,
362 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
363 errmsg("view rule for \"%s\" must be named \"%s\"",
364 RelationGetRelationName(event_relation),
365 ViewSelectRuleName)));
366 rulename = pstrdup(ViewSelectRuleName);
370 * Are we converting a relation to a view?
372 * If so, check that the relation is empty because the storage for the
373 * relation is going to be deleted. Also insist that the rel not have
374 * any triggers, indexes, or child tables. (Note: these tests are
375 * too strict, because they will reject relations that once had such
376 * but don't anymore. But we don't really care, because this whole
377 * business of converting relations to views is just a kluge to allow
378 * loading ancient pg_dump files.)
380 if (event_relation->rd_rel->relkind != RELKIND_VIEW)
382 HeapScanDesc scanDesc;
384 scanDesc = heap_beginscan(event_relation, SnapshotNow, 0, NULL);
385 if (heap_getnext(scanDesc, ForwardScanDirection) != NULL)
386 ereport(ERROR,
387 (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
388 errmsg("could not convert table \"%s\" to a view because it is not empty",
389 RelationGetRelationName(event_relation))));
390 heap_endscan(scanDesc);
392 if (event_relation->rd_rel->relhastriggers)
393 ereport(ERROR,
394 (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
395 errmsg("could not convert table \"%s\" to a view because it has triggers",
396 RelationGetRelationName(event_relation)),
397 errhint("In particular, the table cannot be involved in any foreign key relationships.")));
399 if (event_relation->rd_rel->relhasindex)
400 ereport(ERROR,
401 (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
402 errmsg("could not convert table \"%s\" to a view because it has indexes",
403 RelationGetRelationName(event_relation))));
405 if (event_relation->rd_rel->relhassubclass)
406 ereport(ERROR,
407 (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
408 errmsg("could not convert table \"%s\" to a view because it has child tables",
409 RelationGetRelationName(event_relation))));
411 RelisBecomingView = true;
414 else
417 * For non-SELECT rules, a RETURNING list can appear in at most one of
418 * the actions ... and there can't be any RETURNING list at all in a
419 * conditional or non-INSTEAD rule. (Actually, there can be at most
420 * one RETURNING list across all rules on the same event, but it seems
421 * best to enforce that at rule expansion time.) If there is a
422 * RETURNING list, it must match the event relation.
424 bool haveReturning = false;
426 foreach(l, action)
428 query = (Query *) lfirst(l);
430 if (!query->returningList)
431 continue;
432 if (haveReturning)
433 ereport(ERROR,
434 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
435 errmsg("cannot have multiple RETURNING lists in a rule")));
436 haveReturning = true;
437 if (event_qual != NULL)
438 ereport(ERROR,
439 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
440 errmsg("RETURNING lists are not supported in conditional rules")));
441 if (!is_instead)
442 ereport(ERROR,
443 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
444 errmsg("RETURNING lists are not supported in non-INSTEAD rules")));
445 checkRuleResultList(query->returningList,
446 RelationGetDescr(event_relation),
447 false);
452 * This rule is allowed - prepare to install it.
454 event_attno = -1;
456 /* discard rule if it's null action and not INSTEAD; it's a no-op */
457 if (action != NIL || is_instead)
459 ruleId = InsertRule(rulename,
460 event_type,
461 event_relid,
462 event_attno,
463 is_instead,
464 event_qual,
465 action,
466 replace);
469 * Set pg_class 'relhasrules' field TRUE for event relation. If
470 * appropriate, also modify the 'relkind' field to show that the
471 * relation is now a view.
473 * Important side effect: an SI notice is broadcast to force all
474 * backends (including me!) to update relcache entries with the new
475 * rule.
477 SetRelationRuleStatus(event_relid, true, RelisBecomingView);
481 * IF the relation is becoming a view, delete the storage files associated
482 * with it. NB: we had better have AccessExclusiveLock to do this ...
484 * XXX what about getting rid of its TOAST table? For now, we don't.
486 if (RelisBecomingView)
488 ForkNumber forknum;
490 RelationOpenSmgr(event_relation);
491 for (forknum = 0; forknum <= MAX_FORKNUM; forknum++)
492 if (smgrexists(event_relation->rd_smgr, forknum))
493 smgrscheduleunlink(event_relation->rd_smgr, forknum,
494 event_relation->rd_istemp);
495 RelationCloseSmgr(event_relation);
498 /* Close rel, but keep lock till commit... */
499 heap_close(event_relation, NoLock);
503 * checkRuleResultList
504 * Verify that targetList produces output compatible with a tupledesc
506 * The targetList might be either a SELECT targetlist, or a RETURNING list;
507 * isSelect tells which. (This is mostly used for choosing error messages,
508 * but also we don't enforce column name matching for RETURNING.)
510 static void
511 checkRuleResultList(List *targetList, TupleDesc resultDesc, bool isSelect)
513 ListCell *tllist;
514 int i;
516 i = 0;
517 foreach(tllist, targetList)
519 TargetEntry *tle = (TargetEntry *) lfirst(tllist);
520 int32 tletypmod;
521 Form_pg_attribute attr;
522 char *attname;
524 /* resjunk entries may be ignored */
525 if (tle->resjunk)
526 continue;
527 i++;
528 if (i > resultDesc->natts)
529 ereport(ERROR,
530 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
531 isSelect ?
532 errmsg("SELECT rule's target list has too many entries") :
533 errmsg("RETURNING list has too many entries")));
535 attr = resultDesc->attrs[i - 1];
536 attname = NameStr(attr->attname);
539 * Disallow dropped columns in the relation. This won't happen in the
540 * cases we actually care about (namely creating a view via CREATE
541 * TABLE then CREATE RULE, or adding a RETURNING rule to a view).
542 * Trying to cope with it is much more trouble than it's worth,
543 * because we'd have to modify the rule to insert dummy NULLs at the
544 * right positions.
546 if (attr->attisdropped)
547 ereport(ERROR,
548 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
549 errmsg("cannot convert relation containing dropped columns to view")));
551 if (isSelect && strcmp(tle->resname, attname) != 0)
552 ereport(ERROR,
553 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
554 errmsg("SELECT rule's target entry %d has different column name from \"%s\"", i, attname)));
556 if (attr->atttypid != exprType((Node *) tle->expr))
557 ereport(ERROR,
558 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
559 isSelect ?
560 errmsg("SELECT rule's target entry %d has different type from column \"%s\"",
561 i, attname) :
562 errmsg("RETURNING list's entry %d has different type from column \"%s\"",
563 i, attname)));
566 * Allow typmods to be different only if one of them is -1, ie,
567 * "unspecified". This is necessary for cases like "numeric", where
568 * the table will have a filled-in default length but the select
569 * rule's expression will probably have typmod = -1.
571 tletypmod = exprTypmod((Node *) tle->expr);
572 if (attr->atttypmod != tletypmod &&
573 attr->atttypmod != -1 && tletypmod != -1)
574 ereport(ERROR,
575 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
576 isSelect ?
577 errmsg("SELECT rule's target entry %d has different size from column \"%s\"",
578 i, attname) :
579 errmsg("RETURNING list's entry %d has different size from column \"%s\"",
580 i, attname)));
583 if (i != resultDesc->natts)
584 ereport(ERROR,
585 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
586 isSelect ?
587 errmsg("SELECT rule's target list has too few entries") :
588 errmsg("RETURNING list has too few entries")));
592 * setRuleCheckAsUser
593 * Recursively scan a query or expression tree and set the checkAsUser
594 * field to the given userid in all rtable entries.
596 * Note: for a view (ON SELECT rule), the checkAsUser field of the *OLD*
597 * RTE entry will be overridden when the view rule is expanded, and the
598 * checkAsUser field of the *NEW* entry is irrelevant because that entry's
599 * requiredPerms bits will always be zero. However, for other types of rules
600 * it's important to set these fields to match the rule owner. So we just set
601 * them always.
603 void
604 setRuleCheckAsUser(Node *node, Oid userid)
606 (void) setRuleCheckAsUser_walker(node, &userid);
609 static bool
610 setRuleCheckAsUser_walker(Node *node, Oid *context)
612 if (node == NULL)
613 return false;
614 if (IsA(node, Query))
616 setRuleCheckAsUser_Query((Query *) node, *context);
617 return false;
619 return expression_tree_walker(node, setRuleCheckAsUser_walker,
620 (void *) context);
623 static void
624 setRuleCheckAsUser_Query(Query *qry, Oid userid)
626 ListCell *l;
628 /* Set all the RTEs in this query node */
629 foreach(l, qry->rtable)
631 RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
633 if (rte->rtekind == RTE_SUBQUERY)
635 /* Recurse into subquery in FROM */
636 setRuleCheckAsUser_Query(rte->subquery, userid);
638 else
639 rte->checkAsUser = userid;
642 /* Recurse into subquery-in-WITH */
643 foreach(l, qry->cteList)
645 CommonTableExpr *cte = (CommonTableExpr *) lfirst(l);
647 setRuleCheckAsUser_Query((Query *) cte->ctequery, userid);
650 /* If there are sublinks, search for them and process their RTEs */
651 if (qry->hasSubLinks)
652 query_tree_walker(qry, setRuleCheckAsUser_walker, (void *) &userid,
653 QTW_IGNORE_RC_SUBQUERIES);
658 * Change the firing semantics of an existing rule.
660 void
661 EnableDisableRule(Relation rel, const char *rulename,
662 char fires_when)
664 Relation pg_rewrite_desc;
665 Oid owningRel = RelationGetRelid(rel);
666 Oid eventRelationOid;
667 HeapTuple ruletup;
668 bool changed = false;
671 * Find the rule tuple to change.
673 pg_rewrite_desc = heap_open(RewriteRelationId, RowExclusiveLock);
674 ruletup = SearchSysCacheCopy(RULERELNAME,
675 ObjectIdGetDatum(owningRel),
676 PointerGetDatum(rulename),
677 0, 0);
678 if (!HeapTupleIsValid(ruletup))
679 ereport(ERROR,
680 (errcode(ERRCODE_UNDEFINED_OBJECT),
681 errmsg("rule \"%s\" for relation \"%s\" does not exist",
682 rulename, get_rel_name(owningRel))));
685 * Verify that the user has appropriate permissions.
687 eventRelationOid = ((Form_pg_rewrite) GETSTRUCT(ruletup))->ev_class;
688 Assert(eventRelationOid == owningRel);
689 if (!pg_class_ownercheck(eventRelationOid, GetUserId()))
690 aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,
691 get_rel_name(eventRelationOid));
694 * Change ev_enabled if it is different from the desired new state.
696 if (DatumGetChar(((Form_pg_rewrite) GETSTRUCT(ruletup))->ev_enabled) !=
697 fires_when)
699 ((Form_pg_rewrite) GETSTRUCT(ruletup))->ev_enabled =
700 CharGetDatum(fires_when);
701 simple_heap_update(pg_rewrite_desc, &ruletup->t_self, ruletup);
703 /* keep system catalog indexes current */
704 CatalogUpdateIndexes(pg_rewrite_desc, ruletup);
706 changed = true;
709 heap_freetuple(ruletup);
710 heap_close(pg_rewrite_desc, RowExclusiveLock);
713 * If we changed anything, broadcast a SI inval message to force each
714 * backend (including our own!) to rebuild relation's relcache entry.
715 * Otherwise they will fail to apply the change promptly.
717 if (changed)
718 CacheInvalidateRelcache(rel);
723 * Rename an existing rewrite rule.
725 * This is unused code at the moment. Note that it lacks a permissions check.
727 #ifdef NOT_USED
728 void
729 RenameRewriteRule(Oid owningRel, const char *oldName,
730 const char *newName)
732 Relation pg_rewrite_desc;
733 HeapTuple ruletup;
735 pg_rewrite_desc = heap_open(RewriteRelationId, RowExclusiveLock);
737 ruletup = SearchSysCacheCopy(RULERELNAME,
738 ObjectIdGetDatum(owningRel),
739 PointerGetDatum(oldName),
740 0, 0);
741 if (!HeapTupleIsValid(ruletup))
742 ereport(ERROR,
743 (errcode(ERRCODE_UNDEFINED_OBJECT),
744 errmsg("rule \"%s\" for relation \"%s\" does not exist",
745 oldName, get_rel_name(owningRel))));
747 /* should not already exist */
748 if (IsDefinedRewriteRule(owningRel, newName))
749 ereport(ERROR,
750 (errcode(ERRCODE_DUPLICATE_OBJECT),
751 errmsg("rule \"%s\" for relation \"%s\" already exists",
752 newName, get_rel_name(owningRel))));
754 namestrcpy(&(((Form_pg_rewrite) GETSTRUCT(ruletup))->rulename), newName);
756 simple_heap_update(pg_rewrite_desc, &ruletup->t_self, ruletup);
758 /* keep system catalog indexes current */
759 CatalogUpdateIndexes(pg_rewrite_desc, ruletup);
761 heap_freetuple(ruletup);
762 heap_close(pg_rewrite_desc, RowExclusiveLock);
765 #endif