?  search:
summary | log | graphiclog1 | graphiclog2 | commit | commitdiff | tree | refs | edit | fork
blame | history | raw | HEAD
librpc: Shorten dcerpc_binding_handle_call a bit
[Samba/gebeck_regimport.git] / source4 / torture / smb2 / acls.c
blob37052c66c12b7e4ddac49a2895e80716bcb8b734
1 /*
2 Unix SMB/CIFS implementation.
3
4 test security descriptor operations for SMB2
5
6 Copyright (C) Zack Kirsch 2009
7
8 This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 3 of the License, or
11 (at your option) any later version.
12
13 This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details.
17
18 You should have received a copy of the GNU General Public License
19 along with this program. If not, see <http://www.gnu.org/licenses/>.
20 */
21
22 #include "includes.h"
23 #include "libcli/smb2/smb2.h"
24 #include "libcli/smb2/smb2_calls.h"
25 #include "torture/torture.h"
26 #include "torture/util.h"
27 #include "torture/smb2/proto.h"
28 #include "libcli/security/security.h"
29 #include "librpc/gen_ndr/ndr_security.h"
30
31 #define CHECK_STATUS(status, correct) do { \
32 if (!NT_STATUS_EQUAL(status, correct)) { \
33 torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect status %s - should be %s\n", \
34 __location__, nt_errstr(status), nt_errstr(correct)); \
35 ret = false; \
36 goto done; \
37 }} while (0)
38
39 #define BASEDIR "smb2-testsd"
40
41 #define CHECK_ACCESS_IGNORE SEC_STD_SYNCHRONIZE
42
43 #define CHECK_ACCESS_FLAGS(_fh, flags) do { \
44 union smb_fileinfo _q; \
45 _q.access_information.level = RAW_FILEINFO_ACCESS_INFORMATION; \
46 _q.access_information.in.file.handle = (_fh); \
47 status = smb2_getinfo_file(tree, tctx, &_q); \
48 CHECK_STATUS(status, NT_STATUS_OK); \
49 /* Handle a Vista bug where SEC_STD_SYNCHRONIZE doesn't come back. */ \
50 if ((((flags) & CHECK_ACCESS_IGNORE) == CHECK_ACCESS_IGNORE) && \
51 ((_q.access_information.out.access_flags & CHECK_ACCESS_IGNORE) != CHECK_ACCESS_IGNORE)) { \
52 torture_comment(tctx, "SKIPPING (Vista bug): (%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
53 __location__, _q.access_information.out.access_flags, (flags)); \
54 } \
55 if ((_q.access_information.out.access_flags & ~CHECK_ACCESS_IGNORE) != \
56 (((flags) & ~CHECK_ACCESS_IGNORE))) { \
57 torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
58 __location__, _q.access_information.out.access_flags, (flags)); \
59 ret = false; \
60 goto done; \
61 } \
62 } while (0)
63
64 #define FAIL_UNLESS(__cond) \
65 do { \
66 if (__cond) {} else { \
67 torture_result(tctx, TORTURE_FAIL, "%s) condition violated: %s\n", \
68 __location__, #__cond); \
69 ret = false; goto done; \
70 } \
71 } while(0)
72
73 #define CHECK_SECURITY_DESCRIPTOR(_sd1, _sd2) do { \
74 if (!security_descriptor_equal(_sd1, _sd2)) { \
75 torture_warning(tctx, "security descriptors don't match!\n"); \
76 torture_warning(tctx, "got:\n"); \
77 NDR_PRINT_DEBUG(security_descriptor, _sd1); \
78 torture_warning(tctx, "expected:\n"); \
79 NDR_PRINT_DEBUG(security_descriptor, _sd2); \
80 torture_result(tctx, TORTURE_FAIL, \
81 "%s: security descriptors don't match!\n", \
82 __location__); \
83 ret = false; \
84 } \
85 } while (0)
86
87 /*
88 test the behaviour of the well known SID_CREATOR_OWNER sid, and some generic
89 mapping bits
90 Note: This test was copied from raw/acls.c.
91 */
92 static bool test_creator_sid(struct torture_context *tctx, struct smb2_tree *tree)
93 {
94 NTSTATUS status;
95 struct smb2_create io;
96 const char *fname = BASEDIR "\\creator.txt";
97 bool ret = true;
98 struct smb2_handle handle;
99 union smb_fileinfo q;
100 union smb_setfileinfo set;
101 struct security_descriptor *sd, *sd_orig, *sd2;
102 const char *owner_sid;
103
104 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
105 return false;
106
107 torture_comment(tctx, "TESTING SID_CREATOR_OWNER\n");
108
109 ZERO_STRUCT(io);
110 io.level = RAW_OPEN_SMB2;
111 io.in.create_flags = 0;
112 io.in.desired_access = SEC_STD_READ_CONTROL | SEC_STD_WRITE_DAC | SEC_STD_WRITE_OWNER;
113 io.in.create_options = 0;
114 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
115 io.in.share_access = NTCREATEX_SHARE_ACCESS_DELETE |
116 NTCREATEX_SHARE_ACCESS_READ |
117 NTCREATEX_SHARE_ACCESS_WRITE;
118 io.in.alloc_size = 0;
119 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
120 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
121 io.in.security_flags = 0;
122 io.in.fname = fname;
123
124 status = smb2_create(tree, tctx, &io);
125 CHECK_STATUS(status, NT_STATUS_OK);
126 handle = io.out.file.handle;
127
128 torture_comment(tctx, "get the original sd\n");
129 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
130 q.query_secdesc.in.file.handle = handle;
131 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
132 status = smb2_getinfo_file(tree, tctx, &q);
133 CHECK_STATUS(status, NT_STATUS_OK);
134 sd_orig = q.query_secdesc.out.sd;
135
136 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
137
138 torture_comment(tctx, "set a sec desc allowing no write by CREATOR_OWNER\n");
139 sd = security_descriptor_dacl_create(tctx,
140 0, NULL, NULL,
141 SID_CREATOR_OWNER,
142 SEC_ACE_TYPE_ACCESS_ALLOWED,
143 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
144 0,
145 NULL);
146
147 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
148 set.set_secdesc.in.file.handle = handle;
149 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
150 set.set_secdesc.in.sd = sd;
151
152 status = smb2_setinfo_file(tree, &set);
153 CHECK_STATUS(status, NT_STATUS_OK);
154
155 torture_comment(tctx, "try open for write\n");
156 io.in.desired_access = SEC_FILE_WRITE_DATA;
157 status = smb2_create(tree, tctx, &io);
158 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
159
160 torture_comment(tctx, "try open for read\n");
161 io.in.desired_access = SEC_FILE_READ_DATA;
162 status = smb2_create(tree, tctx, &io);
163 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
164
165 torture_comment(tctx, "try open for generic write\n");
166 io.in.desired_access = SEC_GENERIC_WRITE;
167 status = smb2_create(tree, tctx, &io);
168 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
169
170 torture_comment(tctx, "try open for generic read\n");
171 io.in.desired_access = SEC_GENERIC_READ;
172 status = smb2_create(tree, tctx, &io);
173 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
174
175 torture_comment(tctx, "set a sec desc allowing no write by owner\n");
176 sd = security_descriptor_dacl_create(tctx,
177 0, owner_sid, NULL,
178 owner_sid,
179 SEC_ACE_TYPE_ACCESS_ALLOWED,
180 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
181 0,
182 NULL);
183
184 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
185 set.set_secdesc.in.file.handle = handle;
186 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
187 set.set_secdesc.in.sd = sd;
188 status = smb2_setinfo_file(tree, &set);
189 CHECK_STATUS(status, NT_STATUS_OK);
190
191 torture_comment(tctx, "check that sd has been mapped correctly\n");
192 status = smb2_getinfo_file(tree, tctx, &q);
193 CHECK_STATUS(status, NT_STATUS_OK);
194 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
195
196 torture_comment(tctx, "try open for write\n");
197 io.in.desired_access = SEC_FILE_WRITE_DATA;
198 status = smb2_create(tree, tctx, &io);
199 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
200
201 torture_comment(tctx, "try open for read\n");
202 io.in.desired_access = SEC_FILE_READ_DATA;
203 status = smb2_create(tree, tctx, &io);
204 CHECK_STATUS(status, NT_STATUS_OK);
205 CHECK_ACCESS_FLAGS(io.out.file.handle,
206 SEC_FILE_READ_DATA);
207 smb2_util_close(tree, io.out.file.handle);
208
209 torture_comment(tctx, "try open for generic write\n");
210 io.in.desired_access = SEC_GENERIC_WRITE;
211 status = smb2_create(tree, tctx, &io);
212 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
213
214 torture_comment(tctx, "try open for generic read\n");
215 io.in.desired_access = SEC_GENERIC_READ;
216 status = smb2_create(tree, tctx, &io);
217 CHECK_STATUS(status, NT_STATUS_OK);
218 CHECK_ACCESS_FLAGS(io.out.file.handle,
219 SEC_RIGHTS_FILE_READ);
220 smb2_util_close(tree, io.out.file.handle);
221
222 torture_comment(tctx, "set a sec desc allowing generic read by owner\n");
223 sd = security_descriptor_dacl_create(tctx,
224 0, NULL, NULL,
225 owner_sid,
226 SEC_ACE_TYPE_ACCESS_ALLOWED,
227 SEC_GENERIC_READ | SEC_STD_ALL,
228 0,
229 NULL);
230
231 set.set_secdesc.in.sd = sd;
232 status = smb2_setinfo_file(tree, &set);
233 CHECK_STATUS(status, NT_STATUS_OK);
234
235 torture_comment(tctx, "check that generic read has been mapped correctly\n");
236 sd2 = security_descriptor_dacl_create(tctx,
237 0, owner_sid, NULL,
238 owner_sid,
239 SEC_ACE_TYPE_ACCESS_ALLOWED,
240 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
241 0,
242 NULL);
243
244 status = smb2_getinfo_file(tree, tctx, &q);
245 CHECK_STATUS(status, NT_STATUS_OK);
246 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
247
248 torture_comment(tctx, "try open for write\n");
249 io.in.desired_access = SEC_FILE_WRITE_DATA;
250 status = smb2_create(tree, tctx, &io);
251 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
252
253 torture_comment(tctx, "try open for read\n");
254 io.in.desired_access = SEC_FILE_READ_DATA;
255 status = smb2_create(tree, tctx, &io);
256 CHECK_STATUS(status, NT_STATUS_OK);
257 CHECK_ACCESS_FLAGS(io.out.file.handle,
258 SEC_FILE_READ_DATA);
259 smb2_util_close(tree, io.out.file.handle);
260
261 torture_comment(tctx, "try open for generic write\n");
262 io.in.desired_access = SEC_GENERIC_WRITE;
263 status = smb2_create(tree, tctx, &io);
264 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
265
266 torture_comment(tctx, "try open for generic read\n");
267 io.in.desired_access = SEC_GENERIC_READ;
268 status = smb2_create(tree, tctx, &io);
269 CHECK_STATUS(status, NT_STATUS_OK);
270 CHECK_ACCESS_FLAGS(io.out.file.handle, SEC_RIGHTS_FILE_READ);
271 smb2_util_close(tree, io.out.file.handle);
272
273
274 torture_comment(tctx, "put back original sd\n");
275 set.set_secdesc.in.sd = sd_orig;
276 status = smb2_setinfo_file(tree, &set);
277 CHECK_STATUS(status, NT_STATUS_OK);
278
279
280 done:
281 smb2_util_close(tree, handle);
282 smb2_deltree(tree, BASEDIR);
283 smb2_tdis(tree);
284 smb2_logoff(tree->session);
285 return ret;
286 }
287
288
289 /*
290 test the mapping of the SEC_GENERIC_xx bits to SEC_STD_xx and
291 SEC_FILE_xx bits
292 Note: This test was copied from raw/acls.c.
293 */
294 static bool test_generic_bits(struct torture_context *tctx, struct smb2_tree *tree)
295 {
296 NTSTATUS status;
297 struct smb2_create io;
298 const char *fname = BASEDIR "\\generic.txt";
299 bool ret = true;
300 struct smb2_handle handle;
301 int i;
302 union smb_fileinfo q;
303 union smb_setfileinfo set;
304 struct security_descriptor *sd, *sd_orig, *sd2;
305 const char *owner_sid;
306 const struct {
307 uint32_t gen_bits;
308 uint32_t specific_bits;
309 } file_mappings[] = {
310 { 0, 0 },
311 { SEC_GENERIC_READ, SEC_RIGHTS_FILE_READ },
312 { SEC_GENERIC_WRITE, SEC_RIGHTS_FILE_WRITE },
313 { SEC_GENERIC_EXECUTE, SEC_RIGHTS_FILE_EXECUTE },
314 { SEC_GENERIC_ALL, SEC_RIGHTS_FILE_ALL },
315 { SEC_FILE_READ_DATA, SEC_FILE_READ_DATA },
316 { SEC_FILE_READ_ATTRIBUTE, SEC_FILE_READ_ATTRIBUTE }
317 };
318 const struct {
319 uint32_t gen_bits;
320 uint32_t specific_bits;
321 } dir_mappings[] = {
322 { 0, 0 },
323 { SEC_GENERIC_READ, SEC_RIGHTS_DIR_READ },
324 { SEC_GENERIC_WRITE, SEC_RIGHTS_DIR_WRITE },
325 { SEC_GENERIC_EXECUTE, SEC_RIGHTS_DIR_EXECUTE },
326 { SEC_GENERIC_ALL, SEC_RIGHTS_DIR_ALL }
327 };
328 bool has_restore_privilege = false;
329 bool has_take_ownership_privilege = false;
330
331 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
332 return false;
333
334 torture_comment(tctx, "TESTING FILE GENERIC BITS\n");
335
336 ZERO_STRUCT(io);
337 io.level = RAW_OPEN_SMB2;
338 io.in.create_flags = 0;
339 io.in.desired_access =
340 SEC_STD_READ_CONTROL |
341 SEC_STD_WRITE_DAC |
342 SEC_STD_WRITE_OWNER;
343 io.in.create_options = 0;
344 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
345 io.in.share_access =
346 NTCREATEX_SHARE_ACCESS_READ |
347 NTCREATEX_SHARE_ACCESS_WRITE;
348 io.in.alloc_size = 0;
349 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
350 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
351 io.in.security_flags = 0;
352 io.in.fname = fname;
353 status = smb2_create(tree, tctx, &io);
354 CHECK_STATUS(status, NT_STATUS_OK);
355 handle = io.out.file.handle;
356
357 torture_comment(tctx, "get the original sd\n");
358 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
359 q.query_secdesc.in.file.handle = handle;
360 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
361 status = smb2_getinfo_file(tree, tctx, &q);
362 CHECK_STATUS(status, NT_STATUS_OK);
363 sd_orig = q.query_secdesc.out.sd;
364
365 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
366
367 /*
368 * XXX: The smblsa calls use SMB as their transport - need to get rid of
369 * dependency.
370 */
371 /*
372 status = smblsa_sid_check_privilege(cli,
373 owner_sid,
374 sec_privilege_name(SEC_PRIV_RESTORE));
375 has_restore_privilege = NT_STATUS_IS_OK(status);
376 if (!NT_STATUS_IS_OK(status)) {
377 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
378 }
379 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
380
381 status = smblsa_sid_check_privilege(cli,
382 owner_sid,
383 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
384 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
385 if (!NT_STATUS_IS_OK(status)) {
386 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
387 }
388 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
389 */
390
391 for (i=0;i<ARRAY_SIZE(file_mappings);i++) {
392 uint32_t expected_mask =
393 SEC_STD_WRITE_DAC |
394 SEC_STD_READ_CONTROL |
395 SEC_FILE_READ_ATTRIBUTE |
396 SEC_STD_DELETE;
397 uint32_t expected_mask_anon = SEC_FILE_READ_ATTRIBUTE;
398
399 if (has_restore_privilege) {
400 expected_mask_anon |= SEC_STD_DELETE;
401 }
402
403 torture_comment(tctx, "Testing generic bits 0x%08x\n",
404 file_mappings[i].gen_bits);
405 sd = security_descriptor_dacl_create(tctx,
406 0, owner_sid, NULL,
407 owner_sid,
408 SEC_ACE_TYPE_ACCESS_ALLOWED,
409 file_mappings[i].gen_bits,
410 0,
411 NULL);
412
413 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
414 set.set_secdesc.in.file.handle = handle;
415 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
416 set.set_secdesc.in.sd = sd;
417
418 status = smb2_setinfo_file(tree, &set);
419 CHECK_STATUS(status, NT_STATUS_OK);
420
421 sd2 = security_descriptor_dacl_create(tctx,
422 0, owner_sid, NULL,
423 owner_sid,
424 SEC_ACE_TYPE_ACCESS_ALLOWED,
425 file_mappings[i].specific_bits,
426 0,
427 NULL);
428
429 status = smb2_getinfo_file(tree, tctx, &q);
430 CHECK_STATUS(status, NT_STATUS_OK);
431 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
432
433 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
434 status = smb2_create(tree, tctx, &io);
435 CHECK_STATUS(status, NT_STATUS_OK);
436 CHECK_ACCESS_FLAGS(io.out.file.handle,
437 expected_mask | file_mappings[i].specific_bits);
438 smb2_util_close(tree, io.out.file.handle);
439
440 if (!has_take_ownership_privilege) {
441 continue;
442 }
443
444 torture_comment(tctx, "Testing generic bits 0x%08x (anonymous)\n",
445 file_mappings[i].gen_bits);
446 sd = security_descriptor_dacl_create(tctx,
447 0, SID_NT_ANONYMOUS, NULL,
448 owner_sid,
449 SEC_ACE_TYPE_ACCESS_ALLOWED,
450 file_mappings[i].gen_bits,
451 0,
452 NULL);
453
454 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
455 set.set_secdesc.in.file.handle = handle;
456 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
457 set.set_secdesc.in.sd = sd;
458
459 status = smb2_setinfo_file(tree, &set);
460 CHECK_STATUS(status, NT_STATUS_OK);
461
462 sd2 = security_descriptor_dacl_create(tctx,
463 0, SID_NT_ANONYMOUS, NULL,
464 owner_sid,
465 SEC_ACE_TYPE_ACCESS_ALLOWED,
466 file_mappings[i].specific_bits,
467 0,
468 NULL);
469
470 status = smb2_getinfo_file(tree, tctx, &q);
471 CHECK_STATUS(status, NT_STATUS_OK);
472 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
473
474 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
475 status = smb2_create(tree, tctx, &io);
476 CHECK_STATUS(status, NT_STATUS_OK);
477 CHECK_ACCESS_FLAGS(io.out.file.handle,
478 expected_mask_anon | file_mappings[i].specific_bits);
479 smb2_util_close(tree, io.out.file.handle);
480 }
481
482 torture_comment(tctx, "put back original sd\n");
483 set.set_secdesc.in.sd = sd_orig;
484 status = smb2_setinfo_file(tree, &set);
485 CHECK_STATUS(status, NT_STATUS_OK);
486
487 smb2_util_close(tree, handle);
488 smb2_util_unlink(tree, fname);
489
490
491 torture_comment(tctx, "TESTING DIR GENERIC BITS\n");
492
493 ZERO_STRUCT(io);
494 io.level = RAW_OPEN_SMB2;
495 io.in.create_flags = 0;
496 io.in.desired_access =
497 SEC_STD_READ_CONTROL |
498 SEC_STD_WRITE_DAC |
499 SEC_STD_WRITE_OWNER;
500 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
501 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
502 io.in.share_access =
503 NTCREATEX_SHARE_ACCESS_READ |
504 NTCREATEX_SHARE_ACCESS_WRITE;
505 io.in.alloc_size = 0;
506 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
507 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
508 io.in.security_flags = 0;
509 io.in.fname = fname;
510 status = smb2_create(tree, tctx, &io);
511 CHECK_STATUS(status, NT_STATUS_OK);
512 handle = io.out.file.handle;
513
514 torture_comment(tctx, "get the original sd\n");
515 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
516 q.query_secdesc.in.file.handle = handle;
517 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
518 status = smb2_getinfo_file(tree, tctx, &q);
519 CHECK_STATUS(status, NT_STATUS_OK);
520 sd_orig = q.query_secdesc.out.sd;
521
522 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
523
524 /*
525 * XXX: The smblsa calls use SMB as their transport - need to get rid of
526 * dependency.
527 */
528 /*
529 status = smblsa_sid_check_privilege(cli,
530 owner_sid,
531 sec_privilege_name(SEC_PRIV_RESTORE));
532 has_restore_privilege = NT_STATUS_IS_OK(status);
533 if (!NT_STATUS_IS_OK(status)) {
534 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
535 }
536 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
537
538 status = smblsa_sid_check_privilege(cli,
539 owner_sid,
540 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
541 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
542 if (!NT_STATUS_IS_OK(status)) {
543 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
544 }
545 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
546
547 */
548 for (i=0;i<ARRAY_SIZE(dir_mappings);i++) {
549 uint32_t expected_mask =
550 SEC_STD_WRITE_DAC |
551 SEC_STD_READ_CONTROL |
552 SEC_FILE_READ_ATTRIBUTE |
553 SEC_STD_DELETE;
554 uint32_t expected_mask_anon = SEC_FILE_READ_ATTRIBUTE;
555
556 if (has_restore_privilege) {
557 expected_mask_anon |= SEC_STD_DELETE;
558 }
559
560 torture_comment(tctx, "Testing generic bits 0x%08x\n",
561 file_mappings[i].gen_bits);
562 sd = security_descriptor_dacl_create(tctx,
563 0, owner_sid, NULL,
564 owner_sid,
565 SEC_ACE_TYPE_ACCESS_ALLOWED,
566 dir_mappings[i].gen_bits,
567 0,
568 NULL);
569
570 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
571 set.set_secdesc.in.file.handle = handle;
572 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
573 set.set_secdesc.in.sd = sd;
574
575 status = smb2_setinfo_file(tree, &set);
576 CHECK_STATUS(status, NT_STATUS_OK);
577
578 sd2 = security_descriptor_dacl_create(tctx,
579 0, owner_sid, NULL,
580 owner_sid,
581 SEC_ACE_TYPE_ACCESS_ALLOWED,
582 dir_mappings[i].specific_bits,
583 0,
584 NULL);
585
586 status = smb2_getinfo_file(tree, tctx, &q);
587 CHECK_STATUS(status, NT_STATUS_OK);
588 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
589
590 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
591 status = smb2_create(tree, tctx, &io);
592 CHECK_STATUS(status, NT_STATUS_OK);
593 CHECK_ACCESS_FLAGS(io.out.file.handle,
594 expected_mask | dir_mappings[i].specific_bits);
595 smb2_util_close(tree, io.out.file.handle);
596
597 if (!has_take_ownership_privilege) {
598 continue;
599 }
600
601 torture_comment(tctx, "Testing generic bits 0x%08x (anonymous)\n",
602 file_mappings[i].gen_bits);
603 sd = security_descriptor_dacl_create(tctx,
604 0, SID_NT_ANONYMOUS, NULL,
605 owner_sid,
606 SEC_ACE_TYPE_ACCESS_ALLOWED,
607 file_mappings[i].gen_bits,
608 0,
609 NULL);
610
611 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
612 set.set_secdesc.in.file.handle = handle;
613 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
614 set.set_secdesc.in.sd = sd;
615
616 status = smb2_setinfo_file(tree, &set);
617 CHECK_STATUS(status, NT_STATUS_OK);
618
619 sd2 = security_descriptor_dacl_create(tctx,
620 0, SID_NT_ANONYMOUS, NULL,
621 owner_sid,
622 SEC_ACE_TYPE_ACCESS_ALLOWED,
623 file_mappings[i].specific_bits,
624 0,
625 NULL);
626
627 status = smb2_getinfo_file(tree, tctx, &q);
628 CHECK_STATUS(status, NT_STATUS_OK);
629 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
630
631 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
632 status = smb2_create(tree, tctx, &io);
633 CHECK_STATUS(status, NT_STATUS_OK);
634 CHECK_ACCESS_FLAGS(io.out.file.handle,
635 expected_mask_anon | dir_mappings[i].specific_bits);
636 smb2_util_close(tree, io.out.file.handle);
637 }
638
639 torture_comment(tctx, "put back original sd\n");
640 set.set_secdesc.in.sd = sd_orig;
641 status = smb2_setinfo_file(tree, &set);
642 CHECK_STATUS(status, NT_STATUS_OK);
643
644 smb2_util_close(tree, handle);
645 smb2_util_unlink(tree, fname);
646
647 done:
648 smb2_util_close(tree, handle);
649 smb2_deltree(tree, BASEDIR);
650 smb2_tdis(tree);
651 smb2_logoff(tree->session);
652 return ret;
653 }
654
655
656 /*
657 see what access bits the owner of a file always gets
658 Note: This test was copied from raw/acls.c.
659 */
660 static bool test_owner_bits(struct torture_context *tctx, struct smb2_tree *tree)
661 {
662 NTSTATUS status;
663 struct smb2_create io;
664 const char *fname = BASEDIR "\\test_owner_bits.txt";
665 bool ret = true;
666 struct smb2_handle handle;
667 int i;
668 union smb_fileinfo q;
669 union smb_setfileinfo set;
670 struct security_descriptor *sd, *sd_orig;
671 const char *owner_sid;
672 uint32_t expected_bits;
673
674 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
675 return false;
676
677 torture_comment(tctx, "TESTING FILE OWNER BITS\n");
678
679 ZERO_STRUCT(io);
680 io.level = RAW_OPEN_SMB2;
681 io.in.create_flags = 0;
682 io.in.desired_access =
683 SEC_STD_READ_CONTROL |
684 SEC_STD_WRITE_DAC |
685 SEC_STD_WRITE_OWNER;
686 io.in.create_options = 0;
687 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
688 io.in.share_access =
689 NTCREATEX_SHARE_ACCESS_READ |
690 NTCREATEX_SHARE_ACCESS_WRITE;
691 io.in.alloc_size = 0;
692 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
693 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
694 io.in.security_flags = 0;
695 io.in.fname = fname;
696 status = smb2_create(tree, tctx, &io);
697 CHECK_STATUS(status, NT_STATUS_OK);
698 handle = io.out.file.handle;
699
700 torture_comment(tctx, "get the original sd\n");
701 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
702 q.query_secdesc.in.file.handle = handle;
703 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
704 status = smb2_getinfo_file(tree, tctx, &q);
705 CHECK_STATUS(status, NT_STATUS_OK);
706 sd_orig = q.query_secdesc.out.sd;
707
708 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
709
710 /*
711 * XXX: The smblsa calls use SMB as their transport - need to get rid of
712 * dependency.
713 */
714 /*
715 status = smblsa_sid_check_privilege(cli,
716 owner_sid,
717 sec_privilege_name(SEC_PRIV_RESTORE));
718 has_restore_privilege = NT_STATUS_IS_OK(status);
719 if (!NT_STATUS_IS_OK(status)) {
720 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
721 }
722 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
723
724 status = smblsa_sid_check_privilege(cli,
725 owner_sid,
726 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
727 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
728 if (!NT_STATUS_IS_OK(status)) {
729 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
730 }
731 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
732 */
733
734 sd = security_descriptor_dacl_create(tctx,
735 0, NULL, NULL,
736 owner_sid,
737 SEC_ACE_TYPE_ACCESS_ALLOWED,
738 SEC_FILE_WRITE_DATA,
739 0,
740 NULL);
741
742 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
743 set.set_secdesc.in.file.handle = handle;
744 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
745 set.set_secdesc.in.sd = sd;
746
747 status = smb2_setinfo_file(tree, &set);
748 CHECK_STATUS(status, NT_STATUS_OK);
749
750 expected_bits = SEC_FILE_WRITE_DATA | SEC_FILE_READ_ATTRIBUTE;
751
752 for (i=0;i<16;i++) {
753 uint32_t bit = (1<<i);
754 io.in.desired_access = bit;
755 status = smb2_create(tree, tctx, &io);
756 if (expected_bits & bit) {
757 if (!NT_STATUS_IS_OK(status)) {
758 torture_warning(tctx, "failed with access mask 0x%08x of expected 0x%08x\n",
759 bit, expected_bits);
760 }
761 CHECK_STATUS(status, NT_STATUS_OK);
762 CHECK_ACCESS_FLAGS(io.out.file.handle, bit);
763 smb2_util_close(tree, io.out.file.handle);
764 } else {
765 if (NT_STATUS_IS_OK(status)) {
766 torture_warning(tctx, "open succeeded with access mask 0x%08x of "
767 "expected 0x%08x - should fail\n",
768 bit, expected_bits);
769 }
770 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
771 }
772 }
773
774 torture_comment(tctx, "put back original sd\n");
775 set.set_secdesc.in.sd = sd_orig;
776 status = smb2_setinfo_file(tree, &set);
777 CHECK_STATUS(status, NT_STATUS_OK);
778
779 done:
780 smb2_util_close(tree, handle);
781 smb2_util_unlink(tree, fname);
782 smb2_deltree(tree, BASEDIR);
783 smb2_tdis(tree);
784 smb2_logoff(tree->session);
785 return ret;
786 }
787
788
789
790 /*
791 test the inheritance of ACL flags onto new files and directories
792 Note: This test was copied from raw/acls.c.
793 */
794 static bool test_inheritance(struct torture_context *tctx, struct smb2_tree *tree)
795 {
796 NTSTATUS status;
797 struct smb2_create io;
798 const char *dname = BASEDIR "\\inheritance";
799 const char *fname1 = BASEDIR "\\inheritance\\testfile";
800 const char *fname2 = BASEDIR "\\inheritance\\testdir";
801 bool ret = true;
802 struct smb2_handle handle, handle2;
803 int i;
804 union smb_fileinfo q;
805 union smb_setfileinfo set;
806 struct security_descriptor *sd, *sd2, *sd_orig=NULL, *sd_def1, *sd_def2;
807 const char *owner_sid;
808 const struct dom_sid *creator_owner;
809 const struct {
810 uint32_t parent_flags;
811 uint32_t file_flags;
812 uint32_t dir_flags;
813 } test_flags[] = {
814 {
815 0,
816 0,
817 0
818 },
819 {
820 SEC_ACE_FLAG_OBJECT_INHERIT,
821 0,
822 SEC_ACE_FLAG_OBJECT_INHERIT |
823 SEC_ACE_FLAG_INHERIT_ONLY,
824 },
825 {
826 SEC_ACE_FLAG_CONTAINER_INHERIT,
827 0,
828 SEC_ACE_FLAG_CONTAINER_INHERIT,
829 },
830 {
831 SEC_ACE_FLAG_OBJECT_INHERIT |
832 SEC_ACE_FLAG_CONTAINER_INHERIT,
833 0,
834 SEC_ACE_FLAG_OBJECT_INHERIT |
835 SEC_ACE_FLAG_CONTAINER_INHERIT,
836 },
837 {
838 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT,
839 0,
840 0,
841 },
842 {
843 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
844 SEC_ACE_FLAG_OBJECT_INHERIT,
845 0,
846 0,
847 },
848 {
849 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
850 SEC_ACE_FLAG_CONTAINER_INHERIT,
851 0,
852 0,
853 },
854 {
855 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
856 SEC_ACE_FLAG_CONTAINER_INHERIT |
857 SEC_ACE_FLAG_OBJECT_INHERIT,
858 0,
859 0,
860 },
861 {
862 SEC_ACE_FLAG_INHERIT_ONLY,
863 0,
864 0,
865 },
866 {
867 SEC_ACE_FLAG_INHERIT_ONLY |
868 SEC_ACE_FLAG_OBJECT_INHERIT,
869 0,
870 SEC_ACE_FLAG_OBJECT_INHERIT |
871 SEC_ACE_FLAG_INHERIT_ONLY,
872 },
873 {
874 SEC_ACE_FLAG_INHERIT_ONLY |
875 SEC_ACE_FLAG_CONTAINER_INHERIT,
876 0,
877 SEC_ACE_FLAG_CONTAINER_INHERIT,
878 },
879 {
880 SEC_ACE_FLAG_INHERIT_ONLY |
881 SEC_ACE_FLAG_CONTAINER_INHERIT |
882 SEC_ACE_FLAG_OBJECT_INHERIT,
883 0,
884 SEC_ACE_FLAG_CONTAINER_INHERIT |
885 SEC_ACE_FLAG_OBJECT_INHERIT,
886 },
887 {
888 SEC_ACE_FLAG_INHERIT_ONLY |
889 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT,
890 0,
891 0,
892 },
893 {
894 SEC_ACE_FLAG_INHERIT_ONLY |
895 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
896 SEC_ACE_FLAG_OBJECT_INHERIT,
897 0,
898 0,
899 },
900 {
901 SEC_ACE_FLAG_INHERIT_ONLY |
902 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
903 SEC_ACE_FLAG_CONTAINER_INHERIT,
904 0,
905 0,
906 },
907 {
908 SEC_ACE_FLAG_INHERIT_ONLY |
909 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
910 SEC_ACE_FLAG_CONTAINER_INHERIT |
911 SEC_ACE_FLAG_OBJECT_INHERIT,
912 0,
913 0,
914 }
915 };
916
917 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
918 return false;
919
920 torture_comment(tctx, "TESTING ACL INHERITANCE\n");
921
922 ZERO_STRUCT(io);
923 io.level = RAW_OPEN_SMB2;
924 io.in.create_flags = 0;
925 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
926 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
927 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
928 io.in.share_access = 0;
929 io.in.alloc_size = 0;
930 io.in.create_disposition = NTCREATEX_DISP_CREATE;
931 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
932 io.in.security_flags = 0;
933 io.in.fname = dname;
934
935 status = smb2_create(tree, tctx, &io);
936 CHECK_STATUS(status, NT_STATUS_OK);
937 handle = io.out.file.handle;
938
939 torture_comment(tctx, "get the original sd\n");
940 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
941 q.query_secdesc.in.file.handle = handle;
942 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
943 status = smb2_getinfo_file(tree, tctx, &q);
944 CHECK_STATUS(status, NT_STATUS_OK);
945 sd_orig = q.query_secdesc.out.sd;
946
947 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
948
949 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
950
951 /*
952 * The Windows Default ACL for a new file, when there is no ACL to be
953 * inherited: FullControl for the owner and SYSTEM.
954 */
955 sd_def1 = security_descriptor_dacl_create(tctx,
956 0, owner_sid, NULL,
957 owner_sid,
958 SEC_ACE_TYPE_ACCESS_ALLOWED,
959 SEC_RIGHTS_FILE_ALL,
960 0,
961 SID_NT_SYSTEM,
962 SEC_ACE_TYPE_ACCESS_ALLOWED,
963 SEC_RIGHTS_FILE_ALL,
964 0,
965 NULL);
966
967 /*
968 * Use this in the case the system being tested does not add an ACE for
969 * the SYSTEM SID.
970 */
971 sd_def2 = security_descriptor_dacl_create(tctx,
972 0, owner_sid, NULL,
973 owner_sid,
974 SEC_ACE_TYPE_ACCESS_ALLOWED,
975 SEC_RIGHTS_FILE_ALL,
976 0,
977 NULL);
978
979 creator_owner = dom_sid_parse_talloc(tctx, SID_CREATOR_OWNER);
980
981 for (i=0;i<ARRAY_SIZE(test_flags);i++) {
982 sd = security_descriptor_dacl_create(tctx,
983 0, NULL, NULL,
984 SID_CREATOR_OWNER,
985 SEC_ACE_TYPE_ACCESS_ALLOWED,
986 SEC_FILE_WRITE_DATA,
987 test_flags[i].parent_flags,
988 SID_WORLD,
989 SEC_ACE_TYPE_ACCESS_ALLOWED,
990 SEC_FILE_ALL | SEC_STD_ALL,
991 0,
992 NULL);
993 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
994 set.set_secdesc.in.file.handle = handle;
995 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
996 set.set_secdesc.in.sd = sd;
997 status = smb2_setinfo_file(tree, &set);
998 CHECK_STATUS(status, NT_STATUS_OK);
999
1000 io.in.fname = fname1;
1001 io.in.create_options = 0;
1002 status = smb2_create(tree, tctx, &io);
1003 CHECK_STATUS(status, NT_STATUS_OK);
1004 handle2 = io.out.file.handle;
1005
1006 q.query_secdesc.in.file.handle = handle2;
1007 status = smb2_getinfo_file(tree, tctx, &q);
1008 CHECK_STATUS(status, NT_STATUS_OK);
1009
1010 smb2_util_close(tree, handle2);
1011 smb2_util_unlink(tree, fname1);
1012
1013 if (!(test_flags[i].parent_flags & SEC_ACE_FLAG_OBJECT_INHERIT)) {
1014 if (!security_descriptor_equal(q.query_secdesc.out.sd, sd_def1) &&
1015 !security_descriptor_equal(q.query_secdesc.out.sd, sd_def2)) {
1016 torture_warning(tctx, "Expected default sd:\n");
1017 NDR_PRINT_DEBUG(security_descriptor, sd_def1);
1018 torture_warning(tctx, "at %d - got:\n", i);
1019 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1020 }
1021 goto check_dir;
1022 }
1023
1024 if (q.query_secdesc.out.sd->dacl == NULL ||
1025 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1026 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1027 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1028 sd_orig->owner_sid)) {
1029 torture_warning(tctx, "Bad sd in child file at %d\n", i);
1030 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1031 ret = false;
1032 goto check_dir;
1033 }
1034
1035 if (q.query_secdesc.out.sd->dacl->aces[0].flags !=
1036 test_flags[i].file_flags) {
1037 torture_warning(tctx, "incorrect file_flags 0x%x - expected 0x%x for parent 0x%x with (i=%d)\n",
1038 q.query_secdesc.out.sd->dacl->aces[0].flags,
1039 test_flags[i].file_flags,
1040 test_flags[i].parent_flags,
1041 i);
1042 ret = false;
1043 }
1044
1045 check_dir:
1046 io.in.fname = fname2;
1047 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1048 status = smb2_create(tree, tctx, &io);
1049 CHECK_STATUS(status, NT_STATUS_OK);
1050 handle2 = io.out.file.handle;
1051
1052 q.query_secdesc.in.file.handle = handle2;
1053 status = smb2_getinfo_file(tree, tctx, &q);
1054 CHECK_STATUS(status, NT_STATUS_OK);
1055
1056 smb2_util_close(tree, handle2);
1057 smb2_util_rmdir(tree, fname2);
1058
1059 if (!(test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) &&
1060 (!(test_flags[i].parent_flags & SEC_ACE_FLAG_OBJECT_INHERIT) ||
1061 (test_flags[i].parent_flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT))) {
1062 if (!security_descriptor_equal(q.query_secdesc.out.sd, sd_def1) &&
1063 !security_descriptor_equal(q.query_secdesc.out.sd, sd_def2)) {
1064 torture_warning(tctx, "Expected default sd for dir at %d:\n", i);
1065 NDR_PRINT_DEBUG(security_descriptor, sd_def1);
1066 torture_warning(tctx, "got:\n");
1067 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1068 }
1069 continue;
1070 }
1071
1072 if ((test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) &&
1073 (test_flags[i].parent_flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT)) {
1074 if (q.query_secdesc.out.sd->dacl == NULL ||
1075 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1076 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1077 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1078 sd_orig->owner_sid) ||
1079 q.query_secdesc.out.sd->dacl->aces[0].flags != test_flags[i].dir_flags) {
1080 torture_warning(tctx, "(CI & NP) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1081 test_flags[i].dir_flags,
1082 test_flags[i].parent_flags, i);
1083 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1084 torture_warning(tctx, "FYI, here is the parent sd:\n");
1085 NDR_PRINT_DEBUG(security_descriptor, sd);
1086 ret = false;
1087 continue;
1088 }
1089 } else if (test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) {
1090 if (q.query_secdesc.out.sd->dacl == NULL ||
1091 q.query_secdesc.out.sd->dacl->num_aces != 2 ||
1092 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1093 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1094 sd_orig->owner_sid) ||
1095 q.query_secdesc.out.sd->dacl->aces[1].access_mask != SEC_FILE_WRITE_DATA ||
1096 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[1].trustee,
1097 creator_owner) ||
1098 q.query_secdesc.out.sd->dacl->aces[0].flags != 0 ||
1099 q.query_secdesc.out.sd->dacl->aces[1].flags !=
1100 (test_flags[i].dir_flags | SEC_ACE_FLAG_INHERIT_ONLY)) {
1101 torture_warning(tctx, "(CI) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1102 test_flags[i].dir_flags,
1103 test_flags[i].parent_flags, i);
1104 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1105 torture_warning(tctx, "FYI, here is the parent sd:\n");
1106 NDR_PRINT_DEBUG(security_descriptor, sd);
1107 ret = false;
1108 continue;
1109 }
1110 } else {
1111 if (q.query_secdesc.out.sd->dacl == NULL ||
1112 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1113 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1114 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1115 creator_owner) ||
1116 q.query_secdesc.out.sd->dacl->aces[0].flags != test_flags[i].dir_flags) {
1117 torture_warning(tctx, "(0) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1118 test_flags[i].dir_flags,
1119 test_flags[i].parent_flags, i);
1120 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1121 torture_warning(tctx, "FYI, here is the parent sd:\n");
1122 NDR_PRINT_DEBUG(security_descriptor, sd);
1123 ret = false;
1124 continue;
1125 }
1126 }
1127 }
1128
1129 torture_comment(tctx, "Testing access checks on inherited create with %s\n", fname1);
1130 sd = security_descriptor_dacl_create(tctx,
1131 0, NULL, NULL,
1132 owner_sid,
1133 SEC_ACE_TYPE_ACCESS_ALLOWED,
1134 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1135 SEC_ACE_FLAG_OBJECT_INHERIT,
1136 SID_WORLD,
1137 SEC_ACE_TYPE_ACCESS_ALLOWED,
1138 SEC_FILE_ALL | SEC_STD_ALL,
1139 0,
1140 NULL);
1141 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1142 set.set_secdesc.in.file.handle = handle;
1143 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1144 set.set_secdesc.in.sd = sd;
1145 status = smb2_setinfo_file(tree, &set);
1146 CHECK_STATUS(status, NT_STATUS_OK);
1147
1148 /* Check DACL we just set. */
1149 torture_comment(tctx, "checking new sd\n");
1150 q.query_secdesc.in.file.handle = handle;
1151 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1152 status = smb2_getinfo_file(tree, tctx, &q);
1153 CHECK_STATUS(status, NT_STATUS_OK);
1154 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
1155
1156 io.in.fname = fname1;
1157 io.in.create_options = 0;
1158 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1159 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1160 status = smb2_create(tree, tctx, &io);
1161 CHECK_STATUS(status, NT_STATUS_OK);
1162 handle2 = io.out.file.handle;
1163 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1164
1165 q.query_secdesc.in.file.handle = handle2;
1166 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1167 status = smb2_getinfo_file(tree, tctx, &q);
1168 CHECK_STATUS(status, NT_STATUS_OK);
1169 smb2_util_close(tree, handle2);
1170
1171 sd2 = security_descriptor_dacl_create(tctx,
1172 0, owner_sid, NULL,
1173 owner_sid,
1174 SEC_ACE_TYPE_ACCESS_ALLOWED,
1175 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1176 0,
1177 NULL);
1178 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1179
1180 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1181 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1182 status = smb2_create(tree, tctx, &io);
1183 if (NT_STATUS_IS_OK(status)) {
1184 torture_warning(tctx, "failed: w2k3 ACL bug (allowed open when ACL should deny)\n");
1185 ret = false;
1186 handle2 = io.out.file.handle;
1187 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1188 smb2_util_close(tree, handle2);
1189 } else {
1190 if (torture_setting_bool(tctx, "hide_on_access_denied",
1191 false)) {
1192 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1193 } else {
1194 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1195 }
1196 }
1197
1198 torture_comment(tctx, "trying without execute\n");
1199 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1200 io.in.desired_access = SEC_RIGHTS_FILE_ALL & ~SEC_FILE_EXECUTE;
1201 status = smb2_create(tree, tctx, &io);
1202 if (torture_setting_bool(tctx, "hide_on_access_denied", false)) {
1203 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1204 } else {
1205 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1206 }
1207
1208 torture_comment(tctx, "and with full permissions again\n");
1209 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1210 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1211 status = smb2_create(tree, tctx, &io);
1212 if (torture_setting_bool(tctx, "hide_on_access_denied", false)) {
1213 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1214 } else {
1215 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1216 }
1217
1218 io.in.desired_access = SEC_FILE_WRITE_DATA;
1219 status = smb2_create(tree, tctx, &io);
1220 CHECK_STATUS(status, NT_STATUS_OK);
1221 handle2 = io.out.file.handle;
1222 CHECK_ACCESS_FLAGS(handle2, SEC_FILE_WRITE_DATA);
1223 smb2_util_close(tree, handle2);
1224
1225 torture_comment(tctx, "put back original sd\n");
1226 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1227 set.set_secdesc.in.file.handle = handle;
1228 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1229 set.set_secdesc.in.sd = sd_orig;
1230 status = smb2_setinfo_file(tree, &set);
1231 CHECK_STATUS(status, NT_STATUS_OK);
1232
1233 smb2_util_close(tree, handle);
1234
1235 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1236 status = smb2_create(tree, tctx, &io);
1237 if (torture_setting_bool(tctx, "hide_on_access_denied", false)) {
1238 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1239 } else {
1240 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1241 }
1242
1243 io.in.desired_access = SEC_FILE_WRITE_DATA;
1244 status = smb2_create(tree, tctx, &io);
1245 CHECK_STATUS(status, NT_STATUS_OK);
1246 handle2 = io.out.file.handle;
1247 CHECK_ACCESS_FLAGS(handle2, SEC_FILE_WRITE_DATA);
1248 smb2_util_close(tree, handle2);
1249
1250 smb2_util_unlink(tree, fname1);
1251 smb2_util_rmdir(tree, dname);
1252
1253 done:
1254 if (sd_orig != NULL) {
1255 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1256 set.set_secdesc.in.file.handle = handle;
1257 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1258 set.set_secdesc.in.sd = sd_orig;
1259 status = smb2_setinfo_file(tree, &set);
1260 }
1261
1262 smb2_util_close(tree, handle);
1263 smb2_deltree(tree, BASEDIR);
1264 smb2_tdis(tree);
1265 smb2_logoff(tree->session);
1266 return ret;
1267 }
1268
1269 static bool test_inheritance_flags(struct torture_context *tctx,
1270 struct smb2_tree *tree)
1271 {
1272 NTSTATUS status;
1273 struct smb2_create io;
1274 const char *dname = BASEDIR "\\inheritance";
1275 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1276 bool ret = true;
1277 struct smb2_handle handle, handle2;
1278 int i, j;
1279 union smb_fileinfo q;
1280 union smb_setfileinfo set;
1281 struct security_descriptor *sd, *sd2, *sd_orig=NULL;
1282 const char *owner_sid;
1283 struct {
1284 uint32_t parent_set_sd_type; /* 3 options */
1285 uint32_t parent_set_ace_inherit; /* 1 option */
1286 uint32_t parent_get_sd_type;
1287 uint32_t parent_get_ace_inherit;
1288 uint32_t child_get_sd_type;
1289 uint32_t child_get_ace_inherit;
1290 } tflags[16] = {{0}}; /* 2^4 */
1291
1292 for (i = 0; i < 15; i++) {
1293 torture_comment(tctx, "i=%d:", i);
1294
1295 if (i & 1) {
1296 tflags[i].parent_set_sd_type |=
1297 SEC_DESC_DACL_AUTO_INHERITED;
1298 torture_comment(tctx, "AUTO_INHERITED, ");
1299 }
1300 if (i & 2) {
1301 tflags[i].parent_set_sd_type |=
1302 SEC_DESC_DACL_AUTO_INHERIT_REQ;
1303 torture_comment(tctx, "AUTO_INHERIT_REQ, ");
1304 }
1305 if (i & 4) {
1306 tflags[i].parent_set_sd_type |=
1307 SEC_DESC_DACL_PROTECTED;
1308 torture_comment(tctx, "PROTECTED, ");
1309 tflags[i].parent_get_sd_type |=
1310 SEC_DESC_DACL_PROTECTED;
1311 }
1312 if (i & 8) {
1313 tflags[i].parent_set_ace_inherit |=
1314 SEC_ACE_FLAG_INHERITED_ACE;
1315 torture_comment(tctx, "INHERITED, ");
1316 tflags[i].parent_get_ace_inherit |=
1317 SEC_ACE_FLAG_INHERITED_ACE;
1318 }
1319
1320 if ((tflags[i].parent_set_sd_type &
1321 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) ==
1322 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) {
1323 tflags[i].parent_get_sd_type |=
1324 SEC_DESC_DACL_AUTO_INHERITED;
1325 tflags[i].child_get_sd_type |=
1326 SEC_DESC_DACL_AUTO_INHERITED;
1327 tflags[i].child_get_ace_inherit |=
1328 SEC_ACE_FLAG_INHERITED_ACE;
1329 torture_comment(tctx, " ... parent is AUTO INHERITED");
1330 }
1331
1332 if (tflags[i].parent_set_ace_inherit &
1333 SEC_ACE_FLAG_INHERITED_ACE) {
1334 tflags[i].parent_get_ace_inherit =
1335 SEC_ACE_FLAG_INHERITED_ACE;
1336 torture_comment(tctx, " ... parent ACE is INHERITED");
1337 }
1338
1339 torture_comment(tctx, "\n");
1340 }
1341
1342 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
1343 return false;
1344
1345 torture_comment(tctx, "TESTING ACL INHERITANCE FLAGS\n");
1346
1347 ZERO_STRUCT(io);
1348 io.level = RAW_OPEN_SMB2;
1349 io.in.create_flags = 0;
1350 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1351 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1352 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
1353 io.in.share_access = NTCREATEX_SHARE_ACCESS_MASK;
1354 io.in.alloc_size = 0;
1355 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1356 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
1357 io.in.security_flags = 0;
1358 io.in.fname = dname;
1359
1360 torture_comment(tctx, "creating initial directory %s\n", dname);
1361 status = smb2_create(tree, tctx, &io);
1362 CHECK_STATUS(status, NT_STATUS_OK);
1363 handle = io.out.file.handle;
1364
1365 torture_comment(tctx, "getting original sd\n");
1366 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1367 q.query_secdesc.in.file.handle = handle;
1368 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1369 status = smb2_getinfo_file(tree, tctx, &q);
1370 CHECK_STATUS(status, NT_STATUS_OK);
1371 sd_orig = q.query_secdesc.out.sd;
1372
1373 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1374 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
1375
1376 for (i=0; i < ARRAY_SIZE(tflags); i++) {
1377 torture_comment(tctx, "setting a new sd on directory, pass #%d\n", i);
1378
1379 sd = security_descriptor_dacl_create(tctx,
1380 tflags[i].parent_set_sd_type,
1381 NULL, NULL,
1382 owner_sid,
1383 SEC_ACE_TYPE_ACCESS_ALLOWED,
1384 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1385 SEC_ACE_FLAG_OBJECT_INHERIT |
1386 SEC_ACE_FLAG_CONTAINER_INHERIT |
1387 tflags[i].parent_set_ace_inherit,
1388 SID_WORLD,
1389 SEC_ACE_TYPE_ACCESS_ALLOWED,
1390 SEC_FILE_ALL | SEC_STD_ALL,
1391 0,
1392 NULL);
1393 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1394 set.set_secdesc.in.file.handle = handle;
1395 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1396 set.set_secdesc.in.sd = sd;
1397 status = smb2_setinfo_file(tree, &set);
1398 CHECK_STATUS(status, NT_STATUS_OK);
1399
1400 /*
1401 * Check DACL we just set, except change the bits to what they
1402 * should be.
1403 */
1404 torture_comment(tctx, " checking new sd\n");
1405
1406 /* REQ bit should always be false. */
1407 sd->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1408
1409 if ((tflags[i].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1410 sd->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1411
1412 q.query_secdesc.in.file.handle = handle;
1413 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1414 status = smb2_getinfo_file(tree, tctx, &q);
1415 CHECK_STATUS(status, NT_STATUS_OK);
1416 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
1417
1418 /* Create file. */
1419 torture_comment(tctx, " creating file %s\n", fname1);
1420 io.in.fname = fname1;
1421 io.in.create_options = 0;
1422 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
1423 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1424 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1425 status = smb2_create(tree, tctx, &io);
1426 CHECK_STATUS(status, NT_STATUS_OK);
1427 handle2 = io.out.file.handle;
1428 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1429
1430 q.query_secdesc.in.file.handle = handle2;
1431 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1432 status = smb2_getinfo_file(tree, tctx, &q);
1433 CHECK_STATUS(status, NT_STATUS_OK);
1434
1435 torture_comment(tctx, " checking sd on file %s\n", fname1);
1436 sd2 = security_descriptor_dacl_create(tctx,
1437 tflags[i].child_get_sd_type,
1438 owner_sid, NULL,
1439 owner_sid,
1440 SEC_ACE_TYPE_ACCESS_ALLOWED,
1441 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1442 tflags[i].child_get_ace_inherit,
1443 NULL);
1444 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1445
1446 /*
1447 * Set new sd on file ... prove that the bits have nothing to
1448 * do with the parents bits when manually setting an ACL. The
1449 * _AUTO_INHERITED bit comes directly from the ACL set.
1450 */
1451 for (j = 0; j < ARRAY_SIZE(tflags); j++) {
1452 torture_comment(tctx, " setting new file sd, pass #%d\n", j);
1453
1454 /* Change sd type. */
1455 sd2->type &= ~(SEC_DESC_DACL_AUTO_INHERITED |
1456 SEC_DESC_DACL_AUTO_INHERIT_REQ |
1457 SEC_DESC_DACL_PROTECTED);
1458 sd2->type |= tflags[j].parent_set_sd_type;
1459
1460 sd2->dacl->aces[0].flags &=
1461 ~SEC_ACE_FLAG_INHERITED_ACE;
1462 sd2->dacl->aces[0].flags |=
1463 tflags[j].parent_set_ace_inherit;
1464
1465 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1466 set.set_secdesc.in.file.handle = handle2;
1467 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1468 set.set_secdesc.in.sd = sd2;
1469 status = smb2_setinfo_file(tree, &set);
1470 CHECK_STATUS(status, NT_STATUS_OK);
1471
1472 /* Check DACL we just set. */
1473 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1474 if ((tflags[j].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1475 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1476
1477 q.query_secdesc.in.file.handle = handle2;
1478 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1479 status = smb2_getinfo_file(tree, tctx, &q);
1480 CHECK_STATUS(status, NT_STATUS_OK);
1481
1482 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1483 }
1484
1485 smb2_util_close(tree, handle2);
1486 smb2_util_unlink(tree, fname1);
1487 }
1488
1489 done:
1490 smb2_util_close(tree, handle);
1491 smb2_deltree(tree, BASEDIR);
1492 smb2_tdis(tree);
1493 smb2_logoff(tree->session);
1494 return ret;
1495 }
1496
1497 /*
1498 test dynamic acl inheritance
1499 Note: This test was copied from raw/acls.c.
1500 */
1501 static bool test_inheritance_dynamic(struct torture_context *tctx,
1502 struct smb2_tree *tree)
1503 {
1504 NTSTATUS status;
1505 struct smb2_create io;
1506 const char *dname = BASEDIR "\\inheritance";
1507 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1508 bool ret = true;
1509 struct smb2_handle handle, handle2;
1510 union smb_fileinfo q;
1511 union smb_setfileinfo set;
1512 struct security_descriptor *sd, *sd_orig=NULL;
1513 const char *owner_sid;
1514
1515 torture_comment(tctx, "TESTING DYNAMIC ACL INHERITANCE\n");
1516
1517 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
1518 return false;
1519
1520 ZERO_STRUCT(io);
1521 io.level = RAW_OPEN_SMB2;
1522 io.in.create_flags = 0;
1523 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1524 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1525 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
1526 io.in.share_access = 0;
1527 io.in.alloc_size = 0;
1528 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1529 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
1530 io.in.security_flags = 0;
1531 io.in.fname = dname;
1532
1533 status = smb2_create(tree, tctx, &io);
1534 CHECK_STATUS(status, NT_STATUS_OK);
1535 handle = io.out.file.handle;
1536
1537 torture_comment(tctx, "get the original sd\n");
1538 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1539 q.query_secdesc.in.file.handle = handle;
1540 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1541 status = smb2_getinfo_file(tree, tctx, &q);
1542 CHECK_STATUS(status, NT_STATUS_OK);
1543 sd_orig = q.query_secdesc.out.sd;
1544
1545 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1546
1547 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
1548
1549 sd = security_descriptor_dacl_create(tctx,
1550 0, NULL, NULL,
1551 owner_sid,
1552 SEC_ACE_TYPE_ACCESS_ALLOWED,
1553 SEC_FILE_WRITE_DATA | SEC_STD_DELETE | SEC_FILE_READ_ATTRIBUTE,
1554 SEC_ACE_FLAG_OBJECT_INHERIT,
1555 NULL);
1556 sd->type |= SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ;
1557
1558 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1559 set.set_secdesc.in.file.handle = handle;
1560 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1561 set.set_secdesc.in.sd = sd;
1562 status = smb2_setinfo_file(tree, &set);
1563 CHECK_STATUS(status, NT_STATUS_OK);
1564
1565 torture_comment(tctx, "create a file with an inherited acl\n");
1566 io.in.fname = fname1;
1567 io.in.create_options = 0;
1568 io.in.desired_access = SEC_FILE_READ_ATTRIBUTE;
1569 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1570 status = smb2_create(tree, tctx, &io);
1571 CHECK_STATUS(status, NT_STATUS_OK);
1572 handle2 = io.out.file.handle;
1573 smb2_util_close(tree, handle2);
1574
1575 torture_comment(tctx, "try and access file with base rights - should be OK\n");
1576 io.in.desired_access = SEC_FILE_WRITE_DATA;
1577 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1578 status = smb2_create(tree, tctx, &io);
1579 CHECK_STATUS(status, NT_STATUS_OK);
1580 handle2 = io.out.file.handle;
1581 smb2_util_close(tree, handle2);
1582
1583 torture_comment(tctx, "try and access file with extra rights - should be denied\n");
1584 io.in.desired_access = SEC_FILE_WRITE_DATA | SEC_FILE_EXECUTE;
1585 status = smb2_create(tree, tctx, &io);
1586 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1587
1588 torture_comment(tctx, "update parent sd\n");
1589 sd = security_descriptor_dacl_create(tctx,
1590 0, NULL, NULL,
1591 owner_sid,
1592 SEC_ACE_TYPE_ACCESS_ALLOWED,
1593 SEC_FILE_WRITE_DATA | SEC_STD_DELETE | SEC_FILE_READ_ATTRIBUTE | SEC_FILE_EXECUTE,
1594 SEC_ACE_FLAG_OBJECT_INHERIT,
1595 NULL);
1596 sd->type |= SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ;
1597
1598 set.set_secdesc.in.sd = sd;
1599 status = smb2_setinfo_file(tree, &set);
1600 CHECK_STATUS(status, NT_STATUS_OK);
1601
1602 torture_comment(tctx, "try and access file with base rights - should be OK\n");
1603 io.in.desired_access = SEC_FILE_WRITE_DATA;
1604 status = smb2_create(tree, tctx, &io);
1605 CHECK_STATUS(status, NT_STATUS_OK);
1606 handle2 = io.out.file.handle;
1607 smb2_util_close(tree, handle2);
1608
1609
1610 torture_comment(tctx, "try and access now - should be OK if dynamic inheritance works\n");
1611 io.in.desired_access = SEC_FILE_WRITE_DATA | SEC_FILE_EXECUTE;
1612 status = smb2_create(tree, tctx, &io);
1613 if (NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) {
1614 torture_comment(tctx, "Server does not have dynamic inheritance\n");
1615 }
1616 if (NT_STATUS_EQUAL(status, NT_STATUS_OK)) {
1617 torture_comment(tctx, "Server does have dynamic inheritance\n");
1618 }
1619 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1620
1621 smb2_util_unlink(tree, fname1);
1622
1623 done:
1624 torture_comment(tctx, "put back original sd\n");
1625 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1626 set.set_secdesc.in.file.handle = handle;
1627 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1628 set.set_secdesc.in.sd = sd_orig;
1629 status = smb2_setinfo_file(tree, &set);
1630
1631 smb2_util_close(tree, handle);
1632 smb2_util_rmdir(tree, dname);
1633 smb2_deltree(tree, BASEDIR);
1634 smb2_tdis(tree);
1635 smb2_logoff(tree->session);
1636
1637 return ret;
1638 }
1639
1640 #define CHECK_STATUS_FOR_BIT_ACTION(status, bits, action) do { \
1641 if (!(bits & desired_64)) {\
1642 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED); \
1643 action; \
1644 } else { \
1645 CHECK_STATUS(status, NT_STATUS_OK); \
1646 } \
1647 } while (0)
1648
1649 #define CHECK_STATUS_FOR_BIT(status, bits, access) do { \
1650 if (NT_STATUS_IS_OK(status)) { \
1651 if (!(granted & access)) {\
1652 ret = false; \
1653 torture_result(tctx, TORTURE_FAIL, "(%s) %s but flags 0x%08X are not granted! granted[0x%08X] desired[0x%08X]\n", \
1654 __location__, nt_errstr(status), access, granted, desired); \
1655 goto done; \
1656 } \
1657 } else { \
1658 if (granted & access) {\
1659 ret = false; \
1660 torture_result(tctx, TORTURE_FAIL, "(%s) %s but flags 0x%08X are granted! granted[0x%08X] desired[0x%08X]\n", \
1661 __location__, nt_errstr(status), access, granted, desired); \
1662 goto done; \
1663 } \
1664 } \
1665 CHECK_STATUS_FOR_BIT_ACTION(status, bits, do {} while (0)); \
1666 } while (0)
1667
1668 #if 0
1669 /* test what access mask is needed for getting and setting security_descriptors */
1670 /* Note: This test was copied from raw/acls.c. */
1671 static bool test_sd_get_set(struct torture_context *tctx, struct smb2_tree *tree)
1672 {
1673 NTSTATUS status;
1674 bool ret = true;
1675 struct smb2_create io;
1676 union smb_fileinfo fi;
1677 union smb_setfileinfo si;
1678 struct security_descriptor *sd;
1679 struct security_descriptor *sd_owner = NULL;
1680 struct security_descriptor *sd_group = NULL;
1681 struct security_descriptor *sd_dacl = NULL;
1682 struct security_descriptor *sd_sacl = NULL;
1683 struct smb2_handle handle;
1684 const char *fname = BASEDIR "\\sd_get_set.txt";
1685 uint64_t desired_64;
1686 uint32_t desired = 0, granted;
1687 int i = 0;
1688 #define NO_BITS_HACK (((uint64_t)1)<<32)
1689 uint64_t open_bits =
1690 SEC_MASK_GENERIC |
1691 SEC_FLAG_SYSTEM_SECURITY |
1692 SEC_FLAG_MAXIMUM_ALLOWED |
1693 SEC_STD_ALL |
1694 SEC_FILE_ALL |
1695 NO_BITS_HACK;
1696 uint64_t get_owner_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
1697 uint64_t set_owner_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_OWNER;
1698 uint64_t get_group_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
1699 uint64_t set_group_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_OWNER;
1700 uint64_t get_dacl_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
1701 uint64_t set_dacl_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_DAC;
1702 uint64_t get_sacl_bits = SEC_FLAG_SYSTEM_SECURITY;
1703 uint64_t set_sacl_bits = SEC_FLAG_SYSTEM_SECURITY;
1704
1705 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
1706 return false;
1707
1708 torture_comment(tctx, "TESTING ACCESS MASKS FOR SD GET/SET\n");
1709
1710 /* first create a file with full access for everyone */
1711 sd = security_descriptor_dacl_create(tctx,
1712 0, SID_NT_ANONYMOUS, SID_BUILTIN_USERS,
1713 SID_WORLD,
1714 SEC_ACE_TYPE_ACCESS_ALLOWED,
1715 SEC_GENERIC_ALL,
1716 0,
1717 NULL);
1718 sd->type |= SEC_DESC_SACL_PRESENT;
1719 sd->sacl = NULL;
1720 ZERO_STRUCT(io);
1721 io.level = RAW_OPEN_SMB2;
1722 io.in.create_flags = 0;
1723 io.in.desired_access = SEC_GENERIC_ALL;
1724 io.in.create_options = 0;
1725 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
1726 io.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
1727 io.in.alloc_size = 0;
1728 io.in.create_disposition = NTCREATEX_DISP_OVERWRITE_IF;
1729 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
1730 io.in.security_flags = 0;
1731 io.in.fname = fname;
1732 io.in.sec_desc = sd;
1733 status = smb2_create(tree, tctx, &io);
1734 CHECK_STATUS(status, NT_STATUS_OK);
1735 handle = io.out.file.handle;
1736
1737 status = smb2_util_close(tree, handle);
1738 CHECK_STATUS(status, NT_STATUS_OK);
1739
1740 /*
1741 * now try each access_mask bit and no bit at all in a loop
1742 * and see what's allowed
1743 * NOTE: if i == 32 it means access_mask = 0 (see NO_BITS_HACK above)
1744 */
1745 for (i=0; i <= 32; i++) {
1746 desired_64 = ((uint64_t)1) << i;
1747 desired = (uint32_t)desired_64;
1748
1749 /* first open the file with the desired access */
1750 io.level = RAW_OPEN_SMB2;
1751 io.in.desired_access = desired;
1752 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1753 status = smb2_create(tree, tctx, &io);
1754 CHECK_STATUS_FOR_BIT_ACTION(status, open_bits, goto next);
1755 handle = io.out.file.handle;
1756
1757 /* then check what access was granted */
1758 fi.access_information.level = RAW_FILEINFO_ACCESS_INFORMATION;
1759 fi.access_information.in.file.handle = handle;
1760 status = smb2_getinfo_file(tree, tctx, &fi);
1761 CHECK_STATUS(status, NT_STATUS_OK);
1762 granted = fi.access_information.out.access_flags;
1763
1764 /* test the owner */
1765 ZERO_STRUCT(fi);
1766 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1767 fi.query_secdesc.in.file.handle = handle;
1768 fi.query_secdesc.in.secinfo_flags = SECINFO_OWNER;
1769 status = smb2_getinfo_file(tree, tctx, &fi);
1770 CHECK_STATUS_FOR_BIT(status, get_owner_bits, SEC_STD_READ_CONTROL);
1771 if (fi.query_secdesc.out.sd) {
1772 sd_owner = fi.query_secdesc.out.sd;
1773 } else if (!sd_owner) {
1774 sd_owner = sd;
1775 }
1776 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1777 si.set_secdesc.in.file.handle = handle;
1778 si.set_secdesc.in.secinfo_flags = SECINFO_OWNER;
1779 si.set_secdesc.in.sd = sd_owner;
1780 status = smb2_setinfo_file(tree, &si);
1781 CHECK_STATUS_FOR_BIT(status, set_owner_bits, SEC_STD_WRITE_OWNER);
1782
1783 /* test the group */
1784 ZERO_STRUCT(fi);
1785 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1786 fi.query_secdesc.in.file.handle = handle;
1787 fi.query_secdesc.in.secinfo_flags = SECINFO_GROUP;
1788 status = smb2_getinfo_file(tree, tctx, &fi);
1789 CHECK_STATUS_FOR_BIT(status, get_group_bits, SEC_STD_READ_CONTROL);
1790 if (fi.query_secdesc.out.sd) {
1791 sd_group = fi.query_secdesc.out.sd;
1792 } else if (!sd_group) {
1793 sd_group = sd;
1794 }
1795 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1796 si.set_secdesc.in.file.handle = handle;
1797 si.set_secdesc.in.secinfo_flags = SECINFO_GROUP;
1798 si.set_secdesc.in.sd = sd_group;
1799 status = smb2_setinfo_file(tree, &si);
1800 CHECK_STATUS_FOR_BIT(status, set_group_bits, SEC_STD_WRITE_OWNER);
1801
1802 /* test the DACL */
1803 ZERO_STRUCT(fi);
1804 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1805 fi.query_secdesc.in.file.handle = handle;
1806 fi.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1807 status = smb2_getinfo_file(tree, tctx, &fi);
1808 CHECK_STATUS_FOR_BIT(status, get_dacl_bits, SEC_STD_READ_CONTROL);
1809 if (fi.query_secdesc.out.sd) {
1810 sd_dacl = fi.query_secdesc.out.sd;
1811 } else if (!sd_dacl) {
1812 sd_dacl = sd;
1813 }
1814 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1815 si.set_secdesc.in.file.handle = handle;
1816 si.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1817 si.set_secdesc.in.sd = sd_dacl;
1818 status = smb2_setinfo_file(tree, &si);
1819 CHECK_STATUS_FOR_BIT(status, set_dacl_bits, SEC_STD_WRITE_DAC);
1820
1821 /* test the SACL */
1822 ZERO_STRUCT(fi);
1823 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1824 fi.query_secdesc.in.file.handle = handle;
1825 fi.query_secdesc.in.secinfo_flags = SECINFO_SACL;
1826 status = smb2_getinfo_file(tree, tctx, &fi);
1827 CHECK_STATUS_FOR_BIT(status, get_sacl_bits, SEC_FLAG_SYSTEM_SECURITY);
1828 if (fi.query_secdesc.out.sd) {
1829 sd_sacl = fi.query_secdesc.out.sd;
1830 } else if (!sd_sacl) {
1831 sd_sacl = sd;
1832 }
1833 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1834 si.set_secdesc.in.file.handle = handle;
1835 si.set_secdesc.in.secinfo_flags = SECINFO_SACL;
1836 si.set_secdesc.in.sd = sd_sacl;
1837 status = smb2_setinfo_file(tree, &si);
1838 CHECK_STATUS_FOR_BIT(status, set_sacl_bits, SEC_FLAG_SYSTEM_SECURITY);
1839
1840 /* close the handle */
1841 status = smb2_util_close(tree, handle);
1842 CHECK_STATUS(status, NT_STATUS_OK);
1843 next:
1844 continue;
1845 }
1846
1847 done:
1848 smb2_util_close(tree, handle);
1849 smb2_util_unlink(tree, fname);
1850 smb2_deltree(tree, BASEDIR);
1851 smb2_tdis(tree);
1852 smb2_logoff(tree->session);
1853
1854 return ret;
1855 }
1856 #endif
1857
1858 /*
1859 basic testing of SMB2 ACLs
1860 */
1861 struct torture_suite *torture_smb2_acls_init(void)
1862 {
1863 struct torture_suite *suite = torture_suite_create(talloc_autofree_context(), "acls");
1864
1865 torture_suite_add_1smb2_test(suite, "CREATOR", test_creator_sid);
1866 torture_suite_add_1smb2_test(suite, "GENERIC", test_generic_bits);
1867 torture_suite_add_1smb2_test(suite, "OWNER", test_owner_bits);
1868 torture_suite_add_1smb2_test(suite, "INHERITANCE", test_inheritance);
1869 torture_suite_add_1smb2_test(suite, "INHERITFLAGS", test_inheritance_flags);
1870 torture_suite_add_1smb2_test(suite, "DYNAMIC", test_inheritance_dynamic);
1871 #if 0
1872 /* XXX This test does not work against XP or Vista. */
1873 torture_suite_add_1smb2_test(suite, "GETSET", test_sd_get_set);
1874 #endif
1875
1876 suite->description = talloc_strdup(suite, "SMB2-ACLS tests");
1877
1878 return suite;
1879 }
reg import