gdb/ChangeLog

   1 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * ada-lang.c (_initialize_ada_language): Expand the help text
   4         for the "catch exception" command.
   5
   6 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   7
   8         * symtab.c (matching_obj_sections): Initialize obj,
   9         declare it closer to its usage.
  10
  11 2019-01-10  Tom Tromey  <tom@tromey.com>
  12
  13         * thread-iter.h (inf_threads_iterator): Use next_iterator.
  14         (basic_inf_threads_range): Remove.
  15         (inf_threads_range, inf_non_exited_threads_range)
  16         (safe_inf_threads_range): Use next_adapter.
  17
  18 2019-01-10  Keith Seitz  <keiths@redhat.com>
  19
  20         PR gdb/23712
  21         PR symtab/23010
  22         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
  23         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
  24
  25 2019-01-10  Keith Seitz  <keiths@redhat.com>
  26
  27         PR gdb/23712
  28         PR symtab/23010
  29         * dictionary.c (pending_to_vector): Remove.
  30         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  31         Remove _1 suffix, replacing functions of the same name.  Update
  32         all callers.
  33         (dict_create_hashed, dict_create_hashed_expandable)
  34         (dict_create_linear, dict_create_linear_expandable, dict_free)
  35         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
  36         Make functions static.
  37
  38 2019-01-10  Keith Seitz  <keiths@redhat.com>
  39
  40         PR gdb/23712
  41         PR symtab/23010
  42         * dictionary.h (struct dictionary): Replace declaration with
  43         multidictionary.
  44         (dict_create_hashed, dict_create_hashed_expandable)
  45         (dict_create_linear, dict_create_linear_expandable)
  46         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
  47         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
  48         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
  49         taking multidictionary argument.
  50         [ALL_DICT_SYMBOLS]: Update for multidictionary.
  51         * block.h (struct block) <dict>: Change to multidictionary
  52         and rename `multidict'.
  53         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
  54         symmisc.c: Update all dictionary references to multidictionary.
  55
  56 2019-01-10  Keith Seitz  <keiths@redhat.com>
  57
  58         PR gdb/23712
  59         PR symtab/23010
  60         * dictionary.c: Include unordered_map.
  61         (pending_to_vector): New function.
  62         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  63         Rewrite the non-"_1" functions to take vector instead
  64         of linked list.
  65         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
  66         "new" _1 versions of the same name.
  67         (multidictionary): Define.
  68         (std::hash<enum language): New definition.
  69         (collate_pending_symbols_by_language, mdict_create_hashed)
  70         (mdict_create_hashed_expandable, mdict_create_linear)
  71         (mdict_create_linear_expandable, mdict_free)
  72         (find_language_dictionary, create_new_language_dictionary)
  73         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
  74         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
  75         (mdict_size, mdict_empty): New functions.
  76         * dictionary.h (mdict_iterator): Define.
  77
  78 2019-01-10  Pedro Alves  <palves@redhat.com>
  79
  80         * breakpoint.c (read_uploaded_action)
  81         (create_tracepoint_from_upload): Adjust to use
  82         gdb::unique_xmalloc_ptr.
  83         * ctf.c (ctf_write_uploaded_tp):
  84         (SET_ARRAY_FIELD): Use emplace_back.
  85         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
  86         * tracefile-tfile.c (tfile_write_uploaded_tp):
  87         * tracepoint.c (parse_tracepoint_definition): Adjust to use
  88         gdb::unique_xmalloc_ptr.
  89         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
  90         at_string, cond_string, cmd_strings>: Replace char pointers
  91         with gdb::unique_xmalloc_ptr.
  92
  93 2019-01-10  Pedro Alves  <palves@redhat.com>
  94
  95         * solib-target.c (library_list_start_library): Don't xstrdup name.
  96
  97 2019-01-10  Pedro Alves  <palves@redhat.com>
  98
  99         * mdebugread.c (parse_partial_symbols): Use
 100         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 101
 102 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 103
 104         * linux-fork.c (scoped_switch_fork_info)
 105         <~scoped_switch_fork_info>: Fix incorrect variable name.
 106
 107 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 108
 109         * linux-fork.c (scoped_switch_fork_info)
 110         <scoped_switch_fork_info>: Make explicit.
 111         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 112
 113 2019-01-10  Tom Tromey  <tom@tromey.com>
 114
 115         * objfiles.h (objfile::reset_psymtabs): Update.
 116         * objfiles.c (objfile::objfile): Update.
 117         * psymtab.h (psymtab_storage::obstack): Update.
 118         (psymtab_storage::m_obstack): Use gdb::optional.
 119         (class psymtab_storage): Update comment.  Remove objfile
 120         parameter.
 121         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 122
 123 2019-01-10  Tom Tromey  <tom@tromey.com>
 124
 125         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 126         <free_psymtabs>: Now private.
 127         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 128         (allocate_psymtab): Use new method.
 129
 130 2019-01-10  Tom Tromey  <tom@tromey.com>
 131
 132         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 133         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 134         * mdebugread.c (parse_partial_symbols): Use
 135         allocate_dependencies.
 136         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 137         allocate_dependencies.
 138         (process_psymtab_comp_unit_reader)
 139         (build_type_psymtab_dependencies): Likewise.
 140         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 141
 142 2019-01-10  Tom Tromey  <tom@tromey.com>
 143
 144         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 145         PSYMBOL_SET_LANGUAGE.
 146         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 147
 148 2019-01-10  Tom Tromey  <tom@tromey.com>
 149
 150         * psymtab.h (psymtab_storage::obstack): New method.
 151         <m_obstack>: Rename from obstack; now private.
 152         * psymtab.c (psymtab_storage): Update.
 153         * dwarf2read.c (create_addrmap_from_index)
 154         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 155         Update.
 156
 157 2019-01-10  Tom Tromey  <tom@tromey.com>
 158
 159         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 160         * objfiles.h (objfile::reset_psymtabs): New method.
 161
 162 2019-01-10  Tom Tromey  <tom@tromey.com>
 163
 164         * symmisc.c (print_symbol_bcache_statistics): Update.
 165         (print_objfile_statistics): Update.
 166         * symfile.c (reread_symbols): Update.
 167         * psymtab.h (class psymtab_storage): New.
 168         * psymtab.c (psymtab_storage): New constructor.
 169         (~psymtab_storage): New destructor.
 170         (require_partial_symbols): Update.
 171         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 172         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 173         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 174         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 175         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 176         (start_psymtab_common, end_psymtab_common)
 177         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 178         (allocate_psymtab): Update.
 179         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 180         Update.
 181         (dump_psymtab_addrmap, maintenance_print_psymbols)
 182         (maintenance_check_psymtabs): Update.
 183         (class objfile_psymtabs): Move to objfiles.h.
 184         * psympriv.h (discard_psymtab): Now inline.
 185         (psymtab_discarder::psymtab_discarder): Update.
 186         (psymtab_discarder::~psymtab_discarder): Update.
 187         (ALL_OBJFILE_PSYMTABS): Rewrite.
 188         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 189         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 190         Remove fields.
 191         <partial_symtabs>: New field.
 192         (class objfile_psymtabs): Move from psymtab.h.  Update.
 193         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 194         psymbol_cache.
 195         (objfile::~objfile): Don't destroy psymbol_cache.
 196         * mdebugread.c (parse_partial_symbols): Update.
 197         * dwarf2read.c (create_addrmap_from_index)
 198         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 199         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 200         (add_partial_subprogram, dwarf2_ranges_read): Update.
 201         * dwarf-index-write.c (write_address_map)
 202         (write_one_signatured_type, recursively_write_psymbols)
 203         (class debug_names, class debug_names, write_psymtabs_to_index):
 204         Update.
 205
 206 2019-01-10  Tom Tromey  <tom@tromey.com>
 207
 208         * symtab.h (SYMBOL_SET_NAMES): Update.
 209         (symbol_set_names): Update.
 210         (MSYMBOL_SET_NAMES): Update.
 211         * symtab.c (symbol_set_names): Change argument to be an
 212         objfile_per_bfd_storage.
 213         * psymtab.c (add_psymbol_to_bcache): Update.
 214         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 215
 216 2019-01-10  Tom Tromey  <tom@tromey.com>
 217
 218         * symtab.c (create_demangled_names_hash): Change argument to be an
 219         objfile_per_bfd_storage.
 220         (symbol_set_names): Update.
 221
 222 2019-01-10  Tom Tromey  <tom@tromey.com>
 223
 224         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 225         init_psymbol_list.
 226         * psymtab.c (init_psymbol_list): Do nothing if already called.
 227         * psympriv.h (init_psymbol_list): Add comment.
 228         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 229         init_psymbol_list.
 230         * dbxread.c (dbx_symfile_read): Unconditionally call
 231         init_psymbol_list.
 232
 233 2019-01-10  Tom Tromey  <tom@tromey.com>
 234
 235         * xcoffread.c (scan_xcoff_symtab): Update.
 236         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 237         "where".
 238         * mdebugread.c (parse_partial_symbols)
 239         (handle_psymbol_enumerators): Update.
 240         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 241         * dbxread.c (read_dbx_symtab): Update.
 242         * psympriv.h (psymbol_placement): New enum.
 243         (add_psymbol_to_list): Update.
 244
 245 2019-01-10  Tom Tromey  <tom@tromey.com>
 246
 247         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 248         static_psymbols parameters.
 249         (scan_xcoff_symtab): Update.
 250         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 251         static_psymbols parameters.
 252         * psympriv.h (start_psymtab_common): Update.
 253         * mdebugread.c (parse_partial_symbols): Update.
 254         * dwarf2read.c (create_partial_symtab): Update.
 255         * dbxread.c (read_dbx_symtab): Update.
 256         (start_psymtab): Remove global_psymbols and static_psymbols
 257         parameters.
 258
 259 2019-01-10  Tom Tromey  <tom@tromey.com>
 260
 261         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 262         * psymtab.c (allocate_psymtab): Add comment.
 263         * psympriv.h (allocate_psymtab): Add comment.
 264         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 265         initializations.
 266         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 267
 268 2019-01-10  Tom Tromey  <tom@tromey.com>
 269
 270         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 271         Don't declare.
 272         * mipsread.c: Include mdebugread.h.
 273         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 274         Declare.
 275         * elfread.c: Include mdebugread.h.
 276
 277 2019-01-09  Tom Tromey  <tom@tromey.com>
 278
 279         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 280         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 281         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 282         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 283         (psym_lookup_symbol, psym_find_last_source_symtab)
 284         (psym_forget_cached_source_info, psym_print_stats)
 285         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 286         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 287         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 288         (psym_find_compunit_symtab_by_address)
 289         (maintenance_print_psymbols, maintenance_info_psymtabs)
 290         (maintenance_check_psymtabs): Use ranged for.
 291         * psymtab.h (class objfile_psymtabs): New.
 292         (require_partial_symbols): Return objfile_psymtabs.
 293         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 294
 295 2019-01-09  Tom Tromey  <tom@tromey.com>
 296
 297         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 298         (find_pc_mapped_section, list_overlays_command)
 299         (map_overlay_command, unmap_overlay_command)
 300         (simple_overlay_update): Use all_objfiles.
 301         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 302         * printcmd.c (info_symbol_command): Use all_objfiles.
 303         * objfiles.h (ALL_OBJSECTIONS): Remove.
 304         * maint.c (maintenance_translate_address): Use all_objfiles.
 305         * gcore.c (gcore_create_callback): Use all_objfiles.
 306         (objfile_find_memory_regions): Likewise.
 307
 308 2019-01-09  Tom Tromey  <tom@tromey.com>
 309
 310         * symtab.c (find_line_symtab, info_sources_command)
 311         (make_source_files_completion_list): Use objfile_compunits.
 312         * source.c (select_source_symtab): Use objfile_compunits.
 313         * objfiles.h (struct objfile): Update comment.
 314         (ALL_OBJFILES): Remove.
 315         (ALL_FILETABS): Remove.
 316         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 317         objfile_compunits.
 318
 319 2019-01-09  Tom Tromey  <tom@tromey.com>
 320
 321         * symmisc.c (print_objfile_statistics, dump_objfile)
 322         (maintenance_print_symbols): Use compunit_filetabs.
 323         * source.c (forget_cached_source_info_for_objfile): Use
 324         compunit_filetabs.
 325         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 326         (ALL_FILETABS): Use compunit_filetabs.
 327         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 328         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 329
 330 2019-01-09  Tom Tromey  <tom@tromey.com>
 331
 332         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 333         (compunit_filetabs): New.
 334         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 335         compunit_filetabs.
 336         (info_sources_command, make_source_files_completion_list): Remove
 337         declaration.
 338         * symmisc.c (print_objfile_statistics, dump_objfile)
 339         (maintenance_print_symbols): Remove declaration.
 340         (maintenance_info_symtabs): Use compunit_filetabs.
 341         (maintenance_info_line_tables): Likewise.
 342         * source.c (select_source_symtab): Change local variable name.
 343         (forget_cached_source_info_for_objfile): Remove declaration.
 344         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 345         * objfiles.c (objfile_relocate1): Remove declaration.
 346         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 347         declaration.
 348         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 349         * coffread.c (coff_symtab_read): Remove declaration.
 350         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 351         compunit_filetabs.
 352
 353 2019-01-09  Tom Tromey  <tom@tromey.com>
 354
 355         * symtab.c (lookup_objfile_from_block)
 356         (find_pc_sect_compunit_symtab, search_symbols)
 357         (default_collect_symbol_completion_matches_break_on): Use
 358         objfile_compunits.
 359         * objfiles.h (ALL_COMPUNITS): Remove.
 360         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 361         * cp-support.c (add_symbol_overload_list_qualified): Use
 362         objfile_compunits.
 363         * ada-lang.c (ada_collect_symbol_completion_matches)
 364         (ada_add_global_exceptions): Use objfile_compunits.
 365
 366 2019-01-09  Tom Tromey  <tom@tromey.com>
 367
 368         * source.c (select_source_symtab)
 369         (forget_cached_source_info_for_objfile): Remove declaration.
 370         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 371         declaration.
 372         * maint.c (count_symtabs_and_blocks): Remove declaration.
 373         * cp-support.c (add_symbol_overload_list_qualified): Remove
 374         declaration.
 375         * coffread.c (coff_symtab_read): Remove declaration.
 376         * symtab.c (lookup_symbol_in_objfile_symtabs)
 377         (basic_lookup_transparent_type_1): Use objfile_compunits.
 378         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 379         (info_sources_command, search_symbols)
 380         (default_collect_symbol_completion_matches_break_on)
 381         (make_source_files_completion_list): Remove declaration.
 382         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 383         (ada_collect_symbol_completion_matches)
 384         (ada_add_global_exceptions): Remove declaration.
 385         * linespec.c (iterate_over_all_matching_symtabs): Use
 386         objfile_compunits.
 387         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 388         (class objfile_compunits): New.
 389         (ALL_COMPUNITS): Use objfile_compunits.
 390         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 391         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 392         objfile_compunits.
 393         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 394
 395 2019-01-09  Tom Tromey  <tom@tromey.com>
 396
 397         * symtab.c (search_symbols)
 398         (default_collect_symbol_completion_matches_break_on): Use
 399         objfile_msymbols.
 400         * ada-lang.c (ada_lookup_simple_minsym)
 401         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 402         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 403         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 404         objfile_msymbols.
 405         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 406         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 407         * objc-lang.c (find_methods): Use objfile_msymbols.
 408         (info_selectors_command, info_classes_command): Likewise.
 409         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 410         * objfiles.h (class objfile_msymbols): New.
 411         (ALL_OBJFILE_MSYMBOLS): Remove.
 412         (ALL_MSYMBOLS): Remove.
 413
 414 2019-01-09  Tom Tromey  <tom@tromey.com>
 415
 416         * common/next-iterator.h (next_adapter): Add Iterator template
 417         parameter.
 418         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 419         (class all_objfiles_safe): New.
 420         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 421         * objfiles.c (put_objfile_before): Update comment.
 422         (add_separate_debug_objfile): Likewise.
 423         (free_all_objfiles): Use all_objfiles_safe.
 424         (objfile_purge_solibs): Likewise.
 425
 426 2019-01-09  Tom Tromey  <tom@tromey.com>
 427
 428         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 429         (expand_symtab_containing_pc, lookup_static_symbol)
 430         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 431         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 432         all_objfiles.
 433         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 434         * breakpoint.c (create_overlay_event_breakpoint)
 435         (create_longjmp_master_breakpoint)
 436         (create_std_terminate_master_breakpoint)
 437         (create_exception_master_breakpoint): Use all_objfiles.
 438         * linux-thread-db.c (try_thread_db_load_from_pdir)
 439         (has_libpthread): Use all_objfiles.
 440         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 441         * linespec.c (iterate_over_all_matching_symtabs)
 442         (search_minsyms_for_name): Use all_objfiles.
 443         * maint.c (maintenance_info_sections): Use all_objfiles.
 444         * main.c (captured_main_1): Use all_objfiles.
 445         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 446         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 447         * guile/scm-pretty-print.c
 448         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 449         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 450         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 451         (maintenance_print_msymbols): Use all_objfiles.
 452         * source.c (select_source_symtab): Use all_objfiles.
 453         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 454         * symfile.c (remove_symbol_file_command)
 455         (expand_symtabs_matching, map_symbol_filenames): Use
 456         all_objfiles.
 457         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 458         all_objfiles.
 459         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 460         * objc-lang.c (find_methods): Use all_objfiles.
 461         * objfiles.c (have_partial_symbols, have_full_symbols)
 462         (have_minimal_symbols, qsort_cmp)
 463         (default_iterate_over_objfiles_in_search_order): Use
 464         all_objfiles.
 465         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 466         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 467         (maintenance_check_psymtabs): Use all_objfiles.
 468         (ALL_PSYMTABS): Remove.
 469         * compile/compile-object-run.c (do_module_cleanup): Use
 470         all_objfiles.
 471         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 472         * cp-support.c (add_symbol_overload_list_qualified): Use
 473         all_objfiles.
 474         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 475         Use all_objfiles.
 476         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 477         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 478         all_objfiles.
 479         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 480         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 481         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 482         Uses all_objfiles.
 483         * solib.c (solib_read_symbols): Use all_objfiles
 484
 485 2019-01-09  Tom Tromey  <tom@tromey.com>
 486
 487         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 488         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 489         all_objfiles.
 490         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 491         * symmisc.c (print_symbol_bcache_statistics)
 492         (print_objfile_statistics, maintenance_print_objfiles)
 493         (maintenance_info_symtabs, maintenance_check_symtabs)
 494         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 495         all_objfiles.
 496         * source.c (forget_cached_source_info): Use all_objfiles.
 497         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 498         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 499         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 500         * objfiles.c (update_section_map): Use all_objfiles.
 501         (shared_objfile_contains_address_p): Likewise.
 502         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 503         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 504
 505 2019-01-09  Tom Tromey  <tom@tromey.com>
 506
 507         * common/next-iterator.h: New file.
 508         * objfiles.h (class all_objfiles): New.
 509         (struct objfile_iterator): New.
 510
 511 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 512
 513         * NEWS: Move the description of the changed "frame", "select-frame",
 514          and "info frame" commands to the Changed commands section.
 515
 516 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 517
 518         * gdbtypes.c (check_stub_method_group): Remove handling of old
 519         mangling schemes.
 520         * linespec.c (find_methods): Likewise.
 521         * stabsread.c (read_member_functions): Likewise.
 522         * valops.c (search_struct_method): Likewise.
 523         (value_struct_elt_for_reference): Likewise.
 524         * NEWS: Mention this change.
 525
 526 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 529         print_source_lines.
 530         * source.c (print_source_lines_base): Update line number check.
 531         (print_source_lines): New function.
 532         (source_lines_range::source_lines_range): New function.
 533         * source.h (class source_lines_range): New class.
 534         (print_source_lines): New declaration.
 535
 536 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 537
 538         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 539
 540 2019-01-08  Tom Tromey  <tom@tromey.com>
 541             Simon Marchi  <simon.marchi@ericsson.com>
 542
 543         PR gdb/24060
 544         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 545         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 546         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 547         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 548         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 549         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 550
 551 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * source.c (select_source_symtab): Move header comment to
 554         declaration in source.h.
 555         (forget_cached_source_info_for_objfile): Likewise.
 556         (forget_cached_source_info): Likewise.
 557         (identify_source_line): Likewise.
 558         * source.h (identify_source_line): Move declaration from symtab.h
 559         and add comment from source.c
 560         (print_source_lines): Likewise.
 561         (forget_cached_source_info_for_objfile): Likewise.
 562         (forget_cached_source_info): Likewise.
 563         (select_source_symtab): Likewise.
 564         (enum print_source_lines_flag): Move definition from symtab.h.
 565         * symtab.h (identify_source_line): Move declaration to source.h.
 566         (print_source_lines): Likewise.
 567         (forget_cached_source_info_for_objfile): Likewise.
 568         (forget_cached_source_info): Likewise.
 569         (select_source_symtab): Likewise.
 570         (enum print_source_lines_flag): Move definition to source.h.
 571         * tui/tui-hooks.c: Add 'source.h' include.
 572
 573 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * source.c (print_source_lines_base): Handle requests to print
 576         reverse line number sequences, and guard against empty lines
 577         string.
 578
 579 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * source.c (print_source_lines_base): Fix skip of '\r' if next
 582         character is '\n'.
 583
 584 2019-01-06  Tom Tromey  <tom@tromey.com>
 585
 586         * c-exp.y (struct c_parse_state) <macro_original_text,
 587         expansion_obstack>: New member.
 588         (macro_original_text, expansion_obstack): Remove globals.
 589         (scan_macro_expansion, scanning_macro_expansion)
 590         (finished_macro_expansion): Update.
 591         (scan_macro_cleanup): Remove.
 592         (yylex, c_parse): Update.
 593
 594 2019-01-06  Tom Tromey  <tom@tromey.com>
 595
 596         * c-exp.y (struct c_parse_state) <strings>: New member.
 597         (operator_stoken): Update.
 598
 599 2019-01-06  Tom Tromey  <tom@tromey.com>
 600
 601         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 602         (union type_stack_elt) <typelist_val>: Now a pointer to
 603         std::vector.
 604         (type_stack_cleanup): Don't declare.
 605         (push_typelist): Update.
 606         * parse.c (pop_typelist): Return a std::vector.
 607         (push_typelist): Take a std::vector.
 608         (follow_types): Update.  Do not free args.
 609         (type_stack_cleanup): Remove.
 610         * c-exp.y (struct c_parse_state): New.
 611         (cpstate): New global.
 612         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 613         (nonempty_typelist): Update.
 614         (func_mod): Create a new vector.
 615         (c_parse): Create a c_parse_state.
 616         (check_parameter_typelist): Do not delete params.
 617         (function_method): Update.  Do not delete type_list.
 618
 619 2019-01-06  Tom Tromey  <tom@tromey.com>
 620
 621         PR gdb/28155:
 622         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 623         check_typedef.
 624         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 625         (print_return_value): Likewise.
 626
 627 2019-01-05  Tom Tromey  <tom@tromey.com>
 628
 629         * contrib/cleanup_check.py: Remove.
 630         * contrib/gcc-with-excheck: Remove.
 631         * contrib/exsummary.py: Remove.
 632         * contrib/excheck.py: Remove.
 633
 634 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 635
 636         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 637         NULL. Initialize tpprev to NULL instead of assigning it
 638         to NULL on the next statement.
 639         * windows-nat.c (windows_delete_thread): Remove check for
 640         main_thread_id before printing thread exit notifications.
 641         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 642         Remove thread ID check against main_thread_id.
 643         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 644         windows_delete_thread.
 645         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 646
 647 2019-01-04  Tom Tromey  <tom@tromey.com>
 648
 649         * compile/compile.c (_initialize_compile): Use upper case for
 650         metasyntactic variables.
 651         * symmisc.c (_initialize_symmisc): Use upper case for
 652         metasyntactic variables.
 653         * psymtab.c (_initialize_psymtab): Use upper case for
 654         metasyntactic variables.
 655         * demangle.c (demangle_command): Use upper case for metasyntactic
 656         variables.
 657         (_initialize_demangler): Likewise.
 658         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 659         variables.
 660
 661 2019-01-03  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 664
 665 2019-01-03  Tom Tromey  <tom@tromey.com>
 666
 667         * python/py-symtab.c (salpy_str): Update.
 668         (struct salpy_sal_object) <symtab>: Now a PyObject.
 669         (salpy_dealloc): Update.
 670         (del_objfile_sal): Use gdbpy_ref.
 671
 672 2019-01-03  Tom Tromey  <tom@tromey.com>
 673
 674         * python/py-type.c (convert_field): Use new_reference.  Return
 675         gdbpy_ref.
 676         (make_fielditem): Return gdbpy_ref.
 677         (typy_fields): Update.
 678         (typy_getitem): Update.
 679         (field_name): Return gdbpy_ref.  Use new_reference.
 680         (typy_iterator_iternext): Update.
 681
 682 2019-01-03  Tom Tromey  <tom@tromey.com>
 683
 684         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 685
 686 2019-01-03  Tom Tromey  <tom@tromey.com>
 687
 688         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 689         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 690         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 691         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 692         (pspy_set_type_printers): Likewise.
 693         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 694         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 695         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 696         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 697         (objfpy_set_type_printers): Likewise.
 698
 699 2019-01-03  Tom Tromey  <tom@tromey.com>
 700
 701         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 702         (gdbpy_print_stack): Use gdbpy_err_fetch.
 703         * python/python-internal.h (class gdbpy_err_fetch): New class.
 704         (class gdbpy_enter) <m_error_type, m_error_value,
 705         m_error_traceback>: Remove.
 706         <m_error>: New member.
 707         (gdbpy_exception_to_string): Don't declare.
 708         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 709         * python/py-value.c (convert_value_from_python): Use
 710         gdbpy_err_fetch.
 711         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 712         gdbpy_exception_to_string.
 713         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 714         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 715         gdbpy_err_fetch.
 716
 717 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 718
 719         * linux-nat.c (delete_lwp_cleanup): Delete.
 720         (struct lwp_deleter): New struct.
 721         (lwp_info_up): New typedef.
 722         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 723         lwp_info_up.
 724
 725 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * linux-fork.c (class scoped_switch_fork_info): New class.
 728         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 729
 730 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * valops.c (find_overload_match): Remove use of null_cleanup, and
 733         calls to do_cleanups.
 734
 735 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * compile/compile-cplus-types.c
 738         (compile_cplus_instance::decl_name): Handle changes to
 739         cp_func_name.
 740         * cp-support.c (cp_func_name): Update header comment, update
 741         return type.
 742         * cp-support.h (cp_func_name): Update return type in declaration.
 743         * valops.c (find_overload_match): Move temp_func local to top
 744         level of function and change its type.  Use temp_func to hold and
 745         delete temporary string obtained from cp_func_name.
 746
 747 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 748
 749         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 750         gdb::char_vector, remove cleanup, and update uses of `msg`.
 751
 752 2019-01-03  Jim Wilson  <jimw@sifive.com>
 753
 754         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 755
 756 2019-01-02  Tom Tromey  <tom@tromey.com>
 757
 758         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 759         (tdesc_parse_xml): Remove cleanups.
 760         * target-descriptions.h (make_cleanup_free_target_description):
 761         Don't declare.
 762         (target_desc_deleter): New struct.
 763         (target_desc_up): New typedef.
 764         * target-descriptions.c (target_desc_deleter::operator()): Rename
 765         from free_target_description.
 766         (make_cleanup_free_target_description): Remove.
 767
 768 2019-01-02  Tom Tromey  <tom@tromey.com>
 769
 770         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 771         constructor, destructor.
 772         (linespec_parser): Remove typedef.
 773         (~linespec_parser): Rename from linespec_parser_delete.
 774         (linespec_lex_to_end, linespec_complete_label)
 775         (linespec_complete): Update.
 776         (decode_line_full): Remove cleanups.
 777         (decode_line_1): Update.
 778
 779 2019-01-02  Tom Tromey  <tom@tromey.com>
 780
 781         * python/python-internal.h (inferior_to_inferior_object): Change
 782         return type.
 783         * python/py-exitedevent.c (create_exited_event_object): Update.
 784         * python/py-inferior.c (inferior_to_inferior_object): Return
 785         gdbpy_ref.
 786         (python_new_inferior, python_inferior_deleted)
 787         (thread_to_thread_object, delete_thread_object)
 788         (build_inferior_list, gdbpy_selected_inferior): Update.
 789         * python/py-infthread.c (create_thread_object): Update.  Also fail
 790         if inferior_to_inferior_object fails.
 791
 792 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 793
 794         * inferior.h (class inferior) <displaced_step_state>: New field.
 795         * infrun.h (struct displaced_step_state): Move here from
 796         infrun.c.  Initialize fields, add constructor.
 797         <inf>: Remove field.
 798         <reset>: New method.
 799         * infrun.c (struct displaced_step_inferior_state): Move to
 800         infrun.h.
 801         (displaced_step_inferior_states): Remove.
 802         (get_displaced_stepping_state): Adust.
 803         (displaced_step_in_progress_any_inferior): Adjust.
 804         (displaced_step_in_progress_thread): Adjust.
 805         (displaced_step_in_progress): Adjust.
 806         (add_displaced_stepping_state): Remove.
 807         (get_displaced_step_closure_by_addr): Adjust.
 808         (remove_displaced_stepping_state): Remove.
 809         (infrun_inferior_exit): Call displaced_step_state.reset.
 810         (use_displaced_stepping): Don't check for NULL.
 811         (displaced_step_prepare_throw): Call
 812         get_displaced_stepping_state.
 813         (displaced_step_fixup): Don't check for NULL.
 814         (prepare_for_detach): Don't check for NULL.
 815
 816 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817
 818         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 819          in case of call that did not complete.
 820
 821 2019-01-02  Andrey Utkin  <autkin@undo.io>
 822
 823         * symfile.c (find_separate_debug_file): Fix search of debug files for
 824         remote debuggee.
 825
 826 2019-01-02  Tom Tromey  <tom@tromey.com>
 827
 828         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 829         indentation.
 830         * python/py-frame.c (frapy_older): Remove cast.
 831         (frapy_newer): Likewise.
 832         * python/py-breakpoint.c (local_setattro): Remove cast.
 833         * python/py-arch.c (archpy_name): Remove local variable.
 834         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 835
 836 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 837
 838         * unittests/basic_string_view/element_access/char/empty.cc:
 839         Fix year range in copyright header.
 840
 841 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 842
 843         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 844         Delete.
 845         <operator==>: Update with for removed field.
 846         <hash>: Likewise.
 847         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 848         <isa_features>: ...this.
 849         <abi_features>: New field.
 850         (riscv_isa_flen): Update comment.
 851         (riscv_abi_xlen): New declaration.
 852         (riscv_abi_flen): New declaration.
 853         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 854         isa_features.
 855         (riscv_abi_xlen): New function.
 856         (riscv_isa_flen): Update to get answer from isa_features.
 857         (riscv_abi_flen): New function.
 858         (riscv_has_fp_abi): Update to get answer from abi_features.
 859         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 860         xlen and flen.
 861         (riscv_call_info) <xlen, flen>: Update comment.
 862         (riscv_call_arg_struct): Remove invalid assertions
 863         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 864         is removed.
 865         (riscv_gdbarch_init): Gather isa features and abi features
 866         separately, ensure both match on the gdbarch when reusing an old
 867         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 868         a target with 64-bit float hardware.
 869
 870 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 871
 872         * source.c (search_command_helper): Stop reverse search
 873         when line 1 has been searched.
 874
 875 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876
 877         * record-full.c (record_full_base_target::close): Rewrite
 878         record_full_core_buf_list free logic.
 879
 880 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 881
 882         * break-catch-syscall.c (print_one_catch_syscall): xfree
 883         the last text.
 884
 885 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 886
 887         * top.c (print_gdb_version): Update Copyright year in version
 888         message.
 889
 890 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 891
 892         Update copyright year range in all GDB files.
 893
 894 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 895
 896         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 897
 898 For older changes see ChangeLog-2018.
 899 \f
 900 Local Variables:
 901 mode: change-log
 902 left-margin: 8
 903 fill-column: 74
 904 version-control: never
 905 coding: utf-8
 906 End:
 907